Following the review of this on GitLab, this is ready to be merged as well.

Ready to be merged.

Yes, this ready to be merged, assuming that a check has been made to make sure that all of the histogram tests produce something sensible, i.e. they produce non-zero histograms and all of the entries are inside the bin ranges etc.

Changes look good.

Changes look OK.

Thanks for spotting the parameter ordering error. We also need to fix this for D119 for the Sim10 branch "R02-02-00-patches". What is the best way to proceed?

• Set number of events as 5,000 for the D0ToKspipi JSON tests.

• Fix ordering of LASS parameters in D0ToKspipi. Updated History file.

Validation plots comparing the EvtGen model with the Belle/BaBar paper:

This can be merged. Good to have this code cleanup.

Code looks OK. Thanks for the info about the thread safety aspects.

Changes look good.

• Use EvtDalitzReso const correctness from gitlab commit c51a5f79.

Yes, adding the const functions would be good, then we can simplify retrieving the resonances for the total amplitude as suggested. What is the specific git commit I should use?

This code is ready to be merged. We will leave the ability to change the Sherpa configuration via decay file parameters as a future enhancement.

Only spotted a few minor things, otherwise this is ready to be merged.

I have a few minor suggestions about adding more comments and have suggested a way that we can define the Sherpa parameters via the decay file.

I agree that these changes look OK.

This is ready to be merged.

Changes look OK.

Changes look OK, although you will need to update the History file to include the latest changes made by D100.

These changes look OK, although I think you need to "undo" the fix for EvtBcVHad since this has been done in D100 that has been recently merged (which also makes significant changes to other parts of that class). So just update this class to the version in the current master, otherwise I think you will get a merge conflict (for those other parts that have changed).

• Merge branch 'master' of ssh://phab.hepforge.org/source/evtgen

I've attached a comparison of some of the angular distributions that was used for the Ds -> phi pi, phi -> pi pi pi0 decay (comparing this MR with those from the LHCb Sim meeting talk). It needs new decay angle calculations in the test program.

• Add cosThetaResNorm & cosBetaRes angles to testDecayModel. Used in added test file for Ds -> phi pi, phi -> pi pi pi0. Make EvtVector4R::cross() function constant.

The updated formatting looks good. This is ready to be merged for the new release.

Formatting and CI check look OK.

Yes, this is OK.

Update looks OK.

Clang formatting and CI check looks OK, so proceed with organising the appropriate branches.

All of the changes look OK. Just have a query about some K-matrix code that is commented out. Otherwise this can be merged.

Changes look OK.

Code updated to address the first set of review comments.

• Edits for 1st review round for D100

Here are the JSON test distributions for the EvtBcVPPHad and EvtPhiDalitz model updates, which includes some comparisons with tests done by the previous LHCb code review:

Changes look OK. This can be merged.

Code looks good.

Thanks for updating the interface, Tom. I agree that it will be easier to release this as a patch release based on R02-02-00.

• Set default cosTheta to 1 for EvtSLBaryonAmp spin density matrix.
• Undo max prob changes to EvtSSD_DirectCP since we are going to try a more general approach.

Many of the zero nDof histograms in problem-histos.txt occur when there is only 1 bin filled (the others are empty), e.g. a constant PDG mass value with essentially zero width or a fixed momentum in a 2-body decay. So we could add a check for non-zero entries within the histogram range if nDof = 0 in addition to the chiSq/nDof number.

1. We should increase the tensor probability from 10 to 20 for EvtSSD_DirectCP (e.g. for B+ -> f_2 pi).

Result of the command grep "chiSq/nDof" *.out | grep -v "pValue = 0.000" > problem-histos.txt

I have added some example tests for this, and have also created a task where we could add more tests for other models in the future: https://phab.hepforge.org/T205

• Add tests for Bc -> J/psi pi pi0 & psi(2S) pi BC_VHAD modes.

• Update History file to mention D89.

Looks like the documents contain all of the relevant information.

The new updates using the mass ranges look OK.

1. Yes, increasing the safety factor to 10% is sensible.

This clever solution for finding ASqMax looks OK overall, so I am approving these changes.

The maximum probability is now set at 10, but we may want to revisit this model (reopening this task) in order to reduce the small but very long probability distribution tail that extends beyond 10.

This now appears to be fixed in the master branch.

Fixed in the master branch.

Fixed in the master branch.

The BTOSLLALI max prob has been increased by 25%, to try to avoid the warnings, in commit b162af83 in the GitLab branch 1-complete-test-coverage-of-all-decay-models.

Undefined max probability was set to 10.0 in commit a36bf4cd on the GitLab branch 1-complete-test-coverage-of-all-decay-models. However, this does not address the problem of larger probability values that can occur in the high tail region, as mentioned previously.

This has been fixed in commit a184c939 on the 1-complete-test-coverage-of-all-decay-models branch.

This has been corrected in commit 4c5d60c3 on the 1-complete-test-coverage-of-all-decay-models branch.

Changes look OK. It is good to see unnecessary pointers being removed. Just have a few minor suggestions.

Thanks for the clarification about the BF values chosen, Michal. I agree that all of the changes are OK. I will accept this revision after we finalise any required copyright/documentation changes to the scripts according to Tom's suggestions.

I'm not an expert on cmake but all of the changes look OK and we can add more checks/features as time goes on. Let us go ahead and add this to the repository.

Thanks for these changes, Michal. Just to double-check, the PDG webpage has the following BFs for the psi(2S) and eta_c modes: 5.8e-4 and 8.0e-4. Do we need to use different values (6.2e-4 and 9.0e-4) to balance things owing to the pythia hadronisation modes? The pythia modes also have slightly larger BFs than before.