Add EvtD0ToKspipi DP model, courtesy of Camille Normand (LHCb), based on D119.
Details
Details
- Reviewers
abudinen kreps tlatham - Commits
- rEVTGEN32ca431f06a4: Add EvtD0ToKspipi DP model.
Added two JSON test files, one with the D0 mode only and another including the parent B decay.
Diff Detail
Diff Detail
- Repository
- rEVTGEN evtgen
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks for this @jback! I've just spotted a couple of small things.
I've run the two test JSON files with the changes that I've suggested and it doesn't seem to have much impact on the massSq distributions - they still look approximately like the ones in the PDF you attached, although the stats are lower. However, maybe best to run them yourself and compare them to what you had before to be really sure.
| src/EvtGenModels/EvtD0ToKspipi.cpp | ||
|---|---|---|
| 203–205 | clang-16 reports a warning here: warning: implicit conversion from 'double' to 'bool' changes value from -1 to true [-Wliteral-conversion]
LASS_phi_F, LASS_R, LASS_phi_R, false, -1.0 );Looking at the EvtDalitzReso constructor signatures, it looks like the last two arguments are the wrong way around. | |
| 234–236 | Similarly. | |
| src/EvtGenModels/EvtModelReg.cpp | ||
| 61 | clang-format wants to put this two lines higher, just after EvtCBTo3piP00.hh | |
Comment Actions
Thanks for spotting the parameter ordering error. We also need to fix this for D119 for the Sim10 branch "R02-02-00-patches". What is the best way to proceed?
I've attached the updated performance plots, which don't change much compared to the earlier version:
Comment Actions
Thanks @jback for fixing these quickly. Good point about the R02-02-00-patches version needing fixing. Apologies for not spotting this when reviewing D119. I still haven't made the release from that branch, so we can include the fix before I do so. I think you can just cherry-pick the relevant commits from here onto that branch.