Page MenuHomeHEPForge

Add EvtD0ToKspipi DP model.
ClosedPublic

Authored by jback on Jun 3 2024, 2:31 PM.

Details

Summary

Add EvtD0ToKspipi DP model, courtesy of Camille Normand (LHCb).

Test Plan

Diff Detail

Repository
rEVTGEN evtgen
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jback requested review of this revision.Jun 3 2024, 2:31 PM
jback created this revision.
jback changed the visibility from "All Users" to "Public (No Login Required)".Jun 3 2024, 2:38 PM
jback changed the edit policy from "All Users" to "Restricted Project (Project)".
jback added a project: Restricted Project.

In the context of the thread-safety work, Fernando has been able to make EvtDalitzReso::evaluate a const function. If we were to cherry-pick those changes here we could avoid the copy of each of the EvtDalitzReso instances in EvtD0ToKspipi::calcTotAmp. What do you think?

src/EvtGenModels/EvtD0ToKspipi.cpp
155–161

This makes it a bit more readable I think. If we do include the changes to EvtDalitzReso to make the evaluate function const, the auto can become auto& to avoid the copy.

Yes, adding the const functions would be good, then we can simplify retrieving the resonances for the total amplitude as suggested. What is the specific git commit I should use?

In D119#3244, @jback wrote:

Yes, adding the const functions would be good, then we can simplify retrieving the resonances for the total amplitude as suggested. What is the specific git commit I should use?

I separated all the Dalitz const related changes in this commit.

https://gitlab.cern.ch/evtgen/evtgen/-/merge_requests/22/diffs?commit_id=c51a5f79ee0e64f0ad65f4020f2f8e62a16c7c1c

  • Use EvtDalitzReso const correctness from gitlab commit c51a5f79.

Looks good, many thanks!

This revision is now accepted and ready to land.Jun 18 2024, 11:58 AM
This revision was automatically updated to reflect the committed changes.