Details

Reviewers

jback
abudinen
kreps

Maniphest Tasks

T200: Remove broken and obsolete EvtGen models

Commits

rEVTGEN4bd744be5869: Remove EvtVubAC model
rEVTGENf284d605d04c: Remove broken or obsolete models
rEVTGEN28ffcae2f012: Update History.md
rEVTGEN69e5191c1fbc: Tidy up test-all triggers in test script
rEVTGENc9121c28effa: Remove EvtPropSLPole model
rEVTGEN7b30d586a333: Drop unused classes from EvtGenBase
rEVTGEN064d00d9e74c: Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models
rEVTGEN037c21f5caf9: Remove EvtKstarstargamma model
rEVTGEN43a17d316d6d: Remove EvtLambdaB2LambdaV models
rEVTGEN587fa32b1e42: Remove EvtVPHOtoV and EvtVPHOtoVISR models
rEVTGENcca3c9099bf9: Remove EvtLb2Lll model
rEVTGEN98d0f2afffbd: Remove EvtMultibody model
rEVTGENfae5d017d5b5: Remove EvtBHadronic model

Summary

Closes T200

Created from CERN GitLab EvtGen!7

Remove the following models:
- EvtMultibody
- EvtLb2Lll
- EvtVPHOtoV and EvtVPHOtoVISR
- EvtLambdaB2LambdaV
- EvtKstarstargamma
- EvtbsToLLLL and EvtbsToLLLLHyperCP
- EvtVubAC
- EvtPropSLPole
Drop unused classes from EvtGenBase
Tidy up test-all triggers in test script

Test Plan

Already tested in CI

Diff Detail

Repository

rEVTGEN evtgen

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tlatham created this revision.Mar 4 2024, 5:59 PM

Harbormaster completed remote builds in B285: Diff 450.Mar 4 2024, 5:59 PM

tlatham requested review of this revision.Mar 4 2024, 5:59 PM

tlatham edited the summary of this revision. (Show Details)Mar 4 2024, 6:02 PM

tlatham changed the visibility from "All Users" to "Public (No Login Required)".

tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".

tlatham added a project: Restricted Project.

tlatham added a subscriber: Restricted Project.

Update History.md

Harbormaster completed remote builds in B286: Diff 451.Mar 5 2024, 2:31 PM

I have search for each removed model and class via grep in the MR branch and found entries only in the history and release-note files. Therefore, I think that an explicit mention of the removed models and classes in the history file might be useful. I also checked whether the deleted models are used at Belle II or LHCb and it seems they are not using them. I remember that @kreps mentioned that PROPSLPOLE is used at LHCb, but I did not find any decay file in the DecFiles project.

History.md
15 ↗	(On Diff #451)	Wouldn't it be useful to add here the list of the models and classes removed?

Add lists of removed models and EvtGenBase classes

Harbormaster completed remote builds in B289: Diff 455.Wed, Apr 10, 2:51 PM

Thanks @abudinen, I've added the lists you requested to the History file.

Any further comments from anyone?

The changes look good to me.

This revision is now accepted and ready to land.Thu, Apr 11, 11:40 AM

This is ready to be merged.

Rebase on master

Remove EvtBHadronic model
Remove EvtMultibody model
Remove EvtLb2Lll model
Remove EvtVPHOtoV and EvtVPHOtoVISR models
Remove EvtLambdaB2LambdaV models
Remove EvtKstarstargamma model
Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models
Remove EvtVubAC model
Remove EvtPropSLPole model
Drop unused classes from EvtGenBase
Tidy up test-all triggers in test script
Update History.md

Harbormaster completed remote builds in B290: Diff 456.Thu, Apr 11, 5:52 PM

Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.

Closed by commit rEVTGENfae5d017d5b5: Remove EvtBHadronic model (authored by tlatham). · Explain WhyThu, Apr 11, 6:04 PM

This revision was automatically updated to reflect the committed changes.

tlatham added a commit: rEVTGENfae5d017d5b5: Remove EvtBHadronic model.

tlatham added a commit: rEVTGEN98d0f2afffbd: Remove EvtMultibody model.

tlatham added a commit: rEVTGENcca3c9099bf9: Remove EvtLb2Lll model.

tlatham added a commit: rEVTGEN587fa32b1e42: Remove EvtVPHOtoV and EvtVPHOtoVISR models.

tlatham added a commit: rEVTGEN43a17d316d6d: Remove EvtLambdaB2LambdaV models.

tlatham added a commit: rEVTGEN064d00d9e74c: Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models.

tlatham added a commit: rEVTGEN037c21f5caf9: Remove EvtKstarstargamma model.

tlatham added a commit: rEVTGENc9121c28effa: Remove EvtPropSLPole model.

tlatham added a commit: rEVTGEN7b30d586a333: Drop unused classes from EvtGenBase.

tlatham added a commit: rEVTGEN69e5191c1fbc: Tidy up test-all triggers in test script.