Code looks good.

Thanks for updating the interface, Tom. I agree that it will be easier to release this as a patch release based on R02-02-00.

• Set default cosTheta to 1 for EvtSLBaryonAmp spin density matrix.
• Undo max prob changes to EvtSSD_DirectCP since we are going to try a more general approach.

Many of the zero nDof histograms in problem-histos.txt occur when there is only 1 bin filled (the others are empty), e.g. a constant PDG mass value with essentially zero width or a fixed momentum in a 2-body decay. So we could add a check for non-zero entries within the histogram range if nDof = 0 in addition to the chiSq/nDof number.

1. We should increase the tensor probability from 10 to 20 for EvtSSD_DirectCP (e.g. for B+ -> f_2 pi).

Result of the command grep "chiSq/nDof" *.out | grep -v "pValue = 0.000" > problem-histos.txt

I have added some example tests for this, and have also created a task where we could add more tests for other models in the future: https://phab.hepforge.org/T205

• Add tests for Bc -> J/psi pi pi0 & psi(2S) pi BC_VHAD modes.

• Update History file to mention D89.

Looks like the documents contain all of the relevant information.

The new updates using the mass ranges look OK.

1. Yes, increasing the safety factor to 10% is sensible.

This clever solution for finding ASqMax looks OK overall, so I am approving these changes.

The maximum probability is now set at 10, but we may want to revisit this model (reopening this task) in order to reduce the small but very long probability distribution tail that extends beyond 10.

This now appears to be fixed in the master branch.

Fixed in the master branch.

Fixed in the master branch.

The BTOSLLALI max prob has been increased by 25%, to try to avoid the warnings, in commit b162af83 in the GitLab branch 1-complete-test-coverage-of-all-decay-models.

Undefined max probability was set to 10.0 in commit a36bf4cd on the GitLab branch 1-complete-test-coverage-of-all-decay-models. However, this does not address the problem of larger probability values that can occur in the high tail region, as mentioned previously.

This has been fixed in commit a184c939 on the 1-complete-test-coverage-of-all-decay-models branch.

This has been corrected in commit 4c5d60c3 on the 1-complete-test-coverage-of-all-decay-models branch.

Changes look OK. It is good to see unnecessary pointers being removed. Just have a few minor suggestions.

Thanks for the clarification about the BF values chosen, Michal. I agree that all of the changes are OK. I will accept this revision after we finalise any required copyright/documentation changes to the scripts according to Tom's suggestions.

I'm not an expert on cmake but all of the changes look OK and we can add more checks/features as time goes on. Let us go ahead and add this to the repository.

Thanks for these changes, Michal. Just to double-check, the PDG webpage has the following BFs for the psi(2S) and eta_c modes: 5.8e-4 and 8.0e-4. Do we need to use different values (6.2e-4 and 9.0e-4) to balance things owing to the pythia hadronisation modes? The pythia modes also have slightly larger BFs than before.

Yes, the default lambda1 parameter quoted in the documentation should be -0.3, as given by Eq 39 (not Eq 24) on page 24 of https://arxiv.org/pdf/hep-ph/9805303.pdf . The BTOXSGAMMA model description in the guide has various other grammar problems that also need correcting. We could update the latex for the guide in the repository, or put the correct info in the paper draft (or do both).

Example pi0 Dalitz distributions before & after the change:

Instead of proceeding with D76, we have instead created a branch for the Swift-HEP tests in the CERN GitLab (mirror) repository: https://gitlab.cern.ch/evtgen/evtgen/-/tree/SwiftHEP_Tests

Example probability distribution for Dstar0 -> D0 e+ e- decay:

Changes look good, Michal. The code is now more general and has excellent agreement with the previous version. Thanks.

Code can be merged, although it would be good if the "DK P-wave" comment for calcGamma in LauKMatrixPropagator.hh is removed before this revision is landed.

Thanks @johndan for implementing my suggestion.

For reference, old LHCb JIRA task for tau decays using TAUOLA (which could not add spin info): https://its.cern.ch/jira/browse/LHCBGAUSS-841.

Code changes look OK. Thanks for porting these over from the LHCb merge request, Michal.

Ok, don't see any showstoppers. Thanks for writing this model, Michal.

From further discussion elsewhere, it looks like the code needs further edits to allow channel-dependent L values (for a given total angular momentum J).

Algorithm looks OK overall, although it would be good if we could try to avoid using double pointers in various functions.

Need to apply an upper bound = 0 for s_0^scatt if this is allowed to float. Some parameters still need "names" added, as per Tom's suggestion.

Thanks @johndan, the changes you have made so far look good and makes the code more general. I have replied to your questions, and have also suggested that we calculate the barrier radii-squared terms at initialisation. Not sure what we can do for avoiding hard-coding the D* mass at initialisation (regarding access to LauResonanceMaker info).

Example environment setup script, using cvmfs packages:

I've had a first look at the code and have provided some suggestions for changes that I think are needed.

Code can be merged.