Page MenuHomeHEPForge
Feed Advanced Search

Mon, Feb 5

jback accepted D108: Protect eps and epsParent against wrong indices.

Changes look OK.

Mon, Feb 5, 4:44 PM · Restricted Project
jback committed rEVTGENc9899239341a: Updated checkJsonFiles.py to allow different filename parameter suffixes… (authored by jback).
Updated checkJsonFiles.py to allow different filename parameter suffixes…
Mon, Feb 5, 2:38 PM
jback committed rEVTGENc23dcf0f53ee: Change names of BC_VPPHAD test files to conform to CI rules. (authored by jback).
Change names of BC_VPPHAD test files to conform to CI rules.
Mon, Feb 5, 1:26 PM

Sat, Feb 3

jback accepted D107: Implemented const correctness for epsPhoton and epsParentPhoton.

Changes look OK, although you will need to update the History file to include the latest changes made by D100.

Sat, Feb 3, 3:51 PM · Restricted Project
jback added a comment to D108: Protect eps and epsParent against wrong indices.

These changes look OK, although I think you need to "undo" the fix for EvtBcVHad since this has been done in D100 that has been recently merged (which also makes significant changes to other parts of that class). So just update this class to the version in the current master, otherwise I think you will get a merge conflict (for those other parts that have changed).

Sat, Feb 3, 3:50 PM · Restricted Project
jback closed T230: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes as Resolved by committing rEVTGENb4be06a8d38b: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
Sat, Feb 3, 3:35 PM · Restricted Project
jback closed D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
Sat, Feb 3, 3:35 PM · Restricted Project
jback committed rEVTGENb4be06a8d38b: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes. (authored by jback).
Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes.
Sat, Feb 3, 3:35 PM
jback updated the diff for D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
  • Merge branch 'master' of ssh://phab.hepforge.org/source/evtgen
Sat, Feb 3, 3:33 PM · Restricted Project

Dec 20 2023

jback added a comment to D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..

I've attached a comparison of some of the angular distributions that was used for the Ds -> phi pi, phi -> pi pi pi0 decay (comparing this MR with those from the LHCb Sim meeting talk). It needs new decay angle calculations in the test program.

Dec 20 2023, 8:23 PM · Restricted Project
jback updated the diff for D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
  • Add cosThetaResNorm & cosBetaRes angles to testDecayModel. Used in added test file for Ds -> phi pi, phi -> pi pi pi0. Make EvtVector4R::cross() function constant.
Dec 20 2023, 8:04 PM · Restricted Project

Dec 7 2023

jback accepted D103: Create and apply clang-format style.

The updated formatting looks good. This is ready to be merged for the new release.

Dec 7 2023, 2:43 PM · Laura

Nov 24 2023

jback accepted D103: Create and apply clang-format style.

Formatting and CI check look OK.

Nov 24 2023, 4:32 PM · Laura

Nov 22 2023

jback accepted D105: Allow increase of C++ standard via environment variable.

Yes, this is OK.

Nov 22 2023, 12:46 PM · Laura

Nov 16 2023

jback accepted D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.

Update looks OK.

Nov 16 2023, 5:24 PM · Laura

Nov 7 2023

jback added a comment to D103: Create and apply clang-format style.

Clang formatting and CI check looks OK, so proceed with organising the appropriate branches.

Nov 7 2023, 6:27 PM · Laura

Nov 6 2023

jback added inline comments to D101: Improve use of ROOT dictionary generation macros.
Nov 6 2023, 4:51 PM · Laura
jback accepted D101: Improve use of ROOT dictionary generation macros.

All of the changes look OK. Just have a query about some K-matrix code that is commented out. Otherwise this can be merged.

Nov 6 2023, 3:46 PM · Laura

Oct 16 2023

jback accepted D99: Add tests for PHOTOS (T229).

Changes look OK.

Oct 16 2023, 4:48 PM · Restricted Project

Oct 12 2023

jback added a comment to D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..

Code updated to address the first set of review comments.

Oct 12 2023, 3:46 PM · Restricted Project
jback updated the diff for D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
  • Edits for 1st review round for D100
Oct 12 2023, 2:21 PM · Restricted Project

Oct 10 2023

jback added a comment to T230: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes.

Here are the JSON test distributions for the EvtBcVPPHad and EvtPhiDalitz model updates, which includes some comparisons with tests done by the previous LHCb code review:

Oct 10 2023, 11:30 PM · Restricted Project
jback retitled D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes. from T230: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes. to Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
Oct 10 2023, 11:16 PM · Restricted Project
jback requested review of D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
Oct 10 2023, 11:13 PM · Restricted Project
jback triaged T230: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes as Normal priority.
Oct 10 2023, 11:02 PM · Restricted Project

Oct 9 2023

jback accepted D98: Modernise EvtIdSet and other improvements.

Changes look OK. This can be merged.

Oct 9 2023, 12:00 PM · Restricted Project

Aug 24 2023

jback accepted D97: Solved initialisation and pole issue in VTOSLL model..

Code looks good.

Aug 24 2023, 12:23 PM · Restricted Project

Aug 21 2023

jback accepted D96: Work around change of interface for setRndmEnginePtr in Pythia8 310.

Thanks for updating the interface, Tom. I agree that it will be easier to release this as a patch release based on R02-02-00.

Aug 21 2023, 2:22 PM · Restricted Project

Jul 13 2023

jback updated subscribers of T221: Unnoticed failure in conversion of parameters to double.
Jul 13 2023, 10:55 AM · Restricted Project

Feb 3 2023

jback committed rEVTGEN51978d8f23ef: Code changes for T207 (test output problems) (authored by jback).
Code changes for T207 (test output problems)
Feb 3 2023, 3:57 PM
jback closed D91: Code changes for T207 (test output problems).
Feb 3 2023, 3:57 PM · Restricted Project
jback updated the summary of D91: Code changes for T207 (test output problems).
Feb 3 2023, 3:55 PM · Restricted Project
jback updated the diff for D91: Code changes for T207 (test output problems).
  • Set default cosTheta to 1 for EvtSLBaryonAmp spin density matrix.
  • Undo max prob changes to EvtSSD_DirectCP since we are going to try a more general approach.
Feb 3 2023, 3:54 PM · Restricted Project

Jan 26 2023

jback updated the summary of D91: Code changes for T207 (test output problems).
Jan 26 2023, 3:27 PM · Restricted Project
jback requested review of D91: Code changes for T207 (test output problems).
Jan 26 2023, 3:25 PM · Restricted Project
jback added a comment to T207: EvtGen models with test output problems.

Many of the zero nDof histograms in problem-histos.txt occur when there is only 1 bin filled (the others are empty), e.g. a constant PDG mass value with essentially zero width or a fixed momentum in a 2-body decay. So we could add a check for non-zero entries within the histogram range if nDof = 0 in addition to the chiSq/nDof number.

Jan 26 2023, 2:04 PM · Restricted Project
jback added a comment to T207: EvtGen models with test output problems.
  1. We should increase the tensor probability from 10 to 20 for EvtSSD_DirectCP (e.g. for B+ -> f_2 pi).
Jan 26 2023, 1:20 PM · Restricted Project
jback added a comment to T207: EvtGen models with test output problems.

Result of the command grep "chiSq/nDof" *.out | grep -v "pValue = 0.000" > problem-histos.txt

Jan 26 2023, 12:39 PM · Restricted Project
jback renamed T207: EvtGen models with test output problems from Models with problems to EvtGen models with test output problems.
Jan 26 2023, 12:35 PM · Restricted Project

Dec 16 2022

jback committed rEVTGEN0f38854ee7a5: Fix typo for reference file in BC_VHAD=VLL__Bc_Jpsipipi0_mumu.json. (authored by jback).
Fix typo for reference file in BC_VHAD=VLL__Bc_Jpsipipi0_mumu.json.
Dec 16 2022, 7:37 PM
jback updated the task description for T13: Modernize EvtGen.
Dec 16 2022, 7:33 PM · Restricted Project
jback closed D89: Probabilities added for EvtBcVHad decay model..
Dec 16 2022, 6:52 PM · Restricted Project
jback committed rEVTGEN99407c7eedac: Probabilities added for EvtBcVHad decay model. (authored by jback).
Probabilities added for EvtBcVHad decay model.
Dec 16 2022, 6:52 PM
jback added a comment to D89: Probabilities added for EvtBcVHad decay model..

I have added some example tests for this, and have also created a task where we could add more tests for other models in the future: https://phab.hepforge.org/T205

Dec 16 2022, 6:47 PM · Restricted Project
jback triaged T205: Add extra EvtGen decay model tests as Low priority.
Dec 16 2022, 6:46 PM · Restricted Project
jback updated the diff for D89: Probabilities added for EvtBcVHad decay model..
  • Add tests for Bc -> J/psi pi pi0 & psi(2S) pi BC_VHAD modes.
Dec 16 2022, 6:10 PM · Restricted Project
jback updated the diff for D89: Probabilities added for EvtBcVHad decay model..
  • Update History file to mention D89.
Dec 16 2022, 3:54 PM · Restricted Project
jback changed the visibility for D89: Probabilities added for EvtBcVHad decay model..
Dec 16 2022, 3:47 PM · Restricted Project
jback requested review of D89: Probabilities added for EvtBcVHad decay model..
Dec 16 2022, 3:46 PM · Restricted Project

Dec 12 2022

jback accepted D86: Provide CONTRIBUTING documention.

Looks like the documents contain all of the relevant information.

Dec 12 2022, 1:16 PM · Restricted Project

Nov 21 2022

jback accepted D85: Use Minuit to automatically determine ASq max for signal in LauIsobarDynamics.

The new updates using the mass ranges look OK.

Nov 21 2022, 12:58 PM · Laura

Nov 17 2022

jback added a comment to D85: Use Minuit to automatically determine ASq max for signal in LauIsobarDynamics.
  1. Yes, increasing the safety factor to 10% is sensible.
Nov 17 2022, 7:35 PM · Laura
jback accepted D85: Use Minuit to automatically determine ASq max for signal in LauIsobarDynamics.

This clever solution for finding ASqMax looks OK overall, so I am approving these changes.

Nov 17 2022, 1:41 PM · Laura

Sep 21 2022

jback triaged T200: Remove broken and obsolete EvtGen models as Normal priority.
Sep 21 2022, 6:22 PM · Restricted Project

Sep 14 2022

jback closed T162: Maximum probability required for VTOSLL EvtGen model as Resolved.

The maximum probability is now set at 10, but we may want to revisit this model (reopening this task) in order to reduce the small but very long probability distribution tail that extends beyond 10.

Sep 14 2022, 5:50 PM · Restricted Project
jback closed T161: Probability issue for semileptonic EvtGen model as Resolved.

This now appears to be fixed in the master branch.

Sep 14 2022, 5:39 PM · Restricted Project
jback closed T197: EvtBtoKpiCPIso model initialisation problems as Resolved.

Fixed in the master branch.

Sep 14 2022, 5:10 PM · Restricted Project
jback closed T198: Fix initialisation problems in EvtPto3P and EvtBtoKD3P models as Resolved.

Fixed in the master branch.

Sep 14 2022, 5:09 PM · Restricted Project

Aug 14 2022

jback added a comment to T161: Probability issue for semileptonic EvtGen model.

The BTOSLLALI max prob has been increased by 25%, to try to avoid the warnings, in commit b162af83 in the GitLab branch 1-complete-test-coverage-of-all-decay-models.

Aug 14 2022, 7:42 PM · Restricted Project
jback added a comment to T162: Maximum probability required for VTOSLL EvtGen model.

Undefined max probability was set to 10.0 in commit a36bf4cd on the GitLab branch 1-complete-test-coverage-of-all-decay-models. However, this does not address the problem of larger probability values that can occur in the high tail region, as mentioned previously.

Aug 14 2022, 6:43 PM · Restricted Project
jback added a comment to T198: Fix initialisation problems in EvtPto3P and EvtBtoKD3P models.

This has been fixed in commit a184c939 on the 1-complete-test-coverage-of-all-decay-models branch.

Aug 14 2022, 6:18 PM · Restricted Project
jback added a comment to T197: EvtBtoKpiCPIso model initialisation problems.

This has been corrected in commit 4c5d60c3 on the 1-complete-test-coverage-of-all-decay-models branch.

Aug 14 2022, 6:15 PM · Restricted Project

Aug 5 2022

jback triaged T198: Fix initialisation problems in EvtPto3P and EvtBtoKD3P models as Normal priority.
Aug 5 2022, 9:53 PM · Restricted Project

Jul 18 2022

jback triaged T197: EvtBtoKpiCPIso model initialisation problems as Normal priority.
Jul 18 2022, 7:49 PM · Restricted Project

Jul 5 2022

jback accepted D84: Improve handling of phase-space generation for cases of decays having e+e- pair to make RareLbToLll model..
Jul 5 2022, 11:19 AM · Restricted Project

Jun 30 2022

jback added a comment to D84: Improve handling of phase-space generation for cases of decays having e+e- pair to make RareLbToLll model..

Changes look OK. It is good to see unnecessary pointers being removed. Just have a few minor suggestions.

Jun 30 2022, 12:51 PM · Restricted Project

May 11 2022

jback accepted D83: Fix double counting of channels with K0 and charmonia for B0 decays.
May 11 2022, 6:54 PM · Restricted Project
jback added a comment to D83: Fix double counting of channels with K0 and charmonia for B0 decays.

Thanks for the clarification about the BF values chosen, Michal. I agree that all of the changes are OK. I will accept this revision after we finalise any required copyright/documentation changes to the scripts according to Tom's suggestions.

May 11 2022, 4:50 PM · Restricted Project
jback accepted D80: Add CMake options for enabling clang-tidy static analysis checks during build.

I'm not an expert on cmake but all of the changes look OK and we can add more checks/features as time goes on. Let us go ahead and add this to the repository.

May 11 2022, 4:44 PM · Restricted Project

May 10 2022

jback added a comment to D83: Fix double counting of channels with K0 and charmonia for B0 decays.

Thanks for these changes, Michal. Just to double-check, the PDG webpage has the following BFs for the psi(2S) and eta_c modes: 5.8e-4 and 8.0e-4. Do we need to use different values (6.2e-4 and 9.0e-4) to balance things owing to the pythia hadronisation modes? The pythia modes also have slightly larger BFs than before.

May 10 2022, 3:45 PM · Restricted Project

May 9 2022

jback added a comment to T190: Issue in BTOXSGAMMA model documentation.

Yes, the default lambda1 parameter quoted in the documentation should be -0.3, as given by Eq 39 (not Eq 24) on page 24 of https://arxiv.org/pdf/hep-ph/9805303.pdf . The BTOXSGAMMA model description in the guide has various other grammar problems that also need correcting. We could update the latex for the guide in the repository, or put the correct info in the paper draft (or do both).

May 9 2022, 3:08 PM · Restricted Project
jback triaged T190: Issue in BTOXSGAMMA model documentation as Low priority.
May 9 2022, 2:49 PM · Restricted Project

Apr 14 2022

jback committed rEVTGENcaf006859dad: Update History file to include D81 and D82 changes. (authored by jback).
Update History file to include D81 and D82 changes.
Apr 14 2022, 3:31 PM
jback closed D82: EvtDecayProb minor fixes.
Apr 14 2022, 3:23 PM · Restricted Project
jback committed rEVTGEN94a800482a4d: EvtDecayProb minor fixes (authored by jback).
EvtDecayProb minor fixes
Apr 14 2022, 3:23 PM
jback added a comment to D82: EvtDecayProb minor fixes.

Example pi0 Dalitz distributions before & after the change:

Pi0DalitzBefore.png (476×698 px, 10 KB)
Pi0DalitzAfter.png (476×698 px, 10 KB)

Apr 14 2022, 12:54 PM · Restricted Project
jback updated the test plan for D82: EvtDecayProb minor fixes.
Apr 14 2022, 12:47 PM · Restricted Project
jback changed the visibility for D82: EvtDecayProb minor fixes.
Apr 14 2022, 12:45 PM · Restricted Project
jback requested review of D82: EvtDecayProb minor fixes.
Apr 14 2022, 12:44 PM · Restricted Project

Mar 2 2022

jback committed rEVTGEN7606bc092549: Add decay modes to the EvtBcVHad (BC_VHAD) model. (authored by jback).
Add decay modes to the EvtBcVHad (BC_VHAD) model.
Mar 2 2022, 4:58 PM

Nov 10 2021

jback added a comment to T168: Swift-HEP EvtGen thread safety developments.

Instead of proceeding with D76, we have instead created a branch for the Swift-HEP tests in the CERN GitLab (mirror) repository: https://gitlab.cern.ch/evtgen/evtgen/-/tree/SwiftHEP_Tests

Nov 10 2021, 3:59 PM · Restricted Project

Oct 29 2021

jback triaged T168: Swift-HEP EvtGen thread safety developments as Normal priority.
Oct 29 2021, 6:41 PM · Restricted Project

Sep 11 2021

jback added a comment to T162: Maximum probability required for VTOSLL EvtGen model.

Example probability distribution for Dstar0 -> D0 e+ e- decay:

VTOSLLProb.png (409×710 px, 8 KB)
VTOSLLProb2.png (327×536 px, 5 KB)

Sep 11 2021, 4:46 PM · Restricted Project
jback changed the visibility for T161: Probability issue for semileptonic EvtGen model.
Sep 11 2021, 4:19 PM · Restricted Project
jback updated subscribers of T162: Maximum probability required for VTOSLL EvtGen model.
Sep 11 2021, 4:18 PM · Restricted Project
jback triaged T162: Maximum probability required for VTOSLL EvtGen model as Normal priority.
Sep 11 2021, 4:18 PM · Restricted Project
jback updated subscribers of T161: Probability issue for semileptonic EvtGen model.
Sep 11 2021, 4:02 PM · Restricted Project
jback triaged T161: Probability issue for semileptonic EvtGen model as Normal priority.
Sep 11 2021, 4:01 PM · Restricted Project
jback updated subscribers of T160: Problems with B -> 4 mu and gamma mu mu EvtGen models.
Sep 11 2021, 3:47 PM · Restricted Project
jback triaged T160: Problems with B -> 4 mu and gamma mu mu EvtGen models as Normal priority.
Sep 11 2021, 3:46 PM · Restricted Project

Mar 17 2021

jback added a reviewer for D58: Rename member variables to follow convention of m_ prefix: jback.
Mar 17 2021, 2:00 PM · Restricted Project

Mar 16 2021

jback updated subscribers of D62: Improve PI0DALITZ model..
Mar 16 2021, 9:44 PM · Restricted Project
jback accepted D62: Improve PI0DALITZ model..

Changes look good, Michal. The code is now more general and has excellent agreement with the previous version. Thanks.

Mar 16 2021, 9:43 PM · Restricted Project

Feb 27 2021

jback updated the task description for T131: EvtGen tau decays using Pythia.
Feb 27 2021, 10:16 PM · Restricted Project

Feb 10 2021

jback accepted D41: Implementation of higher-spin K-matrix.

Code can be merged, although it would be good if the "DK P-wave" comment for calcGamma in LauKMatrixPropagator.hh is removed before this revision is landed.

Feb 10 2021, 9:18 PM · Laura

Feb 9 2021

jback added inline comments to D41: Implementation of higher-spin K-matrix.
Feb 9 2021, 5:30 PM · Laura
jback added a comment to D41: Implementation of higher-spin K-matrix.

Thanks @johndan for implementing my suggestion.

Feb 9 2021, 4:38 PM · Laura

Feb 8 2021

jback added inline comments to D41: Implementation of higher-spin K-matrix.
Feb 8 2021, 2:33 PM · Laura

Feb 3 2021

jback added a comment to T131: EvtGen tau decays using Pythia.

For reference, old LHCb JIRA task for tau decays using TAUOLA (which could not add spin info): https://its.cern.ch/jira/browse/LHCBGAUSS-841.

Feb 3 2021, 2:04 PM · Restricted Project

Jan 15 2021

jback added inline comments to D39: Allow floating of parameters in the k-matrix.
Jan 15 2021, 6:10 PM · Laura