Page MenuHomeHEPForge

Solved initialisation and pole issue in VTOSLL model.

Authored by abudinen on Aug 22 2023, 3:51 PM.



Solved initialisation and pole issue in VTOSLL model. Added two new test files for this model as well.

Implemented const where possible and needed as per John's comments.

Avoided unnecessary if loop and double initialization. Use static constexpr for pole size.

Test Plan

Distributions associated with propagator q2(ll) changed due to pole compensation.
Probmax issue should not happen when running the tests.

Diff Detail

rEVTGEN evtgen
Lint Not Applicable
Tests Not Applicable

Event Timeline

abudinen created this revision.
abudinen added a project: Restricted Project.Aug 22 2023, 3:54 PM
  • Changed names of some variables to make it consistent with model name.

Many thanks for this @abudinen. After the reviews by @jback and me on the CERN gitlab MR evtgen/evtgen!4, I think this is ready to go, unless @jback has any further comments, or @kreps would like to comment?

tlatham changed the visibility from "All Users" to "Public (No Login Required)".
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham edited subscribers, added: Restricted Project; removed: tlatham, kreps, jback.
This revision is now accepted and ready to land.Aug 24 2023, 12:23 PM

This all looks fine and as I would expect.

ok great, then this can go in, along with D94, I'll take care of landing them both tomorrow


I've just run this revision through the CI and I notice that this produces quite a lot of printout. Can we put this inside some sort of if ( m_debug ) condition so that it isn't normally printed?

  • Avoid printout at every step in the scan to find probmax. Print info only at the end of the scan.