Paths

Table of Contentst

Differential D99

Add tests for PHOTOS (T229)
ClosedPublic
Actions

Authored by abudinen on Oct 4 2023, 6:15 PM.

Tags

Subscribers

Restricted Project

Details

Reviewers

tlatham
jback
kreps

Commits

rEVTGEN12dfb11b0493: Add tests for PHOTOS (T229)

Summary

getAttribute function made const by using EvtAttIntMap::const_iterator.

Added variables for testing of FSR.

AddedExamples for FSR tests.

Added dedicated tests for FSR with Photos.

Turned off Photos for all tests except for dedicated ones that test Photos output.

Added yesPhotos end of file name to checker.

Bug fixed missing quotation marks.

This is related with T229 and

https://gitlab.cern.ch/evtgen/evtgen/-/commits/VinciaDevelopement

Test Plan

Run all json tests again.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

abudinen requested review of this revision.Oct 4 2023, 6:15 PM

abudinen created this revision.

Harbormaster completed remote builds in B263: Diff 418.Oct 4 2023, 6:15 PM

abudinen edited the summary of this revision. (Show Details)Oct 4 2023, 6:21 PM

abudinen changed the visibility from "All Users" to "Public (No Login Required)".

abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".

abudinen added a project: Restricted Project.

abudinen mentioned this in T229: Add json tests for Final-State-Radiators.

abudinen added a subscriber: Restricted Project.

Thanks for this @abudinen. Do we want to add some cases for hadronic final states?

test/jsonFiles/VLL__Jpsi_ee.json
11	For this integer variable, it would make more sense to have nbins == (xmax - xmin), i.e. 10. Same comment applies to the other newly added json files.
13–14	These histograms seem to be empty even in the `yesPhotos` cases, so I'd drop them. Same comment applies to the other newly added json files.

Updated FSR testing scripts: removed empty histograms, improved binning.

Harbormaster completed remote builds in B264: Diff 419.Oct 9 2023, 2:57 PM

In D99#2612, @tlatham wrote:

Thanks for this @abudinen. Do we want to add some cases for hadronic final states?

Hi Tom, I prefer to defer adding more tests for future differentials as we are currently focusing on interfacing with VinciaFSR and we will develop later more test based on our studies. I just implemented your comments: deleted empty histograms and modified the binning for discrete variables.

Changes look OK.

This revision is now accepted and ready to land.Oct 16 2023, 4:48 PM

Looks good now. I'll land D98 and then this one.

Closed by commit rEVTGEN12dfb11b0493: Add tests for PHOTOS (T229) (authored by abudinen, committed by tlatham). · Explain WhyOct 16 2023, 8:13 PM

This revision was automatically updated to reflect the committed changes.

tlatham added a commit: rEVTGEN12dfb11b0493: Add tests for PHOTOS (T229).

Revision Contents
Changeset List

Path

Size

EvtGenBase/

4 lines

7 lines

src/

EvtGenBase/

EvtParticle.cpp

8 lines

test/

checkJsonFiles.py

1 line

jsonFiles/

BC_BSSTAR_NPI__Bc_Bs0starpipipi.json

2 lines

BC_BS_NPI__Bc_Bs0pipipi.json

2 lines

BC_PSI_NPI=VLL__Bc_Jpsipipipi_ee.json

2 lines

BHADRONIC__Bd_D0pi0.json

1 line

BHADRONIC__Bd_D0rho0.json

1 line

BHADRONIC__Bd_D2star0pi0.json

1 line

BHADRONIC__Bd_D2star0rho0.json

1 line

BHADRONIC__Bd_Dstar0pi0.json

1 line

BHADRONIC__Bd_Dstar0rho0.json

1 line

BSQUARK__Bu_Dst0enue.json

1 line

BTODDALITZCPK=D0GAMMADALITZ__Bu_D0K_KsKK.json

1 line

BTOKD3P=PTO3P=PTO3P__Bu_KD0D0bar_K0spipi,K0spipi.json

1 line

BTOPLNUBK__Bu_pi0enu.json

1 line

BTOXSGAMMA__Bd_Xsdgamma.json

1 line

BToDiBaryonlnupQCD__Bu_Deltappbarmunu.json

1 line

BToDiBaryonlnupQCD__Bu_ppmunu.json

1 line

BaryonPCR=PHSP__Lambdab0_Lambdacmunu_Lambda0pi.json

1 line

CB3PI-MPP__Bu_pipipi.json

1 line

CB3PI-P00__Bu_pipi0pi0.json

1 line

D0MIXDALITZ__D0_KsKK.json

1 line

D_DALITZ__D+_K+pipi.json

1 line

D_DALITZ__D+_K0pipi0.json

1 line

D_DALITZ__D+_KKpi+.json

1 line

D_DALITZ__D+_Kpipi+.json

1 line

D_DALITZ__D+_pipipi+.json

1 line

D_DALITZ__D0_KKKS0.json

1 line

D_DALITZ__D0_KKanti-K0.json

1 line

D_DALITZ__D0_Kpipi0.json

1 line

D_DALITZ__D0_anti-K0pipi.json

1 line

D_DALITZ__D0_pipiKS0.json

1 line

D_DALITZ__D0_pipipi0.json

1 line

D_DALITZ__Ds+_KKpi.json

1 line

D_DALITZ__Ds+_pipipi.json

1 line

D_MULTIBODY__D0_K0sKK.json

1 line

ETA_DALITZ__eta_pipipi0.json

1 line

ETA_LLPIPI__etap_eepipi.json

1 line

ETA_LLPIPI__etap_mumupipi.json

1 line

EvtBcToNPi=VLL__Bc_Jpsipipipi_ee.json

2 lines

FOURBODYPHSP__Bu_mumuKrho0.json

1 line

GENERIC_DALITZ__D0_KsKK.json

1 line

HELAMP=HELAMP=VSS__Bu_psi2SKstar_Jpsigamma,K0pi.json

1 line

KSTARNUNU__Bd_Kstar0nunu.json

2 lines

KSTARSTARGAMMA__Bd_Kpigamma.json

2 lines

KS_PI0MUMU__Ks_pi0mumu.json

1 line

LNUGAMMA__Bu_enugamma.json

1 line

OMEGA_DALITZ__omega_pipipi0.json

1 line

PARTWAVE=VSS=VSS__Bd_DstarDstar_D0pi,D0pi.json

2 lines

PHI_DALITZ__phi_pipipi0.json

1 line

PHSPDECAYTIMECUT__Bu_JpsiK+.json

1 line

PHSPFLATLIFETIME__Bu_JpsiKpi0.json

1 line

PI0_DALITZ__pi0_eegamma.json

1 line

PSI2JPSIPIPI__X3872_Jpsipipi_nlo.json

1 line

PSI2JPSIPIPI__X3872_Jpsipipi_tree.json

1 line

PTO3P__D0_K0sKK.json

1 line

PVV_CPLH=VLL=VSS__B0s_Jpsiphi_ee,KK.json

2 lines

SSD_DirectCP=TSS__Bu_f2pi+_pi+pi-.json

1 line

SSD_DirectCP=VSS__Bu_Kst0pi+_K+pi-.json

1 line

SSD_DirectCP__Bd_K+pi-.json

1 line

SVV_CPLH=VLL=VSS__Bs0_Jpsiphi_ee,KK.json

2 lines

THREEBODYPHSP=VLL=PHSP__Bu_JpsiKpi0_mumu,gammagamma.json

1 line

VECTORISR=VSS__Upsilon4S_psi4160gamma_DD.json

1 line

VLL__Jpsi_ee.json

26 lines

VLL__Jpsi_ee_yesPhotos.json

26 lines

VLL__Jpsi_mumu.json

26 lines

VLL__Jpsi_mumu_yesPhotos.json

26 lines

VSP_PWAVE=PHSP__Dst0_D0gamma_Kpi.json

1 line

VSS=BTO2PI_CP_ISO=ISGW2__Upsilon4S_BdBdbar_pipi,Denue.json

2 lines

VSS=BTO3PI_CP=ISGW2__Upsilon4S_BdBdbar_pipipi0,Deanti-nue.json

1 line

VSS=BTO4PI_CP=ISGW2__Upsilon4S_BdBdbar_pipipipi,D+enu.json

1 line

VSS=BTOKPIPI_CP=ISGW2__Upsilon4S_BdBdbar_Kpipi0,Deanti-nue.json

1 line

VSS=BTOKPI_CP_ISO=ISGW2__Upsilon4S_BdBdbar_Kpi,Denue.json

2 lines

VSS=SSD_CP=HQET__Upsilon4S_BdBdbar_Dpi,Dstenue.json

1 line

VSS=SSS_CP=ISGW2__Upsilon4S_BdBdbar_pipi,Dstenue.json

1 line

VSS=SSS_CPT=ISGW2__Upsilon4S_BdBdbar_pipi,Dstenue.json

1 line

VSS=SSS_CP_PNG=ISGW2__Upsilon4S_BdBdbar_pipi,Dstenue.json

1 line

VSS=SVS_CP=ISGW2__Upsilon4S_BdBdbar_JpsiK0,Dstenue.json

1 line

VSS=SVS_CPLH=ISGW2__Upsilon4S_BdBdbar_JpsiK0s,Denue.json

1 line

VSS=SVS_CP_ISO=ISGW2__Upsilon4S_BdBdbar_a1pi,Dstenue.json

1 line

VSS=SVS_NONCPEIGEN=ISGW2__Upsilon4S_BdBdbar_a1pi,Dstenue.json

1 line

VSS=SVV_CP=ISGW2__Upsilon4S_BdBdbar_JpsiKst,Denue.json

1 line

VSS=SVV_NONCPEIGEN=ISGW2__Upsilon4S_BdBdbar_Dstrho,Denue.json

2 lines

VSS_BMIX__Upsilon4S_BdBdbar.json

1 line

VSS_MIX__Upsilon4S_BdBdbar.json

1 line

X38722-+_PSI_GAMMA=VLL__X3872_gammaJpsi_mumu.json

1 line

X38722-+_PSI_GAMMA=VSS=VLL__X3872_omegaJpsi_pipi,mumu.json

1 line

X38722-+_PSI_GAMMA=VSS=VLL__X3872_rho0Jpsi_pipi,mumu.json

1 line

Y3STOY1SPIPIMOXHAY__Upsilon3S_Upsilonpipi.json

1 line

YMSTOYNSPIPICLEO__Upsilon3S_Upsilonpipi.json

1 line

testDecayModel.cc

29 lines

Diff 425

EvtGenBase/EvtParticle.hh

Loading...

History.md

Loading...

src/EvtGenBase/EvtParticle.cpp

Loading...

test/checkJsonFiles.py

Loading...

test/jsonFiles/BC_BSSTAR_NPI__Bc_Bs0starpipipi.json

Loading...

test/jsonFiles/BC_BS_NPI__Bc_Bs0pipipi.json

Loading...

test/jsonFiles/BC_PSI_NPI=VLL__Bc_Jpsipipipi_ee.json

Loading...

test/jsonFiles/BHADRONIC__Bd_D0pi0.json

Loading...

test/jsonFiles/BHADRONIC__Bd_D0rho0.json

Loading...

test/jsonFiles/BHADRONIC__Bd_D2star0pi0.json

Loading...

test/jsonFiles/BHADRONIC__Bd_D2star0rho0.json

Loading...

test/jsonFiles/BHADRONIC__Bd_Dstar0pi0.json

Loading...

test/jsonFiles/BHADRONIC__Bd_Dstar0rho0.json

Loading...

test/jsonFiles/BSQUARK__Bu_Dst0enue.json

Loading...

test/jsonFiles/BTODDALITZCPK=D0GAMMADALITZ__Bu_D0K_KsKK.json

Loading...

test/jsonFiles/BTOKD3P=PTO3P=PTO3P__Bu_KD0D0bar_K0spipi,K0spipi.json

Loading...

test/jsonFiles/BTOPLNUBK__Bu_pi0enu.json

Loading...

test/jsonFiles/BTOXSGAMMA__Bd_Xsdgamma.json

Loading...

test/jsonFiles/BToDiBaryonlnupQCD__Bu_Deltappbarmunu.json

Loading...

test/jsonFiles/BToDiBaryonlnupQCD__Bu_ppmunu.json

Loading...

test/jsonFiles/BaryonPCR=PHSP__Lambdab0_Lambdacmunu_Lambda0pi.json

Loading...

test/jsonFiles/CB3PI-MPP__Bu_pipipi.json

Loading...

test/jsonFiles/CB3PI-P00__Bu_pipi0pi0.json

Loading...

test/jsonFiles/D0MIXDALITZ__D0_KsKK.json

Loading...

test/jsonFiles/D_DALITZ__D+_K+pipi.json

Loading...

test/jsonFiles/D_DALITZ__D+_K0pipi0.json

Loading...

test/jsonFiles/D_DALITZ__D+_KKpi+.json

Loading...

test/jsonFiles/D_DALITZ__D+_Kpipi+.json

Loading...

test/jsonFiles/D_DALITZ__D+_pipipi+.json

Loading...

test/jsonFiles/D_DALITZ__D0_KKKS0.json

Loading...

test/jsonFiles/D_DALITZ__D0_KKanti-K0.json

Loading...

test/jsonFiles/D_DALITZ__D0_Kpipi0.json

Loading...

test/jsonFiles/D_DALITZ__D0_anti-K0pipi.json

Loading...

test/jsonFiles/D_DALITZ__D0_pipiKS0.json

Loading...

test/jsonFiles/D_DALITZ__D0_pipipi0.json

Loading...

test/jsonFiles/D_DALITZ__Ds+_KKpi.json

Loading...

test/jsonFiles/D_DALITZ__Ds+_pipipi.json

Loading...

test/jsonFiles/D_MULTIBODY__D0_K0sKK.json

Loading...

test/jsonFiles/ETA_DALITZ__eta_pipipi0.json

Loading...

test/jsonFiles/ETA_LLPIPI__etap_eepipi.json

Loading...

test/jsonFiles/ETA_LLPIPI__etap_mumupipi.json

Loading...

test/jsonFiles/EvtBcToNPi=VLL__Bc_Jpsipipipi_ee.json

Loading...

test/jsonFiles/FOURBODYPHSP__Bu_mumuKrho0.json

Loading...

test/jsonFiles/GENERIC_DALITZ__D0_KsKK.json

Loading...

test/jsonFiles/HELAMP=HELAMP=VSS__Bu_psi2SKstar_Jpsigamma,K0pi.json

Loading...

test/jsonFiles/KSTARNUNU__Bd_Kstar0nunu.json

Loading...

test/jsonFiles/KSTARSTARGAMMA__Bd_Kpigamma.json

Loading...

test/jsonFiles/KS_PI0MUMU__Ks_pi0mumu.json

Loading...

test/jsonFiles/LNUGAMMA__Bu_enugamma.json

Loading...

test/jsonFiles/OMEGA_DALITZ__omega_pipipi0.json

Loading...

test/jsonFiles/PARTWAVE=VSS=VSS__Bd_DstarDstar_D0pi,D0pi.json

Loading...

test/jsonFiles/PHI_DALITZ__phi_pipipi0.json

Loading...

test/jsonFiles/PHSPDECAYTIMECUT__Bu_JpsiK+.json

Loading...

test/jsonFiles/PHSPFLATLIFETIME__Bu_JpsiKpi0.json

Loading...

test/jsonFiles/PI0_DALITZ__pi0_eegamma.json

Loading...

test/jsonFiles/PSI2JPSIPIPI__X3872_Jpsipipi_nlo.json

Loading...

test/jsonFiles/PSI2JPSIPIPI__X3872_Jpsipipi_tree.json

Loading...

test/jsonFiles/PTO3P__D0_K0sKK.json

Loading...

test/jsonFiles/PVV_CPLH=VLL=VSS__B0s_Jpsiphi_ee,KK.json

Loading...

test/jsonFiles/SSD_DirectCP=TSS__Bu_f2pi+_pi+pi-.json

Loading...

test/jsonFiles/SSD_DirectCP=VSS__Bu_Kst0pi+_K+pi-.json

Loading...

test/jsonFiles/SSD_DirectCP__Bd_K+pi-.json

Loading...

test/jsonFiles/SVV_CPLH=VLL=VSS__Bs0_Jpsiphi_ee,KK.json

Loading...

test/jsonFiles/THREEBODYPHSP=VLL=PHSP__Bu_JpsiKpi0_mumu,gammagamma.json

Loading...

test/jsonFiles/VECTORISR=VSS__Upsilon4S_psi4160gamma_DD.json

Loading...

test/jsonFiles/VLL__Jpsi_ee.json

Loading...

test/jsonFiles/VLL__Jpsi_ee_yesPhotos.json

Loading...

test/jsonFiles/VLL__Jpsi_mumu.json

Loading...

test/jsonFiles/VLL__Jpsi_mumu_yesPhotos.json

Loading...

test/jsonFiles/VSP_PWAVE=PHSP__Dst0_D0gamma_Kpi.json

Loading...

test/jsonFiles/VSS=BTO2PI_CP_ISO=ISGW2__Upsilon4S_BdBdbar_pipi,Denue.json

Loading...

test/jsonFiles/VSS=BTO3PI_CP=ISGW2__Upsilon4S_BdBdbar_pipipi0,Deanti-nue.json

Loading...

test/jsonFiles/VSS=BTO4PI_CP=ISGW2__Upsilon4S_BdBdbar_pipipipi,D+enu.json

Loading...

test/jsonFiles/VSS=BTOKPIPI_CP=ISGW2__Upsilon4S_BdBdbar_Kpipi0,Deanti-nue.json

Loading...

test/jsonFiles/VSS=BTOKPI_CP_ISO=ISGW2__Upsilon4S_BdBdbar_Kpi,Denue.json

Loading...

test/jsonFiles/VSS=SSD_CP=HQET__Upsilon4S_BdBdbar_Dpi,Dstenue.json

Loading...

test/jsonFiles/VSS=SSS_CP=ISGW2__Upsilon4S_BdBdbar_pipi,Dstenue.json

Loading...

test/jsonFiles/VSS=SSS_CPT=ISGW2__Upsilon4S_BdBdbar_pipi,Dstenue.json

Loading...

test/jsonFiles/VSS=SSS_CP_PNG=ISGW2__Upsilon4S_BdBdbar_pipi,Dstenue.json

Loading...

test/jsonFiles/VSS=SVS_CP=ISGW2__Upsilon4S_BdBdbar_JpsiK0,Dstenue.json

Loading...

test/jsonFiles/VSS=SVS_CPLH=ISGW2__Upsilon4S_BdBdbar_JpsiK0s,Denue.json

Loading...

test/jsonFiles/VSS=SVS_CP_ISO=ISGW2__Upsilon4S_BdBdbar_a1pi,Dstenue.json

Loading...

test/jsonFiles/VSS=SVS_NONCPEIGEN=ISGW2__Upsilon4S_BdBdbar_a1pi,Dstenue.json

Loading...

test/jsonFiles/VSS=SVV_CP=ISGW2__Upsilon4S_BdBdbar_JpsiKst,Denue.json

Loading...

test/jsonFiles/VSS=SVV_NONCPEIGEN=ISGW2__Upsilon4S_BdBdbar_Dstrho,Denue.json

Loading...

test/jsonFiles/VSS_BMIX__Upsilon4S_BdBdbar.json

Loading...

test/jsonFiles/VSS_MIX__Upsilon4S_BdBdbar.json

Loading...

test/jsonFiles/X38722-+_PSI_GAMMA=VLL__X3872_gammaJpsi_mumu.json

Loading...

test/jsonFiles/X38722-+_PSI_GAMMA=VSS=VLL__X3872_omegaJpsi_pipi,mumu.json

Loading...

test/jsonFiles/X38722-+_PSI_GAMMA=VSS=VLL__X3872_rho0Jpsi_pipi,mumu.json

Loading...

test/jsonFiles/Y3STOY1SPIPIMOXHAY__Upsilon3S_Upsilonpipi.json

Loading...

test/jsonFiles/YMSTOYNSPIPICLEO__Upsilon3S_Upsilonpipi.json

Loading...

test/testDecayModel.cc

Loading...