Differential D132

Introduce thread safety
ClosedPublic
Actions

Authored by tlatham on Oct 4 2024, 4:45 PM.

Tags

Subscribers

Restricted Project

Details

Reviewers

jback
kreps

Commits

rEVTGEN830120f401e7: Introduce thread safety
rEVTGEN727de899934c: Propagated protection of statics and const correctness in models and findMasses…
rEVTGEN1273f6a92fea: Update History.md
rEVTGEN1166f2a88b34: Update list of authors/contributors
rEVTGENf024aa3d1716: Propagate the EvtGen seed to the Fortran RNG in Tauola
rEVTGENbe350527d6cc: Improve mutexing of Tauola
rEVTGEN3a0ad38627f4: Reorganise test code for multi-threading
rEVTGEN81372ce6fab8: Make EvtExternalGenFactory instance thread_local
rEVTGEN34e10953af27: Modify EvtDecayTable::getInstance to return a reference
rEVTGENe3805979d022: Reset PDL table on each read
rEVTGEN6fdcf7b26f3c: Modified arrays in EvtBtoXsEtap and EvtBtoXsgamma to correct maximum number of…
rEVTGENda8bf508f27e: Remove unwanted ctor and dtor from EvtRadCorr
rEVTGENb6eca57c39cc: Improve handling of EvtDalitzTable
rEVTGENc26947714160: Prototype changes for multithreading

Summary

Make the necessary changes to allow the safe use in a multi-threaded environment

Protect statics: make them const or thread\_local
Improve const-correctness of many functions
Make thread\_local the RNG, particle property table, external factory, decay tables, and sym tables
Add explicit mutexing to non-thread-safe externals (Sherpa, Tauola, Photos)
Propagate the EvtGen seed to the Fortran RNG in Tauola
Some fixes to EvtBtoXsEtap and EvtBtoXsgamma
Reorganise test code for multi-threading

Test Plan

Tests give identical results to master branch.
Tests give identical results regardless of number of threads used.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tlatham requested review of this revision.Oct 4 2024, 4:45 PM

tlatham created this revision.

Harbormaster completed remote builds in B346: Diff 546.Oct 4 2024, 4:45 PM

Cleanup commented code

Harbormaster completed remote builds in B347: Diff 547.Oct 7 2024, 9:47 AM

kreps accepted this revision.Oct 7 2024, 10:01 AM

This revision is now accepted and ready to land.Oct 7 2024, 10:01 AM

Ready to be merged.

Update list of authors/contributors

Harbormaster completed remote builds in B348: Diff 548.Oct 7 2024, 2:37 PM

Closed by commit rEVTGENc26947714160: Prototype changes for multithreading (authored by Heather Ratcliffe (ridcully) <h.ratcliffe@warwick.ac.uk>, committed by tlatham). · Explain WhyOct 7 2024, 2:44 PM

This revision was automatically updated to reflect the committed changes.

tlatham added a commit: rEVTGENc26947714160: Prototype changes for multithreading.

tlatham added a commit: rEVTGENb6eca57c39cc: Improve handling of EvtDalitzTable.

tlatham added a commit: rEVTGENda8bf508f27e: Remove unwanted ctor and dtor from EvtRadCorr.

tlatham added a commit: rEVTGEN6fdcf7b26f3c: Modified arrays in EvtBtoXsEtap and EvtBtoXsgamma to correct maximum number of….

tlatham added a commit: rEVTGENe3805979d022: Reset PDL table on each read.

tlatham added a commit: rEVTGEN34e10953af27: Modify EvtDecayTable::getInstance to return a reference.

tlatham added a commit: rEVTGEN3a0ad38627f4: Reorganise test code for multi-threading.

tlatham added a commit: rEVTGEN81372ce6fab8: Make EvtExternalGenFactory instance thread_local.

tlatham added a commit: rEVTGENbe350527d6cc: Improve mutexing of Tauola.

tlatham added a commit: rEVTGENf024aa3d1716: Propagate the EvtGen seed to the Fortran RNG in Tauola.

tlatham added a commit: rEVTGEN1273f6a92fea: Update History.md.

tlatham added a commit: rEVTGEN1166f2a88b34: Update list of authors/contributors.

tlatham changed the visibility from "All Users" to "Public (No Login Required)".Oct 7 2024, 5:55 PM

tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".

tlatham added a project: Restricted Project.

tlatham added a subscriber: Restricted Project.

tlatham added a commit: rEVTGEN727de899934c: Propagated protection of statics and const correctness in models and findMasses….Oct 8 2024, 8:33 AM

tlatham added a commit: rEVTGEN830120f401e7: Introduce thread safety.

Revision Contents
Changeset List

Path

Size

EvtGenBase/

16 lines

EvtDecayBase.hh

15 lines

EvtDecayTable.hh

29 lines

3 lines

4 lines

6 lines

EvtParticleDecay.hh

8 lines

EvtParticleDecayList.hh

2 lines

2 lines

2 lines

2 lines

2 lines

EvtTwoBodyKine.hh

2 lines

EvtGenExternal/

EvtExternalGenFactory.hh

3 lines

8 lines

7 lines

EvtGenModels/

4 lines

EvtFlatSqDalitz.hh

4 lines

4 lines

4 lines

4 lines

4 lines

src/

4 lines

EvtGenBase/

16 lines

58 lines

EvtDecayBase.cpp

4 lines

EvtDecayTable.cpp

24 lines

EvtDiracSpinor.cpp

16 lines

EvtExtGeneratorCommandsTable.cpp

2 lines

EvtGammaMatrix.cpp

68 lines

EvtIncoherentMixing.cpp

16 lines

2 lines

2 lines

EvtParticle.cpp

33 lines

EvtParticleDecay.cpp

2 lines

EvtParticleDecayList.cpp

2 lines

2 lines

2 lines

EvtRaritaSchwingerParticle.cpp

10 lines

EvtSemiLeptonicBaryonAmp.cpp

40 lines

EvtSemiLeptonicScalarAmp.cpp

12 lines

EvtSemiLeptonicTensorAmp.cpp

26 lines

EvtSemiLeptonicVectorAmp.cpp

26 lines

EvtSymTable.cpp

2 lines

EvtTensor3C.cpp

2 lines

EvtTensor4C.cpp

2 lines

EvtTensorParticle.cpp

56 lines

EvtTwoBodyKine.cpp

3 lines

EvtVectorParticle.cpp

18 lines

EvtGenExternal/

EvtExternalGenFactory.cpp

14 lines

8 lines

10 lines

EvtGenModels/

4 lines

EvtFlatSqDalitz.cpp

4 lines

4 lines

4 lines

4 lines

4 lines

Diff 549

EvtGenBase/EvtAmp.hh

Loading...

EvtGenBase/EvtDecayBase.hh

Loading...

EvtGenBase/EvtDecayTable.hh

Loading...

EvtGenBase/EvtModel.hh

Loading...

EvtGenBase/EvtPartProp.hh

Loading...

EvtGenBase/EvtParticle.hh

Loading...

EvtGenBase/EvtParticleDecay.hh

Loading...

EvtGenBase/EvtParticleDecayList.hh

Loading...

EvtGenBase/EvtRadCorr.hh

Loading...

EvtGenBase/EvtRandom.hh

Loading...

EvtGenBase/EvtStatus.hh

Loading...

EvtGenBase/EvtSymTable.hh

Loading...

EvtGenBase/EvtTwoBodyKine.hh

Loading...

EvtGenExternal/EvtExternalGenFactory.hh

Loading...

EvtGenExternal/EvtPythia.hh

Loading...

EvtGenExternal/EvtTauola.hh

Loading...

EvtGenModels/EvtFlatQ2.hh

Loading...

EvtGenModels/EvtFlatSqDalitz.hh

Loading...

EvtGenModels/EvtISGW2.hh

Loading...

EvtGenModels/EvtPhsp.hh

Loading...

EvtGenModels/EvtSVS.hh

Loading...

EvtGenModels/EvtVSS.hh

Loading...

src/EvtGen.cpp

Loading...

src/EvtGenBase/EvtAmp.cpp

Loading...

src/EvtGenBase/EvtCPUtil.cpp

Loading...

src/EvtGenBase/EvtDecayBase.cpp

Loading...

src/EvtGenBase/EvtDecayTable.cpp

Loading...

src/EvtGenBase/EvtDiracSpinor.cpp

Loading...

src/EvtGenBase/EvtExtGeneratorCommandsTable.cpp

Loading...

src/EvtGenBase/EvtGammaMatrix.cpp

Loading...

src/EvtGenBase/EvtIncoherentMixing.cpp

Loading...

src/EvtGenBase/EvtModel.cpp

Loading...

src/EvtGenBase/EvtPDL.cpp

Loading...

src/EvtGenBase/EvtParticle.cpp

Loading...

src/EvtGenBase/EvtParticleDecay.cpp

Loading...

src/EvtGenBase/EvtParticleDecayList.cpp

Loading...

src/EvtGenBase/EvtRadCorr.cpp

Loading...

src/EvtGenBase/EvtRandom.cpp

Loading...

src/EvtGenBase/EvtRaritaSchwingerParticle.cpp

Loading...

src/EvtGenBase/EvtSemiLeptonicBaryonAmp.cpp

Loading...

src/EvtGenBase/EvtSemiLeptonicScalarAmp.cpp

Loading...

src/EvtGenBase/EvtSemiLeptonicTensorAmp.cpp

Loading...

src/EvtGenBase/EvtSemiLeptonicVectorAmp.cpp

Loading...

src/EvtGenBase/EvtSymTable.cpp

Loading...

src/EvtGenBase/EvtTensor3C.cpp

Loading...

src/EvtGenBase/EvtTensor4C.cpp

Loading...

src/EvtGenBase/EvtTensorParticle.cpp

Loading...

src/EvtGenBase/EvtTwoBodyKine.cpp

Loading...

src/EvtGenBase/EvtVectorParticle.cpp

Loading...

src/EvtGenExternal/EvtExternalGenFactory.cpp

Loading...

src/EvtGenExternal/EvtPythia.cpp

Loading...

src/EvtGenExternal/EvtTauola.cpp

Loading...

src/EvtGenModels/EvtFlatQ2.cpp

Loading...

src/EvtGenModels/EvtFlatSqDalitz.cpp

Loading...

src/EvtGenModels/EvtISGW2.cpp

Loading...

src/EvtGenModels/EvtPhsp.cpp

Loading...

src/EvtGenModels/EvtSVS.cpp

Loading...

src/EvtGenModels/EvtVSS.cpp

Loading...