Modernise EvtIdSet and other improvements
ClosedPublic
Actions

Authored by tlatham on Aug 31 2023, 2:42 PM.

Details

Reviewers

jback
kreps
abudinen

Commits

rEVTGEN5f84a6c2c28e: Modernise EvtIdSet and other improvements

Summary

Modernise and greatly simplify EvtIdSet implementation
Fixes in EvtPropSLPole to avoid unnecessary dynamic allocations
Other minor fixes and tidy-ups

Credit to Heather Ratcliffe and Chris Brady for providing
and/or inspiring several of these improvements

Test Plan

CI tests give identical results wrt master branch

Diff Detail

Repository

rEVTGEN evtgen

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tlatham created this revision.Aug 31 2023, 2:42 PM

Harbormaster completed remote builds in B261: Diff 414.Aug 31 2023, 2:42 PM

tlatham published this revision for review.Aug 31 2023, 2:47 PM

tlatham changed the visibility from "All Users" to "Public (No Login Required)".

tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".

tlatham added a project: Restricted Project.

tlatham added reviewers: jback, kreps, abudinen.

tlatham added a subscriber: Restricted Project.

All changes look plausible to me.

This revision is now accepted and ready to land.Oct 6 2023, 5:55 PM

Thanks @abudinen! @jback, @kreps, any comments? Or should I go ahead with this?

Changes look OK. This can be merged.

tlatham mentioned this in D99: Add tests for PHOTOS (T229).Oct 16 2023, 7:50 PM

Closed by commit rEVTGEN5f84a6c2c28e: Modernise EvtIdSet and other improvements (authored by tlatham). · Explain WhyOct 16 2023, 7:59 PM

This revision was automatically updated to reflect the committed changes.

tlatham added a commit: rEVTGEN5f84a6c2c28e: Modernise EvtIdSet and other improvements.

Revision Contents
Changeset List

Path

Size

.clang-format

2 lines

EvtGenBase/

2 lines

119 lines

2 lines

8 lines

src/

EvtGenBase/

EvtCPUtil.cpp

2 lines

EvtDecayTable.cpp

2 lines

EvtExtGeneratorCommandsTable.cpp

2 lines

EvtIdSet.cpp

464 lines

EvtModel.cpp

4 lines

EvtParticle.cpp

19 lines

EvtGenModels/

EvtBLLNuL.cpp

2 lines

EvtBToDiBaryonlnupQCD.cpp

24 lines

6 lines

2 lines

4 lines

2 lines

2 lines

6 lines

6 lines

6 lines

54 lines

EvtRareLbToLllFFBase.cpp

5 lines

EvtSLDiBaryonAmp.cpp

17 lines

EvtTauHadnu.cpp

4 lines

EvtbTosllScalarAmp.cpp

4 lines

EvtbTosllScalarAmpNew.cpp

4 lines

EvtbTosllScalarAmpNewExt.cpp

4 lines

EvtbTosllVectorAmp.cpp

4 lines

EvtbTosllVectorAmpNew.cpp

4 lines

EvtbTosllVectorAmpNewExt.cpp

4 lines

Evtbs2llGammaAmp.cpp

4 lines

Evtbs2llGammaISRFSRAmp.cpp

4 lines

EvtbsToLLLLAmp.cpp

4 lines

EvtbsToLLLLHyperCPAmp.cpp

4 lines

test/

evtgenlhc_test1.cc

38 lines

Diff 424

View Options

.clang-format

View Options

EvtGenBase/EvtAbsLineShape.hh

View Options

EvtGenBase/EvtIdSet.hh

View Options

EvtGenBase/EvtPto3PAmp.hh

View Options

History.md

View Options

src/EvtGenBase/EvtCPUtil.cpp

View Options

src/EvtGenBase/EvtDecayTable.cpp

View Options

src/EvtGenBase/EvtExtGeneratorCommandsTable.cpp

View Options

src/EvtGenBase/EvtIdSet.cpp

View Options

src/EvtGenBase/EvtModel.cpp

View Options

src/EvtGenBase/EvtParticle.cpp

View Options

src/EvtGenModels/EvtBLLNuL.cpp

View Options

src/EvtGenModels/EvtBToDiBaryonlnupQCD.cpp

View Options

src/EvtGenModels/EvtBaryonPCR.cpp

View Options

src/EvtGenModels/EvtBcToNPi.cpp

View Options

src/EvtGenModels/EvtBcVHad.cpp

View Options

src/EvtGenModels/EvtBsquark.cpp

View Options

src/EvtGenModels/EvtISGW2FF.cpp

View Options

src/EvtGenModels/EvtLb2Baryonlnu.cpp

View Options

src/EvtGenModels/EvtLb2plnuLCSR.cpp

View Options

src/EvtGenModels/EvtLb2plnuLQCD.cpp

View Options

src/EvtGenModels/EvtPropSLPole.cpp

View Options

src/EvtGenModels/EvtRareLbToLllFFBase.cpp

View Options

src/EvtGenModels/EvtSLDiBaryonAmp.cpp

View Options

src/EvtGenModels/EvtTauHadnu.cpp

View Options

src/EvtGenModels/EvtbTosllScalarAmp.cpp

View Options

src/EvtGenModels/EvtbTosllScalarAmpNew.cpp

View Options

src/EvtGenModels/EvtbTosllScalarAmpNewExt.cpp

View Options

src/EvtGenModels/EvtbTosllVectorAmp.cpp

View Options

src/EvtGenModels/EvtbTosllVectorAmpNew.cpp

View Options

src/EvtGenModels/EvtbTosllVectorAmpNewExt.cpp

View Options

src/EvtGenModels/Evtbs2llGammaAmp.cpp

View Options

src/EvtGenModels/Evtbs2llGammaISRFSRAmp.cpp

View Options

src/EvtGenModels/EvtbsToLLLLAmp.cpp

View Options

src/EvtGenModels/EvtbsToLLLLHyperCPAmp.cpp

View Options

Modernise EvtIdSet and other improvementsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 424

.clang-format

EvtGenBase/EvtAbsLineShape.hh

EvtGenBase/EvtIdSet.hh

EvtGenBase/EvtPto3PAmp.hh

History.md

src/EvtGenBase/EvtCPUtil.cpp

src/EvtGenBase/EvtDecayTable.cpp

src/EvtGenBase/EvtExtGeneratorCommandsTable.cpp

src/EvtGenBase/EvtIdSet.cpp

src/EvtGenBase/EvtModel.cpp

src/EvtGenBase/EvtParticle.cpp

src/EvtGenModels/EvtBLLNuL.cpp

src/EvtGenModels/EvtBToDiBaryonlnupQCD.cpp

src/EvtGenModels/EvtBaryonPCR.cpp

src/EvtGenModels/EvtBcToNPi.cpp

src/EvtGenModels/EvtBcVHad.cpp

src/EvtGenModels/EvtBsquark.cpp

src/EvtGenModels/EvtISGW2FF.cpp

src/EvtGenModels/EvtLb2Baryonlnu.cpp

src/EvtGenModels/EvtLb2plnuLCSR.cpp

src/EvtGenModels/EvtLb2plnuLQCD.cpp

src/EvtGenModels/EvtPropSLPole.cpp

src/EvtGenModels/EvtRareLbToLllFFBase.cpp

src/EvtGenModels/EvtSLDiBaryonAmp.cpp

src/EvtGenModels/EvtTauHadnu.cpp

src/EvtGenModels/EvtbTosllScalarAmp.cpp

src/EvtGenModels/EvtbTosllScalarAmpNew.cpp

src/EvtGenModels/EvtbTosllScalarAmpNewExt.cpp

src/EvtGenModels/EvtbTosllVectorAmp.cpp

src/EvtGenModels/EvtbTosllVectorAmpNew.cpp

src/EvtGenModels/EvtbTosllVectorAmpNewExt.cpp

src/EvtGenModels/Evtbs2llGammaAmp.cpp

src/EvtGenModels/Evtbs2llGammaISRFSRAmp.cpp

src/EvtGenModels/EvtbsToLLLLAmp.cpp

src/EvtGenModels/EvtbsToLLLLHyperCPAmp.cpp

test/evtgenlhc_test1.cc

Modernise EvtIdSet and other improvements
ClosedPublic
Actions

Revision Contents
Changeset List