Closing this revision after the changes have been landed in the commit 71807eba8af5.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Yesterday
Thanks @abudinen, looks good to me
Mon, Apr 22
- Updated History.md
Many thanks @abudinen, looks great, please go ahead.
- Removed training space in History.md
Fri, Apr 19
I added a few points to consult with Sherpa experts as we discussed.
Wed, Apr 17
Tue, Apr 16
Thanks for checking! Ok, will land this differential.
Great, thanks for checking it over @jback!
I agree that these changes look OK.
Mon, Apr 15
Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag
Fri, Apr 12
Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.
- Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.
Thu, Apr 11
Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.
Rebase on master
This is ready to be merged.
The changes look good to me.
Wed, Apr 10
Thanks @abudinen, I've added the lists you requested to the History file.
- Add lists of removed models and EvtGenBase classes
Looks good, many thanks!
Tue, Apr 9
Mon, Apr 8
Thu, Mar 28
Tue, Mar 26
Mar 19 2024
I have search for each removed model and class via grep in the MR branch and found entries only in the history and release-note files. Therefore, I think that an explicit mention of the removed models and classes in the history file might be useful. I also checked whether the deleted models are used at Belle II or LHCb and it seems they are not using them. I remember that @kreps mentioned that PROPSLPOLE is used at LHCb, but I did not find any decay file in the DecFiles project.