The config file is created in commit 000e3be, which is in the master branch.
In the v3-patches branch, the formatting check is enabled in the CI in 05702ff and the formatting is applied to the source files in 8ab96ea. This has been tagged in v3r6.
The application of the formatting in master will happen after the timedep-branch is merged.

Commit 8ab96ea5c5ed in branch v3-patches closes this revision

Many thanks indeed for this @abudinen!

Thanks, this improves exception safety and makes it less likely to introduce accidental deadlocks with future changes that make early returns etc.

Thanks @jback for fixing these quickly. Good point about the R02-02-00-patches version needing fixing. Apologies for not spotting this when reviewing D119. I still haven't made the release from that branch, so we can include the fix before I do so. I think you can just cherry-pick the relevant commits from here onto that branch.

Thanks for this @jback! I've just spotted a couple of small things.

Thanks @abudinen - just a minor wording suggestion for the History file.
Since these are my changes, I'll let John and/or Michal do the actual reviewing!

• Minor fix to JSON

• Update History.md

Looks good to me but then they are my changes ;)
So probably best to have them checked by @jback and/or @kreps before merging.

Looks good, many thanks!

In the context of the thread-safety work, Fernando has been able to make EvtDalitzReso::evaluate a const function. If we were to cherry-pick those changes here we could avoid the copy of each of the EvtDalitzReso instances in EvtD0ToKspipi::calcTotAmp. What do you think?

Fantastic, many thanks @abudinen!

Closed by D86

Closed by D109

Not sure why this wasn't automatically closed when bd48b7fe5585 was committed, so closing it manually

• Fixup changes from comments

• Update History.md

Tests are all good, so I'll go ahead and land this.

• Comments from John

Many thanks @jback - see replies inline.
Will push the small changes here in a second.
I'm re-running the tests just to make sure nothing changes - if all is ok I'll land this tomorrow.

Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.

@kreps, @jback, @averbyts please let me know if you have any comments

I have run all the tests on master and on the branch with these changes on top.

• Comments from Fernando

Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.

Rebase on master branch:

• Rename member variables to avoid leading underscores
• Enable shadowing and overloaded-virtual compiler warnings
• Doxygen fixes
• Add check of member variable names in CI

Thanks @abudinen, looks good to me

Many thanks @abudinen, looks great, please go ahead.

Great, thanks for checking it over @jback!

Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.