Page MenuHomeHEPForge
Feed Advanced Search

Today

tlatham updated the diff for D122: Fix compilation warnings under gcc13 and clang16.
  • Minor fix to JSON
Thu, Jun 20, 6:55 PM · Restricted Project
tlatham added inline comments to D122: Fix compilation warnings under gcc13 and clang16.
Thu, Jun 20, 6:21 PM · Restricted Project
tlatham updated the diff for D122: Fix compilation warnings under gcc13 and clang16.
  • Update History.md
Thu, Jun 20, 6:00 PM · Restricted Project
tlatham added reviewers for D122: Fix compilation warnings under gcc13 and clang16: jback, abudinen, kreps.
Thu, Jun 20, 6:00 PM · Restricted Project
tlatham requested review of D122: Fix compilation warnings under gcc13 and clang16.
Thu, Jun 20, 5:57 PM · Restricted Project
tlatham added inline comments to D121: Introduced function to set seed..
Thu, Jun 20, 3:34 PM · Restricted Project

Yesterday

tlatham committed rEVTGENc1ebc621d9b3: Fix compilation warnings under gcc13 and clang16 (authored by tlatham).
Fix compilation warnings under gcc13 and clang16
Wed, Jun 19, 6:33 PM
tlatham updated the summary of D120: Remove "reference" field from JSON test files.
Wed, Jun 19, 9:28 AM · Restricted Project
tlatham added a comment to D120: Remove "reference" field from JSON test files.

Looks good to me but then they are my changes ;)
So probably best to have them checked by @jback and/or @kreps before merging.

Wed, Jun 19, 9:27 AM · Restricted Project

Tue, Jun 18

tlatham accepted D119: Add EvtD0ToKspipi DP model..

Looks good, many thanks!

Tue, Jun 18, 11:58 AM · Restricted Project

Mon, Jun 17

tlatham added inline comments to D119: Add EvtD0ToKspipi DP model..
Mon, Jun 17, 1:44 PM · Restricted Project
tlatham added a comment to D119: Add EvtD0ToKspipi DP model..

In the context of the thread-safety work, Fernando has been able to make EvtDalitzReso::evaluate a const function. If we were to cherry-pick those changes here we could avoid the copy of each of the EvtDalitzReso instances in EvtD0ToKspipi::calcTotAmp. What do you think?

Mon, Jun 17, 1:36 PM · Restricted Project

Thu, Jun 13

tlatham triaged T256: Investigate use of cppyy for generating python bindings as Low priority.
Thu, Jun 13, 11:02 AM · Laura

Tue, May 21

tlatham accepted D118: Remove obsolete ISR flag..
Tue, May 21, 10:17 PM · Restricted Project
tlatham changed the visibility for D118: Remove obsolete ISR flag..
Tue, May 21, 10:16 PM · Restricted Project

May 21 2024

tlatham accepted D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.

Fantastic, many thanks @abudinen!

May 21 2024, 8:22 AM · Restricted Project

May 15 2024

tlatham closed T29: Define code formatting style and contributing policies for EvtGen as Resolved.

Closed by D86

May 15 2024, 2:58 PM · Restricted Project
tlatham closed T178: Model KSTARSTARGAMMA does not work correctly as Resolved.

Closed by D109

May 15 2024, 2:53 PM · Restricted Project

May 8 2024

tlatham closed D58: Rename member variables to follow convention of m_ prefix.

Not sure why this wasn't automatically closed when bd48b7fe5585 was committed, so closing it manually

May 8 2024, 12:36 PM · Restricted Project
tlatham committed rEVTGENbd48b7fe5585: Rename member variables to follow convention of m_ prefix (authored by tlatham).
Rename member variables to follow convention of m_ prefix
May 8 2024, 12:05 PM
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Fixup changes from comments
May 8 2024, 12:05 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Update History.md
May 8 2024, 11:59 AM · Restricted Project
tlatham updated the summary of D58: Rename member variables to follow convention of m_ prefix.
May 8 2024, 11:58 AM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Tests are all good, so I'll go ahead and land this.

May 8 2024, 11:51 AM · Restricted Project

May 7 2024

tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Comments from John
May 7 2024, 10:29 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Many thanks @jback - see replies inline.
Will push the small changes here in a second.
I'm re-running the tests just to make sure nothing changes - if all is ok I'll land this tomorrow.

May 7 2024, 10:29 PM · Restricted Project

May 1 2024

tlatham accepted D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.

Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.

May 1 2024, 4:18 PM · Restricted Project

Apr 29 2024

tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

@kreps, @jback, @averbyts please let me know if you have any comments

Apr 29 2024, 4:55 PM · Restricted Project
tlatham created T253: Review and standardise use of integer types.
Apr 29 2024, 2:42 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

I have run all the tests on master and on the branch with these changes on top.

Apr 29 2024, 2:36 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Comments from Fernando
Apr 29 2024, 2:33 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.

Apr 29 2024, 2:33 PM · Restricted Project

Apr 26 2024

tlatham updated the summary of D58: Rename member variables to follow convention of m_ prefix.
Apr 26 2024, 4:42 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.

Rebase on master branch:

  • Rename member variables to avoid leading underscores
  • Enable shadowing and overloaded-virtual compiler warnings
  • Doxygen fixes
  • Add check of member variable names in CI
Apr 26 2024, 4:40 PM · Restricted Project

Apr 24 2024

tlatham closed D117: Drop redundant EVTGEN_CPP11 preprocessor switch.
Apr 24 2024, 3:56 PM · Restricted Project
tlatham committed rEVTGEN71451a4ee2bd: Drop redundant EVTGEN_CPP11 preprocessor switch (authored by tlatham).
Drop redundant EVTGEN_CPP11 preprocessor switch
Apr 24 2024, 3:56 PM
tlatham added reviewers for D117: Drop redundant EVTGEN_CPP11 preprocessor switch: jback, kreps, abudinen.
Apr 24 2024, 2:17 PM · Restricted Project
tlatham requested review of D117: Drop redundant EVTGEN_CPP11 preprocessor switch.
Apr 24 2024, 2:15 PM · Restricted Project

Apr 23 2024

tlatham accepted D116: Replaced PHOTOS with FSR flags in examples and tests..

Thanks @abudinen, looks good to me

Apr 23 2024, 11:15 AM · Restricted Project

Apr 22 2024

tlatham accepted D114: Simplified pre-processor behaviour for PHOTOS..

Many thanks @abudinen, looks great, please go ahead.

Apr 22 2024, 4:57 PM · Restricted Project

Apr 16 2024

tlatham accepted D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..

Great, thanks for checking it over @jback!

Apr 16 2024, 2:25 PM · Restricted Project

Apr 15 2024

tlatham added a comment to D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..

Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag

Apr 15 2024, 9:51 AM · Restricted Project

Apr 12 2024

tlatham accepted D112: Merged EvtPhotosEngine into EvtPHOTOS..

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.

Apr 12 2024, 3:22 PM · Restricted Project

Apr 11 2024

tlatham committed rEVTGENf284d605d04c: Remove broken or obsolete models (authored by tlatham).
Remove broken or obsolete models
Apr 11 2024, 6:05 PM
tlatham committed rEVTGEN28ffcae2f012: Update History.md (authored by tlatham).
Update History.md
Apr 11 2024, 6:05 PM
tlatham closed T200: Remove broken and obsolete EvtGen models as Resolved by committing rEVTGENf284d605d04c: Remove broken or obsolete models.
Apr 11 2024, 6:05 PM · Restricted Project
tlatham committed rEVTGEN69e5191c1fbc: Tidy up test-all triggers in test script (authored by tlatham).
Tidy up test-all triggers in test script
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN7b30d586a333: Drop unused classes from EvtGenBase (authored by tlatham).
Drop unused classes from EvtGenBase
Apr 11 2024, 6:04 PM
tlatham committed rEVTGENc9121c28effa: Remove EvtPropSLPole model (authored by tlatham).
Remove EvtPropSLPole model
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN4bd744be5869: Remove EvtVubAC model (authored by tlatham).
Remove EvtVubAC model
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN43a17d316d6d: Remove EvtLambdaB2LambdaV models (authored by tlatham).
Remove EvtLambdaB2LambdaV models
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN037c21f5caf9: Remove EvtKstarstargamma model (authored by tlatham).
Remove EvtKstarstargamma model
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN064d00d9e74c: Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models (authored by tlatham).
Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN587fa32b1e42: Remove EvtVPHOtoV and EvtVPHOtoVISR models (authored by tlatham).
Remove EvtVPHOtoV and EvtVPHOtoVISR models
Apr 11 2024, 6:04 PM
tlatham committed rEVTGENcca3c9099bf9: Remove EvtLb2Lll model (authored by tlatham).
Remove EvtLb2Lll model
Apr 11 2024, 6:04 PM
tlatham committed rEVTGEN98d0f2afffbd: Remove EvtMultibody model (authored by tlatham).
Remove EvtMultibody model
Apr 11 2024, 6:04 PM
tlatham closed D109: Remove broken or obsolete models.
Apr 11 2024, 6:04 PM · Restricted Project
tlatham committed rEVTGENfae5d017d5b5: Remove EvtBHadronic model (authored by tlatham).
Remove EvtBHadronic model
Apr 11 2024, 6:04 PM
tlatham added a comment to D109: Remove broken or obsolete models.

Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.

Apr 11 2024, 5:59 PM · Restricted Project
tlatham updated the diff for D109: Remove broken or obsolete models.

Rebase on master

Apr 11 2024, 5:52 PM · Restricted Project

Apr 10 2024

tlatham added a comment to D109: Remove broken or obsolete models.

Thanks @abudinen, I've added the lists you requested to the History file.

Apr 10 2024, 2:53 PM · Restricted Project
tlatham updated the diff for D109: Remove broken or obsolete models.
  • Add lists of removed models and EvtGenBase classes
Apr 10 2024, 2:51 PM · Restricted Project
tlatham accepted D111: Added new variables and tests to study and test decays with FSR.

Looks good, many thanks!

Apr 10 2024, 10:44 AM · Restricted Project

Apr 9 2024

tlatham added reviewers for D110: Performance optimizations for phase space generator: kreps, jback, abudinen.
Apr 9 2024, 1:21 PM · Restricted Project
tlatham created T247: Review `TestDecayModel::getValue` function in testing framework.
Apr 9 2024, 10:10 AM · Restricted Project

Mar 5 2024

tlatham updated the diff for D109: Remove broken or obsolete models.
  • Update History.md
Mar 5 2024, 2:31 PM · Restricted Project

Mar 4 2024

tlatham updated the summary of D109: Remove broken or obsolete models.
Mar 4 2024, 6:02 PM · Restricted Project
tlatham added a revision to T200: Remove broken and obsolete EvtGen models: D109: Remove broken or obsolete models.
Mar 4 2024, 5:59 PM · Restricted Project
tlatham requested review of D109: Remove broken or obsolete models.
Mar 4 2024, 5:59 PM · Restricted Project

Feb 19 2024

tlatham closed D108: Protect eps and epsParent against wrong indices.
Feb 19 2024, 10:25 AM · Restricted Project
tlatham committed rEVTGEN29c178f29f08: Protect eps and epsParent against wrong indices (authored by abudinen).
Protect eps and epsParent against wrong indices
Feb 19 2024, 10:25 AM
tlatham accepted D108: Protect eps and epsParent against wrong indices.
Feb 19 2024, 10:25 AM · Restricted Project
tlatham updated the diff for D108: Protect eps and epsParent against wrong indices.

Updated History.md after landing of D107

Feb 19 2024, 10:23 AM · Restricted Project
tlatham committed rEVTGEN3d020dadc019: Implemented const correctness for epsPhoton and epsParentPhoton (authored by abudinen).
Implemented const correctness for epsPhoton and epsParentPhoton
Feb 19 2024, 10:18 AM
tlatham closed D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Feb 19 2024, 10:18 AM · Restricted Project
tlatham accepted D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Feb 19 2024, 10:17 AM · Restricted Project
tlatham updated the diff for D107: Implemented const correctness for epsPhoton and epsParentPhoton.

Rebase after landing of D100

Feb 19 2024, 10:15 AM · Restricted Project

Feb 5 2024

tlatham updated the task description for T200: Remove broken and obsolete EvtGen models.
Feb 5 2024, 8:58 AM · Restricted Project
tlatham updated the task description for T207: EvtGen models with test output problems.
Feb 5 2024, 8:56 AM · Restricted Project
tlatham added a comment to T207: EvtGen models with test output problems.

Issues with PROPSLPOLE turn out to be more involved. The model appears to be doing things it shouldn't. The SLPOLE model should be used in preference. As such the decision is to remove PROPSLPOLE.

Feb 5 2024, 8:55 AM · Restricted Project

Jan 11 2024

tlatham updated subscribers of T213: Refine use of ROOT dictionary generation macros.

The implementation in D101 has caused problems with being able to run the python example GenFit3pi.py because to be able to use our classes in python they need to have dictionaries generated.
As such, I'm going to revert the changes from landing D101 and make new commits that only apply the following parts of those changes:

  • Removal of the deprecated ClassImp macro in all source files
  • The improvements to the CMake modules to avoid using old-style CMake stuff like file-level include_directories, etc.
Jan 11 2024, 12:04 PM · Laura

Dec 20 2023

tlatham added a comment to D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..

Thanks John, this looks great!
Once I'm back in the office in January I'll run it through the CI and then merge it if all is well.

Dec 20 2023, 9:11 PM · Restricted Project

Dec 19 2023

tlatham changed the visibility for T232: Implement const correctness and protection against wrong indices for polarisation vectors.
Dec 19 2023, 4:17 PM · Restricted Project
tlatham added a task to D107: Implemented const correctness for epsPhoton and epsParentPhoton: T232: Implement const correctness and protection against wrong indices for polarisation vectors.
Dec 19 2023, 4:17 PM · Restricted Project
tlatham added a revision to T232: Implement const correctness and protection against wrong indices for polarisation vectors: D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Dec 19 2023, 4:17 PM · Restricted Project
tlatham changed the visibility for D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Dec 19 2023, 4:16 PM · Restricted Project

Dec 7 2023

tlatham added a comment to D103: Create and apply clang-format style.

Hi @jback, just a quick note to explain the new changes.

Dec 7 2023, 11:41 AM · Laura
tlatham updated the diff for D103: Create and apply clang-format style.
  • Updates to clang-format style for clang 16
  • Modify clang-format style to 4-space indentation
  • Fix missing newline in README
  • Scripts to fix indentation of Doxygen comment blocks
  • Further improve formatting style
  • Re-apply formatting to source files
Dec 7 2023, 11:29 AM · Laura

Nov 22 2023

tlatham committed rLAURA9172456ac117: Allow increase of C++ standard via environment variable (authored by tlatham).
Allow increase of C++ standard via environment variable
Nov 22 2023, 1:43 PM
tlatham closed D105: Allow increase of C++ standard via environment variable.
Nov 22 2023, 1:43 PM · Laura

Nov 21 2023

tlatham updated the diff for D103: Create and apply clang-format style.
  • Apply formatting in v3-patches branch
Nov 21 2023, 10:47 PM · Laura
tlatham added a comment to D105: Allow increase of C++ standard via environment variable.

@jback, does this look ok? It's the same as the code we now have in #evtgen.

Nov 21 2023, 10:46 PM · Laura

Nov 20 2023

tlatham updated the diff for D105: Allow increase of C++ standard via environment variable.
  • Add warning if requested C++ standard is too old
Nov 20 2023, 4:58 PM · Laura
tlatham committed rEVTGENea8e83948981: Add warning if requested C++ standard is too old (authored by tlatham).
Add warning if requested C++ standard is too old
Nov 20 2023, 2:23 PM

Nov 16 2023

tlatham committed rLAURA67c88df3b45a: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes (authored by tlatham).
Add functions to fit models to return DP likelihood(s) and signal DP amplitudes
Nov 16 2023, 5:46 PM
tlatham closed T227: Provide simple interface to 2D DP likelihood in fit models as Resolved by committing rLAURA67c88df3b45a: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:45 PM · Laura
tlatham closed D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:45 PM · Laura
tlatham changed the visibility for D105: Allow increase of C++ standard via environment variable.
Nov 16 2023, 5:40 PM · Laura
tlatham added a comment to D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.

Thanks John!

Nov 16 2023, 5:39 PM · Laura
tlatham changed the visibility for D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:37 PM · Laura