Page MenuHomeHEPForge
Feed Advanced Search

Wed, Jan 13

tlatham committed rLAURAeb3470f669db: Remove call to LauDecayTimePdf::calcNorm within LauTimeDepFitModel… (authored by tlatham).
Remove call to LauDecayTimePdf::calcNorm within LauTimeDepFitModel…
Wed, Jan 13, 10:56 PM
tlatham accepted D47: Model to generate 4-body phase-space decays in restricted part of the m12-m34 space..

Looks great, thanks Michal!

Wed, Jan 13, 10:05 PM · Restricted Project

Tue, Jan 12

tlatham added a comment to D47: Model to generate 4-body phase-space decays in restricted part of the m12-m34 space..

I'm afraid I don't have time right now to really fully review the physics. But hopefully your tests should have covered that. If we think it's necessary, perhaps we can ask the analysts who were requesting this to do some further validations?
I've added a follow-up on the issue of the various double* arguments - in short I'm also not a fan but let's leave them as they are for now.
I've also added one other small question on initialisation of member variables.
I don't see any other problems.

Tue, Jan 12, 5:22 PM · Restricted Project

Mon, Jan 11

tlatham committed rLAURA072a5ab2e5a7: Control floating of tau, deltaM, phiMix from command line (authored by tlatham).
Control floating of tau, deltaM, phiMix from command line
Mon, Jan 11, 10:59 PM
tlatham committed rLAURA00f4654b1c0e: Modify Test_Dpipi to use standard set of histograms (authored by tlatham).
Modify Test_Dpipi to use standard set of histograms
Mon, Jan 11, 10:40 PM

Fri, Jan 8

tlatham changed the visibility for D47: Model to generate 4-body phase-space decays in restricted part of the m12-m34 space..
Fri, Jan 8, 12:54 PM · Restricted Project

Wed, Jan 6

tlatham added inline comments to D41: Implementation of higher-spin K-matrix.
Wed, Jan 6, 4:55 PM · Laura
tlatham added a comment to D41: Implementation of higher-spin K-matrix.
In D41#1074, @johndan wrote:

General question, @tlatham : should I cherry-pick commits to bring this differential in line with the master (e.g. c38fa2a34f4a772754d1e8f610def10747d95104 - LauFormulaPar fix)?

Wed, Jan 6, 4:43 PM · Laura
tlatham committed rEVTGEN5948de8d429c: Small cmake improvements for the RHEL8 (authored by Andrii Verbytskyi <averbyts@cern.ch>).
Small cmake improvements for the RHEL8
Wed, Jan 6, 2:13 PM
tlatham closed D46: Small cmake improvements for the RHEL8.
Wed, Jan 6, 2:12 PM · Restricted Project
tlatham accepted D46: Small cmake improvements for the RHEL8.

Thanks for these improvements. They look fine to me.

Wed, Jan 6, 12:18 PM · Restricted Project
tlatham changed the visibility for D46: Small cmake improvements for the RHEL8.
Wed, Jan 6, 12:17 PM · Restricted Project

Dec 16 2020

tlatham added a commit to T122: Use boost::program_options for executables: rLAURA321ca8e0fe0f: Start to Use Boost ProgramOptions for examples.
Dec 16 2020, 2:36 PM · Laura
tlatham added a task to rLAURA321ca8e0fe0f: Start to Use Boost ProgramOptions for examples: T122: Use boost::program_options for executables.
Dec 16 2020, 2:36 PM
tlatham changed the visibility for T122: Use boost::program_options for executables.
Dec 16 2020, 2:35 PM · Laura

Dec 10 2020

tlatham closed T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1 as Resolved.
Dec 10 2020, 5:34 PM · Laura
tlatham committed rLAURA89113f7a4cf8: Fix LauFormulaPar to follow change in behaviour of TFormula (authored by tlatham).
Fix LauFormulaPar to follow change in behaviour of TFormula
Dec 10 2020, 5:32 PM
tlatham closed D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 10 2020, 5:32 PM · Laura
tlatham requested changes to D39: Allow floating of parameters in the k-matrix.

Thanks very much for this @johndan. It looks good.
I think it would just be good to take the opportunity while we're at it to allow any of the parameters to float.
We should also include the name of the propagator in the name of the parameters so that if we have more than one K-matrix in a given fit we don't get identically named parameters appearing - this will cause problems with the sim-fit for example.
See the inline comments for details.

Dec 10 2020, 5:30 PM · Laura
tlatham retitled D36: Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges from - Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges. With new version we have now also opportunity to generate rectangular part of the squared Dalitz plot with same efficiency.- Shuffle part of the code in... to Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges.
Dec 10 2020, 2:31 PM · Restricted Project
tlatham retitled D36: Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges from - Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges. With new version we have now also opportunity to generate rectangular part of the squared Dalitz plot with same efficiency. - Shuffle part of the code in... to - Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges. With new version we have now also opportunity to generate rectangular part of the squared Dalitz plot with same efficiency.- Shuffle part of the code in....
Dec 10 2020, 2:29 PM · Restricted Project
tlatham accepted D36: Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges.

Many thanks @kreps, looks good to me.

Dec 10 2020, 2:27 PM · Restricted Project

Dec 3 2020

tlatham updated the diff for D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
  • Update release notes
Dec 3 2020, 10:39 AM · Laura

Dec 2 2020

tlatham changed the visibility for D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 2 2020, 5:38 PM · Laura
tlatham created D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 2 2020, 5:36 PM · Laura
tlatham added a revision to T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1: D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 2 2020, 5:36 PM · Laura
tlatham triaged T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1 as Normal priority.
Dec 2 2020, 5:30 PM · Laura
tlatham closed T128: Issue with fit range of slope of exponential NR model as Resolved.
Dec 2 2020, 1:42 PM · Laura
tlatham committed rLAURA19d7fe43bb14: Allow slope of exponential non-resonant shape to vary positive (for low-stats… (authored by johndan).
Allow slope of exponential non-resonant shape to vary positive (for low-stats…
Dec 2 2020, 1:41 PM
tlatham closed D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
Dec 2 2020, 1:41 PM · Laura
tlatham accepted D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).

OK, good to go now, I'll take care of landing it later on.

Dec 2 2020, 12:10 PM · Laura
tlatham updated the diff for D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
  • Reference Maniphest task in release notes
Dec 2 2020, 12:09 PM · Laura
tlatham added a revision to T128: Issue with fit range of slope of exponential NR model: D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
Dec 2 2020, 12:07 PM · Laura
tlatham added a task to D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits): T128: Issue with fit range of slope of exponential NR model.
Dec 2 2020, 12:07 PM · Laura
tlatham triaged T128: Issue with fit range of slope of exponential NR model as Normal priority.
Dec 2 2020, 12:06 PM · Laura

Nov 27 2020

tlatham committed rLAURA305890006fa1: Extend testing in CI (authored by tlatham).
Extend testing in CI
Nov 27 2020, 5:22 PM
tlatham committed rLAURAb71873074e64: Fix problem with per-event decay time error (authored by tlatham).
Fix problem with per-event decay time error
Nov 27 2020, 5:22 PM

Nov 26 2020

tlatham changed the visibility for D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
Nov 26 2020, 4:16 PM · Laura
tlatham changed the visibility for D39: Allow floating of parameters in the k-matrix.
Nov 26 2020, 4:16 PM · Laura
tlatham changed the visibility for D41: Implementation of higher-spin K-matrix.
Nov 26 2020, 4:15 PM · Laura
tlatham added a child revision for D39: Allow floating of parameters in the k-matrix: D41: Implementation of higher-spin K-matrix.
Nov 26 2020, 4:14 PM · Laura
tlatham added a parent revision for D41: Implementation of higher-spin K-matrix: D39: Allow floating of parameters in the k-matrix.
Nov 26 2020, 4:14 PM · Laura

Nov 23 2020

tlatham requested changes to D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).

Hi Dan,

Nov 23 2020, 9:16 AM · Laura

Nov 20 2020

tlatham committed rLAURA58a40867981d: Update CI and scripts for changes to Test_Dpipi (authored by tlatham).
Update CI and scripts for changes to Test_Dpipi
Nov 20 2020, 1:09 PM
tlatham committed rLAURA321ca8e0fe0f: Start to Use Boost ProgramOptions for examples (authored by tlatham).
Start to Use Boost ProgramOptions for examples
Nov 20 2020, 10:48 AM

Nov 18 2020

tlatham committed rLAURA7d4c4b46716b: Small tidy-ups in Lau1DCubicSpline (authored by tlatham).
Small tidy-ups in Lau1DCubicSpline
Nov 18 2020, 2:55 PM
tlatham committed rLAURA73d5f64b3113: Scaling by per-event decay time error should now work (authored by tlatham).
Scaling by per-event decay time error should now work
Nov 18 2020, 2:20 PM
tlatham added reviewers for D39: Allow floating of parameters in the k-matrix: tlatham, jback.
Nov 18 2020, 11:34 AM · Laura

Oct 30 2020

tlatham requested changes to D36: Rewrite EvtFlatSqDalitz model to be more efficient and to avoid cut-off around the edges.
Oct 30 2020, 12:32 PM · Restricted Project
tlatham accepted D34: Add EvtEtaLLPiPi model..

Hi @jback, many thanks for the changes and apologies for the delay in responding to them.
I think this looks good to go now.
Unless @kreps has any comments I think you can go ahead and "land" it onto master.

Oct 30 2020, 11:16 AM · Restricted Project

Oct 15 2020

tlatham committed rLAURA158d8acf4401: Match signal generation to changes in fit PDF (authored by tlatham).
Match signal generation to changes in fit PDF
Oct 15 2020, 1:34 AM
tlatham committed rLAURA48810f3cb7e4: Implement reorganisation of categories (authored by tlatham).
Implement reorganisation of categories
Oct 15 2020, 1:21 AM

Oct 13 2020

tlatham committed rLAURA67580d1ce239: Fixes for LauDecayTimePdf (authored by tlatham).
Fixes for LauDecayTimePdf
Oct 13 2020, 12:53 PM

Oct 8 2020

tlatham committed rLAURA0bfca40e0d2a: Audit of FT and DT code, in particular normalisations (authored by tlatham).
Audit of FT and DT code, in particular normalisations
Oct 8 2020, 11:16 PM

Oct 6 2020

tlatham committed rLAURA4433898d4b3d: Fix bugs in timedep generation (authored by tlatham).
Fix bugs in timedep generation
Oct 6 2020, 1:48 PM
tlatham triaged T123: CONTRIBUTING documentation as High priority.
Oct 6 2020, 10:22 AM · Restricted Project
tlatham changed the edit policy for T98: Doxygenate the code.
Oct 6 2020, 10:18 AM · Restricted Project
tlatham changed the edit policy for T29: Define code formatting style and contributing policies for EvtGen.
Oct 6 2020, 10:18 AM · Restricted Project
tlatham changed the edit policy for T13: Modernize EvtGen.
Oct 6 2020, 10:18 AM · Restricted Project

Oct 2 2020

tlatham requested changes to D34: Add EvtEtaLLPiPi model..

Hi @jback, sorry it's taken me so long to review this.
You can find here some technical points.
I'll try to compare the physics against the referenced paper next week, although I guess this was checked during the LHCb review?
You mention also testing it using testDecayModel but I can't find the json file(s) for this model. Could you include them in the next revision?

Oct 2 2020, 10:22 PM · Restricted Project

Sep 21 2020

tlatham committed rLAURA3838315ece72: Provide more information on success/failure of fitting stage in timedep test… (authored by tlatham).
Provide more information on success/failure of fitting stage in timedep test…
Sep 21 2020, 9:43 AM
tlatham committed rLAURA53227a945ff1: Few changes to file naming in timedep test example (authored by tlatham).
Few changes to file naming in timedep test example
Sep 21 2020, 9:43 AM

Sep 18 2020

tlatham committed rLAURA212a3059dc85: Save CI test outputs as artifacts (authored by tlatham).
Save CI test outputs as artifacts
Sep 18 2020, 11:51 PM
tlatham committed rLAURA6138404f9bc2: Have test retrieve histogram.root and use --hist option (authored by tlatham).
Have test retrieve histogram.root and use --hist option
Sep 18 2020, 11:31 PM
tlatham committed rLAURA7e299e25a6f1: Always require RooFitCore component for RooMath (authored by tlatham).
Always require RooFitCore component for RooMath
Sep 18 2020, 11:31 PM
tlatham committed rLAURAcb006f45e898: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Sep 18 2020, 11:17 PM
tlatham committed rLAURAaa7539d7752c: Add arcanist config file (authored by tlatham).
Add arcanist config file
Sep 18 2020, 11:16 PM
tlatham committed rLAURA1864977b3f29: Replace RooCategory with std::set in LauRooFitTask (authored by tlatham).
Replace RooCategory with std::set in LauRooFitTask
Sep 18 2020, 11:12 PM
tlatham committed rLAURA004fb3551f90: Add initial gitlab CI configuration (authored by tlatham).
Add initial gitlab CI configuration
Sep 18 2020, 9:51 PM
tlatham committed rLAURA9be172800e49: Add script to run simfit for timedep test (authored by tlatham).
Add script to run simfit for timedep test
Sep 18 2020, 9:51 PM
tlatham committed rLAURA6523f9eee72b: Update language to coordinator/task in timedep examples (authored by tlatham).
Update language to coordinator/task in timedep examples
Sep 18 2020, 9:51 PM
tlatham committed rLAURA979dc5e74d74: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Sep 18 2020, 9:51 PM
tlatham committed rEVTGEN1cd8194e70bb: Add arcanist config file (authored by tlatham).
Add arcanist config file
Sep 18 2020, 9:34 PM
tlatham committed rLAURAc5e032749f6a: Fix minor typo (authored by tlatham).
Fix minor typo
Sep 18 2020, 9:06 PM

Sep 17 2020

tlatham added a commit to T112: Removal of master/slave terminology in the code: rLAURA510007b883f7: Update language to coordinator/task.
Sep 17 2020, 12:41 PM · Laura
tlatham added a task to rLAURA510007b883f7: Update language to coordinator/task: T112: Removal of master/slave terminology in the code.
Sep 17 2020, 12:41 PM
tlatham added a revision to T112: Removal of master/slave terminology in the code: Unknown Object (Differential Revision).
Sep 17 2020, 12:40 PM · Laura
tlatham committed rLAURA510007b883f7: Update language to coordinator/task (authored by Mark Peter Whitehead <mark.peter.whitehead@cern.ch>).
Update language to coordinator/task
Sep 17 2020, 12:38 PM
tlatham committed rLAURAf95edba3ba69: Update of release notes (authored by tlatham).
Update of release notes
Sep 17 2020, 10:32 AM
tlatham committed rLAURAb8bca1c2d644: Use of RooMath in LauDecayTimePdf requires linking against ROOT::RooFitCore (authored by tlatham).
Use of RooMath in LauDecayTimePdf requires linking against ROOT::RooFitCore
Sep 17 2020, 10:06 AM

Sep 16 2020

tlatham committed rLAURA1f6f70086171: Put back line accidentally deleted in last commit (authored by tlatham).
Put back line accidentally deleted in last commit
Sep 16 2020, 2:02 PM
tlatham created T118: Update evt.pdl to PDG 2020.
Sep 16 2020, 12:28 PM · Restricted Project

Sep 14 2020

tlatham committed rLAURA25a20cbfd8d2: First attempt to include acceptance in decay time integration - should work for… (authored by tlatham).
First attempt to include acceptance in decay time integration - should work for…
Sep 14 2020, 6:02 PM

Sep 9 2020

tlatham assigned T110: Typo in DECAY.DEC to kreps.
Sep 9 2020, 5:04 PM · Restricted Project
tlatham added a comment to T112: Removal of master/slave terminology in the code.

I suppose at least 'worker' should imply someone being paid for their services.

Sep 9 2020, 2:19 PM · Laura
tlatham added a comment to T112: Removal of master/slave terminology in the code.

I think the first 3 you list don't really work very well in this context (as you say). However, 'coordinator/worker' describes rather well the relationship of the objects here.
A few alternatives to replace 'master' along the same lines could be 'manager', 'director', or 'controller'.
But I'm struggling to come up with other good alternatives to 'worker', which could maybe still be taken to be a bit pejorative? Maybe 'runner'? Any other ideas?

Sep 9 2020, 1:33 PM · Laura
tlatham updated the task description for T114: Write CONTRIBUTING document.
Sep 9 2020, 11:17 AM · Laura
tlatham updated the task description for T113: Define other code formatting and naming conventions.
Sep 9 2020, 11:11 AM · Laura
tlatham updated the task description for T111: Create clang-format style config file.
Sep 9 2020, 11:07 AM · Laura
tlatham added a comment to T111: Create clang-format style config file.
Sep 9 2020, 11:07 AM · Laura
tlatham added a parent task for T117: The inclusive language policy should be described in the CONTRIBUTING document: T114: Write CONTRIBUTING document.
Sep 9 2020, 10:58 AM · Laura
tlatham added a subtask for T114: Write CONTRIBUTING document: T117: The inclusive language policy should be described in the CONTRIBUTING document.
Sep 9 2020, 10:58 AM · Laura
tlatham raised the priority of T112: Removal of master/slave terminology in the code from Normal to High.
Sep 9 2020, 10:56 AM · Laura
tlatham moved T111: Create clang-format style config file from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T113: Define other code formatting and naming conventions from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T114: Write CONTRIBUTING document from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T115: Move towards gender neutral language from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T116: Change the primary git branch name from "master" to "main" from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T117: The inclusive language policy should be described in the CONTRIBUTING document from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham lowered the priority of T112: Removal of master/slave terminology in the code from High to Normal.
Sep 9 2020, 10:53 AM · Laura