Page MenuHomeHEPForge
Feed Advanced Search

Thu, Oct 15

tlatham committed rLAURA158d8acf4401: Match signal generation to changes in fit PDF (authored by tlatham).
Match signal generation to changes in fit PDF
Thu, Oct 15, 1:34 AM
tlatham committed rLAURA48810f3cb7e4: Implement reorganisation of categories (authored by tlatham).
Implement reorganisation of categories
Thu, Oct 15, 1:21 AM

Tue, Oct 13

tlatham committed rLAURA67580d1ce239: Fixes for LauDecayTimePdf (authored by tlatham).
Fixes for LauDecayTimePdf
Tue, Oct 13, 12:53 PM

Thu, Oct 8

tlatham committed rLAURA0bfca40e0d2a: Audit of FT and DT code, in particular normalisations (authored by tlatham).
Audit of FT and DT code, in particular normalisations
Thu, Oct 8, 11:16 PM

Tue, Oct 6

tlatham committed rLAURA4433898d4b3d: Fix bugs in timedep generation (authored by tlatham).
Fix bugs in timedep generation
Tue, Oct 6, 1:48 PM
tlatham triaged T123: CONTRIBUTING documentation as High priority.
Tue, Oct 6, 10:22 AM · Restricted Project
tlatham changed the edit policy for T98: Doxygenate the code.
Tue, Oct 6, 10:18 AM · Restricted Project
tlatham changed the edit policy for T29: Define code formatting style and contributing policies for EvtGen.
Tue, Oct 6, 10:18 AM · Restricted Project
tlatham changed the edit policy for T13: Modernize EvtGen.
Tue, Oct 6, 10:18 AM · Restricted Project

Fri, Oct 2

tlatham requested changes to D34: Add EvtEtaLLPiPi model..

Hi @jback, sorry it's taken me so long to review this.
You can find here some technical points.
I'll try to compare the physics against the referenced paper next week, although I guess this was checked during the LHCb review?
You mention also testing it using testDecayModel but I can't find the json file(s) for this model. Could you include them in the next revision?

Fri, Oct 2, 10:22 PM · Restricted Project

Sep 21 2020

tlatham committed rLAURA3838315ece72: Provide more information on success/failure of fitting stage in timedep test… (authored by tlatham).
Provide more information on success/failure of fitting stage in timedep test…
Sep 21 2020, 9:43 AM
tlatham committed rLAURA53227a945ff1: Few changes to file naming in timedep test example (authored by tlatham).
Few changes to file naming in timedep test example
Sep 21 2020, 9:43 AM

Sep 18 2020

tlatham committed rLAURA212a3059dc85: Save CI test outputs as artifacts (authored by tlatham).
Save CI test outputs as artifacts
Sep 18 2020, 11:51 PM
tlatham committed rLAURA6138404f9bc2: Have test retrieve histogram.root and use --hist option (authored by tlatham).
Have test retrieve histogram.root and use --hist option
Sep 18 2020, 11:31 PM
tlatham committed rLAURA7e299e25a6f1: Always require RooFitCore component for RooMath (authored by tlatham).
Always require RooFitCore component for RooMath
Sep 18 2020, 11:31 PM
tlatham committed rLAURAcb006f45e898: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Sep 18 2020, 11:17 PM
tlatham committed rLAURAaa7539d7752c: Add arcanist config file (authored by tlatham).
Add arcanist config file
Sep 18 2020, 11:16 PM
tlatham committed rLAURA1864977b3f29: Replace RooCategory with std::set in LauRooFitTask (authored by tlatham).
Replace RooCategory with std::set in LauRooFitTask
Sep 18 2020, 11:12 PM
tlatham committed rLAURA004fb3551f90: Add initial gitlab CI configuration (authored by tlatham).
Add initial gitlab CI configuration
Sep 18 2020, 9:51 PM
tlatham committed rLAURA9be172800e49: Add script to run simfit for timedep test (authored by tlatham).
Add script to run simfit for timedep test
Sep 18 2020, 9:51 PM
tlatham committed rLAURA6523f9eee72b: Update language to coordinator/task in timedep examples (authored by tlatham).
Update language to coordinator/task in timedep examples
Sep 18 2020, 9:51 PM
tlatham committed rLAURA979dc5e74d74: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Sep 18 2020, 9:51 PM
tlatham committed rEVTGEN1cd8194e70bb: Add arcanist config file (authored by tlatham).
Add arcanist config file
Sep 18 2020, 9:34 PM
tlatham committed rLAURAc5e032749f6a: Fix minor typo (authored by tlatham).
Fix minor typo
Sep 18 2020, 9:06 PM

Sep 17 2020

tlatham added a commit to T112: Removal of master/slave terminology in the code: rLAURA510007b883f7: Update language to coordinator/task.
Sep 17 2020, 12:41 PM · Laura
tlatham added a task to rLAURA510007b883f7: Update language to coordinator/task: T112: Removal of master/slave terminology in the code.
Sep 17 2020, 12:41 PM
tlatham added a revision to T112: Removal of master/slave terminology in the code: Unknown Object (Differential Revision).
Sep 17 2020, 12:40 PM · Laura
tlatham committed rLAURA510007b883f7: Update language to coordinator/task (authored by Mark Peter Whitehead <mark.peter.whitehead@cern.ch>).
Update language to coordinator/task
Sep 17 2020, 12:38 PM
tlatham committed rLAURAf95edba3ba69: Update of release notes (authored by tlatham).
Update of release notes
Sep 17 2020, 10:32 AM
tlatham committed rLAURAb8bca1c2d644: Use of RooMath in LauDecayTimePdf requires linking against ROOT::RooFitCore (authored by tlatham).
Use of RooMath in LauDecayTimePdf requires linking against ROOT::RooFitCore
Sep 17 2020, 10:06 AM

Sep 16 2020

tlatham committed rLAURA1f6f70086171: Put back line accidentally deleted in last commit (authored by tlatham).
Put back line accidentally deleted in last commit
Sep 16 2020, 2:02 PM
tlatham created T118: Update evt.pdl to PDG 2020.
Sep 16 2020, 12:28 PM · Restricted Project

Sep 14 2020

tlatham committed rLAURA25a20cbfd8d2: First attempt to include acceptance in decay time integration - should work for… (authored by tlatham).
First attempt to include acceptance in decay time integration - should work for…
Sep 14 2020, 6:02 PM

Sep 9 2020

tlatham assigned T110: Typo in DECAY.DEC to kreps.
Sep 9 2020, 5:04 PM · Restricted Project
tlatham added a comment to T112: Removal of master/slave terminology in the code.

I suppose at least 'worker' should imply someone being paid for their services.

Sep 9 2020, 2:19 PM · Laura
tlatham added a comment to T112: Removal of master/slave terminology in the code.

I think the first 3 you list don't really work very well in this context (as you say). However, 'coordinator/worker' describes rather well the relationship of the objects here.
A few alternatives to replace 'master' along the same lines could be 'manager', 'director', or 'controller'.
But I'm struggling to come up with other good alternatives to 'worker', which could maybe still be taken to be a bit pejorative? Maybe 'runner'? Any other ideas?

Sep 9 2020, 1:33 PM · Laura
tlatham updated the task description for T114: Write CONTRIBUTING document.
Sep 9 2020, 11:17 AM · Laura
tlatham updated the task description for T113: Define other code formatting and naming conventions.
Sep 9 2020, 11:11 AM · Laura
tlatham updated the task description for T111: Create clang-format style config file.
Sep 9 2020, 11:07 AM · Laura
tlatham added a comment to T111: Create clang-format style config file.
Sep 9 2020, 11:07 AM · Laura
tlatham added a parent task for T117: The inclusive language policy should be described in the CONTRIBUTING document: T114: Write CONTRIBUTING document.
Sep 9 2020, 10:58 AM · Laura
tlatham added a subtask for T114: Write CONTRIBUTING document: T117: The inclusive language policy should be described in the CONTRIBUTING document.
Sep 9 2020, 10:58 AM · Laura
tlatham raised the priority of T112: Removal of master/slave terminology in the code from Normal to High.
Sep 9 2020, 10:56 AM · Laura
tlatham moved T111: Create clang-format style config file from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T113: Define other code formatting and naming conventions from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T114: Write CONTRIBUTING document from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T115: Move towards gender neutral language from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T116: Change the primary git branch name from "master" to "main" from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham moved T117: The inclusive language policy should be described in the CONTRIBUTING document from Bug reports to Modernisation on the Laura board.
Sep 9 2020, 10:53 AM · Laura
tlatham lowered the priority of T112: Removal of master/slave terminology in the code from High to Normal.
Sep 9 2020, 10:53 AM · Laura
tlatham renamed T49: Define and document Laura++ code formatting style, conventions, contributing procedures, etc. from Define code formatting style and draft CONTRIBUTING document to Define and document Laura++ code formatting style, conventions, contributing procedures, etc..
Sep 9 2020, 10:51 AM · Laura
tlatham triaged T114: Write CONTRIBUTING document as Normal priority.
Sep 9 2020, 10:41 AM · Laura
tlatham triaged T113: Define other code formatting and naming conventions as Normal priority.
Sep 9 2020, 10:40 AM · Laura
tlatham triaged T111: Create clang-format style config file as Normal priority.
Sep 9 2020, 10:39 AM · Laura

Sep 3 2020

tlatham accepted rLAURA79017c77f404: Take average mistag directly from the provided user histogram.

OK great, yes confirm the changes in rLAURA696d6d44a70e fix these concerns.

Sep 3 2020, 5:42 PM

Sep 2 2020

tlatham raised a concern with rLAURA79017c77f404: Take average mistag directly from the provided user histogram.
Sep 2 2020, 1:55 PM
tlatham created T110: Typo in DECAY.DEC.
Sep 2 2020, 1:37 PM · Restricted Project

Aug 21 2020

tlatham added a task to D34: Add EvtEtaLLPiPi model.: T109: New EvtGen model for eta' -> mu mu pi pi or e e pi pi decays.
Aug 21 2020, 8:08 PM · Restricted Project
tlatham added a revision to T109: New EvtGen model for eta' -> mu mu pi pi or e e pi pi decays: D34: Add EvtEtaLLPiPi model..
Aug 21 2020, 8:08 PM · Restricted Project
tlatham added a comment to T108: Add capability for testing decay models within CI pipeline.

The CI build in the gitlab mirror of EvtGen is now working.
I've also committed the necessary changes to switch to using jsoncpp from LCG.
The build and test run successfully and you can see the details of the CI pipeline here:
https://gitlab.cern.ch/evtgen/evtgen/-/pipelines/1883808
I'm running everything in LCG_98 now because that includes the new versions of Photos and Tauola that include HepMC3 (btw it also includes EvtGen 2.0.0). There are now 4 builds:

  • gcc9-opt
  • gcc9-dbg
  • gcc10-opt
  • clang10-opt

and a test that uses the gcc9-dbg build. At present the test just runs your testDecayModel on one of the example json files you provided.
One thing I've noted is that the lack of a reference file does not result in the test exiting with a failure code, so that's something we need to look at.
The next step will be to analyse the contents of the push to see what files have changed and based on that work out what tests need to be run, etc.

Aug 21 2020, 6:24 PM · Restricted Project
tlatham added a task to rEVTGENa70475a8415f: T108: Add testDecayModel which automatically generates distributions for decays…: T108: Add capability for testing decay models within CI pipeline.
Aug 21 2020, 6:19 PM
tlatham added a commit to T108: Add capability for testing decay models within CI pipeline: rEVTGENa70475a8415f: T108: Add testDecayModel which automatically generates distributions for decays….
Aug 21 2020, 6:19 PM · Restricted Project
tlatham added commits to T108: Add capability for testing decay models within CI pipeline: rEVTGENdd90a034cbf6: Use external build of jsoncpp, rEVTGENc5a613effade: Fix CI script build command, rEVTGEN5a322ad69fff: Bugfix for gitlab CI script, rEVTGEN1815b83712e4: Some improvement to gitlab CI script, rEVTGEN7d4bc7efbce1: Add draft gitlab CI script.
Aug 21 2020, 6:18 PM · Restricted Project
tlatham added a task to rEVTGEN1815b83712e4: Some improvement to gitlab CI script: T108: Add capability for testing decay models within CI pipeline.
Aug 21 2020, 6:18 PM
tlatham added a task to rEVTGEN5a322ad69fff: Bugfix for gitlab CI script: T108: Add capability for testing decay models within CI pipeline.
Aug 21 2020, 6:18 PM
tlatham added a task to rEVTGENc5a613effade: Fix CI script build command: T108: Add capability for testing decay models within CI pipeline.
Aug 21 2020, 6:18 PM
tlatham added a task to rEVTGEN7d4bc7efbce1: Add draft gitlab CI script: T108: Add capability for testing decay models within CI pipeline.
Aug 21 2020, 6:18 PM
tlatham added a task to rEVTGENdd90a034cbf6: Use external build of jsoncpp: T108: Add capability for testing decay models within CI pipeline.
Aug 21 2020, 6:18 PM
tlatham moved T109: New EvtGen model for eta' -> mu mu pi pi or e e pi pi decays from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 21 2020, 6:17 PM · Restricted Project
tlatham committed rEVTGENdd90a034cbf6: Use external build of jsoncpp (authored by tlatham).
Use external build of jsoncpp
Aug 21 2020, 5:52 PM
tlatham committed rEVTGENc5a613effade: Fix CI script build command (authored by tlatham).
Fix CI script build command
Aug 21 2020, 5:52 PM
tlatham committed rEVTGEN5a322ad69fff: Bugfix for gitlab CI script (authored by tlatham).
Bugfix for gitlab CI script
Aug 21 2020, 4:15 PM
tlatham committed rEVTGEN1815b83712e4: Some improvement to gitlab CI script (authored by tlatham).
Some improvement to gitlab CI script
Aug 21 2020, 4:01 PM
tlatham committed rEVTGEN7d4bc7efbce1: Add draft gitlab CI script (authored by tlatham).
Add draft gitlab CI script
Aug 21 2020, 12:48 AM

Aug 19 2020

tlatham committed rLAURAc5c3deef08af: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Aug 19 2020, 9:02 PM
tlatham closed T93: Use of "effective mass" unnecessary for resonance above upper kinematic limit as Resolved.
Aug 19 2020, 4:17 PM · Laura
tlatham committed rLAURAe33368971695: Remove explicit normalisation of numerator Blatt-Weisskopf factors (authored by tlatham).
Remove explicit normalisation of numerator Blatt-Weisskopf factors
Aug 19 2020, 4:16 PM
tlatham added a comment to T108: Add capability for testing decay models within CI pipeline.
In T108#1684, @jback wrote:

The idea is to run a test doing:

./testDecayModel jsonFiles/example.json

where the json file defines the decay model, particles, parameters and histograms, as well as a reference file for comparison. We could then test the chi-squared values and print out a warning message if there is a large difference.
This then allows us to use this single test program to compare many decay models, which could then replace evtgenlhc_test1 and do_tests, without writing additional C++ code (unless we want to add other histogram distribution types).

Aug 19 2020, 11:24 AM · Restricted Project

Jul 27 2020

tlatham changed the visibility for T98: Doxygenate the code.
Jul 27 2020, 10:09 AM · Restricted Project
tlatham renamed T29: Define code formatting style and contributing policies for EvtGen from Define code formatting style for EvtGen to Define code formatting style and contributing policies for EvtGen.
Jul 27 2020, 10:08 AM · Restricted Project
tlatham changed the visibility for T13: Modernize EvtGen.
Jul 27 2020, 10:08 AM · Restricted Project
tlatham changed the visibility for T105: Prefer inclusive language.
Jul 27 2020, 10:08 AM · Restricted Project
tlatham changed the visibility for T97: Prepare a script that would convert decay databases between different major generators .
Jul 27 2020, 10:08 AM · Restricted Project
tlatham changed the visibility for T95: Create separate repository of more complex examples.
Jul 27 2020, 10:07 AM · Laura
tlatham changed the visibility for T93: Use of "effective mass" unnecessary for resonance above upper kinematic limit.
Jul 27 2020, 10:07 AM · Laura
tlatham changed the visibility for T106: Prefer inclusive language.
Jul 27 2020, 10:06 AM · Laura
tlatham renamed T49: Define and document Laura++ code formatting style, conventions, contributing procedures, etc. from Create clang-format style config file to Define code formatting style and draft CONTRIBUTING document.
Jul 27 2020, 10:06 AM · Laura
tlatham created T106: Prefer inclusive language.
Jul 27 2020, 10:05 AM · Laura
tlatham created T105: Prefer inclusive language.
Jul 27 2020, 9:12 AM · Restricted Project

Jul 20 2020

tlatham added a member for Laura: axu.
Jul 20 2020, 4:27 PM
tlatham added a member for Laura: andylhcb.
Jul 20 2020, 4:26 PM

May 22 2020

tlatham committed rLAURAa173e71317ca: Fix uninitialised LauIsobarDynamics::calculateRhoOmegaFitFractions_ (authored by tlatham).
Fix uninitialised LauIsobarDynamics::calculateRhoOmegaFitFractions_
May 22 2020, 4:08 PM
tlatham committed rLAURAbf38e5fc6439: Fix uninitialised LauIsobarDynamics::calculateRhoOmegaFitFractions_ (authored by tlatham).
Fix uninitialised LauIsobarDynamics::calculateRhoOmegaFitFractions_
May 22 2020, 4:06 PM

Apr 28 2020

tlatham updated the task description for T98: Doxygenate the code.
Apr 28 2020, 4:14 PM · Restricted Project
tlatham triaged T98: Doxygenate the code as Normal priority.
Apr 28 2020, 4:14 PM · Restricted Project

Apr 27 2020

tlatham added a comment to T29: Define code formatting style and contributing policies for EvtGen.

The clang-format part of this is essentially done.
The naming conventions etc. are still to be unified and written down.
Similarly, the rest of the CONTRIBUTING document needs to be written.

Apr 27 2020, 6:23 PM · Restricted Project
tlatham added commits to T29: Define code formatting style and contributing policies for EvtGen: rEVTGENef6083cdd498: Small fix to clang-format to account for HepMC3 in ordering of includes, rEVTGEN1000e03ed667: Apply clang-format and fix compilation errors resulting from reordering of….
Apr 27 2020, 6:20 PM · Restricted Project
tlatham added a task to rEVTGEN1000e03ed667: Apply clang-format and fix compilation errors resulting from reordering of…: T29: Define code formatting style and contributing policies for EvtGen.
Apr 27 2020, 6:20 PM
tlatham added a task to rEVTGENef6083cdd498: Small fix to clang-format to account for HepMC3 in ordering of includes: T29: Define code formatting style and contributing policies for EvtGen.
Apr 27 2020, 6:20 PM

Apr 24 2020

tlatham committed rEVTGEN23c973a27630: Set version in setupEvtGen.sh to R02-00-00 (authored by tlatham).
Set version in setupEvtGen.sh to R02-00-00
Apr 24 2020, 5:29 PM