Page MenuHomeHEPForge

tlatham (Thomas Latham)
User

Projects

User Details

User Since
Jul 3 2018, 2:12 PM (294 w, 4 d)

Recent Activity

Mon, Feb 19

tlatham closed D108: Protect eps and epsParent against wrong indices.
Mon, Feb 19, 10:25 AM · Restricted Project
tlatham committed rEVTGEN29c178f29f08: Protect eps and epsParent against wrong indices (authored by abudinen).
Protect eps and epsParent against wrong indices
Mon, Feb 19, 10:25 AM
tlatham accepted D108: Protect eps and epsParent against wrong indices.
Mon, Feb 19, 10:25 AM · Restricted Project
tlatham updated the diff for D108: Protect eps and epsParent against wrong indices.

Updated History.md after landing of D107

Mon, Feb 19, 10:23 AM · Restricted Project
tlatham committed rEVTGEN3d020dadc019: Implemented const correctness for epsPhoton and epsParentPhoton (authored by abudinen).
Implemented const correctness for epsPhoton and epsParentPhoton
Mon, Feb 19, 10:18 AM
tlatham closed D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Mon, Feb 19, 10:18 AM · Restricted Project
tlatham accepted D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Mon, Feb 19, 10:17 AM · Restricted Project
tlatham updated the diff for D107: Implemented const correctness for epsPhoton and epsParentPhoton.

Rebase after landing of D100

Mon, Feb 19, 10:15 AM · Restricted Project

Mon, Feb 5

tlatham updated the task description for T200: Remove broken and obsolete EvtGen models.
Mon, Feb 5, 8:58 AM · Restricted Project
tlatham updated the task description for T207: EvtGen models with test output problems.
Mon, Feb 5, 8:56 AM · Restricted Project
tlatham added a comment to T207: EvtGen models with test output problems.

Issues with PROPSLPOLE turn out to be more involved. The model appears to be doing things it shouldn't. The SLPOLE model should be used in preference. As such the decision is to remove PROPSLPOLE.

Mon, Feb 5, 8:55 AM · Restricted Project

Jan 11 2024

tlatham updated subscribers of T213: Refine use of ROOT dictionary generation macros.

The implementation in D101 has caused problems with being able to run the python example GenFit3pi.py because to be able to use our classes in python they need to have dictionaries generated.
As such, I'm going to revert the changes from landing D101 and make new commits that only apply the following parts of those changes:

  • Removal of the deprecated ClassImp macro in all source files
  • The improvements to the CMake modules to avoid using old-style CMake stuff like file-level include_directories, etc.
Jan 11 2024, 12:04 PM · Laura

Dec 20 2023

tlatham added a comment to D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..

Thanks John, this looks great!
Once I'm back in the office in January I'll run it through the CI and then merge it if all is well.

Dec 20 2023, 9:11 PM · Restricted Project

Dec 19 2023

tlatham changed the visibility for T232: Implement const correctness and protection against wrong indices for polarisation vectors.
Dec 19 2023, 4:17 PM · Restricted Project
tlatham added a task to D107: Implemented const correctness for epsPhoton and epsParentPhoton: T232: Implement const correctness and protection against wrong indices for polarisation vectors.
Dec 19 2023, 4:17 PM · Restricted Project
tlatham added a revision to T232: Implement const correctness and protection against wrong indices for polarisation vectors: D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Dec 19 2023, 4:17 PM · Restricted Project
tlatham changed the visibility for D107: Implemented const correctness for epsPhoton and epsParentPhoton.
Dec 19 2023, 4:16 PM · Restricted Project

Dec 7 2023

tlatham added a comment to D103: Create and apply clang-format style.

Hi @jback, just a quick note to explain the new changes.

Dec 7 2023, 11:41 AM · Laura
tlatham updated the diff for D103: Create and apply clang-format style.
  • Updates to clang-format style for clang 16
  • Modify clang-format style to 4-space indentation
  • Fix missing newline in README
  • Scripts to fix indentation of Doxygen comment blocks
  • Further improve formatting style
  • Re-apply formatting to source files
Dec 7 2023, 11:29 AM · Laura

Nov 22 2023

tlatham committed rLAURA9172456ac117: Allow increase of C++ standard via environment variable (authored by tlatham).
Allow increase of C++ standard via environment variable
Nov 22 2023, 1:43 PM
tlatham closed D105: Allow increase of C++ standard via environment variable.
Nov 22 2023, 1:43 PM · Laura

Nov 21 2023

tlatham updated the diff for D103: Create and apply clang-format style.
  • Apply formatting in v3-patches branch
Nov 21 2023, 10:47 PM · Laura
tlatham added a comment to D105: Allow increase of C++ standard via environment variable.

@jback, does this look ok? It's the same as the code we now have in #evtgen.

Nov 21 2023, 10:46 PM · Laura

Nov 20 2023

tlatham updated the diff for D105: Allow increase of C++ standard via environment variable.
  • Add warning if requested C++ standard is too old
Nov 20 2023, 4:58 PM · Laura
tlatham committed rEVTGENea8e83948981: Add warning if requested C++ standard is too old (authored by tlatham).
Add warning if requested C++ standard is too old
Nov 20 2023, 2:23 PM

Nov 16 2023

tlatham committed rLAURA67c88df3b45a: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes (authored by tlatham).
Add functions to fit models to return DP likelihood(s) and signal DP amplitudes
Nov 16 2023, 5:46 PM
tlatham closed T227: Provide simple interface to 2D DP likelihood in fit models as Resolved by committing rLAURA67c88df3b45a: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:45 PM · Laura
tlatham closed D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:45 PM · Laura
tlatham changed the visibility for D105: Allow increase of C++ standard via environment variable.
Nov 16 2023, 5:40 PM · Laura
tlatham added a comment to D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.

Thanks John!

Nov 16 2023, 5:39 PM · Laura
tlatham changed the visibility for D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:37 PM · Laura

Nov 15 2023

tlatham closed D106: Only allow increase of C++ standard via environment variable.
Nov 15 2023, 9:02 PM · Restricted Project
tlatham committed rEVTGENb2be5ef019be: Only allow increase of C++ standard via environment variable (authored by tlatham).
Only allow increase of C++ standard via environment variable
Nov 15 2023, 9:02 PM
tlatham committed rEVTGEN2f3d0dfeecf5: Fixed probmax issues and bugs in EvtXPsiGamma model. (authored by abudinen).
Fixed probmax issues and bugs in EvtXPsiGamma model.
Nov 15 2023, 8:59 PM
tlatham added a comment to D106: Only allow increase of C++ standard via environment variable.

Thanks. @abudinen, I've tried to improve the clarity of the description following our discussion.

Nov 15 2023, 4:47 PM · Restricted Project
tlatham updated the summary of D106: Only allow increase of C++ standard via environment variable.
Nov 15 2023, 4:45 PM · Restricted Project
tlatham retitled D106: Only allow increase of C++ standard via environment variable from Allow increase of C++ standard via environment variable to Only allow increase of C++ standard via environment variable.
Nov 15 2023, 1:03 PM · Restricted Project
tlatham updated the summary of D106: Only allow increase of C++ standard via environment variable.
Nov 15 2023, 1:02 PM · Restricted Project
tlatham requested review of D106: Only allow increase of C++ standard via environment variable.
Nov 15 2023, 1:00 PM · Restricted Project
tlatham requested review of D105: Allow increase of C++ standard via environment variable.
Nov 15 2023, 12:55 PM · Laura
tlatham requested review of D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 15 2023, 12:46 PM · Laura
tlatham added a revision to T227: Provide simple interface to 2D DP likelihood in fit models: D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 15 2023, 12:46 PM · Laura

Nov 7 2023

tlatham added a comment to D103: Create and apply clang-format style.

It looks like it is going to be a nightmare to merge timedep-branch into master if we apply this formatting first (even after applying the same formatting there first).
So what I'd propose is to merge the last actual code changes into master - will create the differential for that shortly - then create a new v3-patches branch, to which this formatting can then be applied, and release v3r6 from that branch. This Differential can be updated to accomplish that part.
The formatting can then be applied to master after merging in timedep-branch - will require a separate Differential at a later date.
Does that sound reasonable?

Nov 7 2023, 3:33 PM · Laura

Nov 6 2023

tlatham added a comment to T213: Refine use of ROOT dictionary generation macros.

Thanks to D101, this is now in master but needs to also be propagated to the time-dependent branch, so not yet closing this.

Nov 6 2023, 6:13 PM · Laura
tlatham closed D101: Improve use of ROOT dictionary generation macros.

Closed by rLAURA9dffea19ce7b
(not sure why this didn't happen automatically)

Nov 6 2023, 6:12 PM · Laura
tlatham committed rLAURA078824a8de62: Update MC production asymmetries (authored by tlatham).
Update MC production asymmetries
Nov 6 2023, 6:05 PM
tlatham committed rLAURA1515e6bb051c: Fix bug in normalisation (authored by tlatham).
Fix bug in normalisation
Nov 6 2023, 6:05 PM
tlatham committed rLAURAc58934cb42fc: Update runTimeDepTest.sh (authored by tlatham).
Update runTimeDepTest.sh
Nov 6 2023, 6:05 PM
tlatham committed rLAURA50fdaddb04a4: Provide cmd-line option to fix/float production asymmetry (authored by tlatham).
Provide cmd-line option to fix/float production asymmetry
Nov 6 2023, 6:05 PM
tlatham committed rLAURAc5d1fa2decff: Fix to allow simfits to QFS only (authored by tlatham).
Fix to allow simfits to QFS only
Nov 6 2023, 6:05 PM
tlatham committed rLAURAf64c44aeb438: Allow separate signal production asymmetries for different categories, e.g. run… (authored by tlatham).
Allow separate signal production asymmetries for different categories, e.g. run…
Nov 6 2023, 6:05 PM
tlatham committed rLAURAfb8282d38cf1: Add multi-dimensional constraints on yields in Bd2Dpipi TD fit (authored by tlatham).
Add multi-dimensional constraints on yields in Bd2Dpipi TD fit
Nov 6 2023, 6:05 PM
tlatham committed rLAURA55727ca92ad5: Fix warnings in LauKMatrixPropagator (authored by tlatham).
Fix warnings in LauKMatrixPropagator
Nov 6 2023, 6:05 PM
tlatham committed rLAURAfce4571be4f1: Fix bug in setting KS/KL mass in LauDatabasePDG (authored by tlatham).
Fix bug in setting KS/KL mass in LauDatabasePDG
Nov 6 2023, 6:05 PM
tlatham committed rLAURA4fbef44680a5: Fix warning in LauDecayTimeResolution::serialiseToJson (authored by tlatham).
Fix warning in LauDecayTimeResolution::serialiseToJson
Nov 6 2023, 6:05 PM
tlatham committed rLAURA79cd68dd725b: Modify Dpipi time-dep example to load tagging parameters from JSON (authored by tlatham).
Modify Dpipi time-dep example to load tagging parameters from JSON
Nov 6 2023, 6:05 PM
tlatham committed rLAURA03e3ca9ca882: Modify Dpipi time-dep example to write JSON of fitted parameters after fit (authored by tlatham).
Modify Dpipi time-dep example to write JSON of fitted parameters after fit
Nov 6 2023, 6:05 PM
tlatham committed rLAURA7a6b735684bb: Utility function to simplify writing DTA spline to JSON (authored by tlatham).
Utility function to simplify writing DTA spline to JSON
Nov 6 2023, 6:05 PM
tlatham committed rLAURA6699dd34e704: Update Bd2Dpipi example to float yields with constraints (authored by tlatham).
Update Bd2Dpipi example to float yields with constraints
Nov 6 2023, 6:05 PM
tlatham committed rLAURA1d9bb26e6a90: Allow tagging calib info to be read from and written to JSON (authored by tlatham).
Allow tagging calib info to be read from and written to JSON
Nov 6 2023, 6:05 PM
tlatham committed rLAURA872d35c57d37: Avoid forcing ranges onto yield parameters in fit models (authored by tlatham).
Avoid forcing ranges onto yield parameters in fit models
Nov 6 2023, 6:05 PM
tlatham committed rLAURAc7d3a3b787e7: Allow LauParameter to not have limits (authored by tlatham).
Allow LauParameter to not have limits
Nov 6 2023, 6:05 PM
tlatham committed rLAURA992c62adc49d: Add partially-combinatorial backgrounds (authored by tlatham).
Add partially-combinatorial backgrounds
Nov 6 2023, 6:05 PM
tlatham added a comment to D103: Create and apply clang-format style.

In parallel I need to check what happens if I apply the same formatting in the timedep branch and then try and merge the branches! If that doesn’t go so well we might have to postpone this change untill after merging timedep into master.

Nov 6 2023, 6:03 PM · Laura
tlatham added a comment to D103: Create and apply clang-format style.

Since this is purely formatting changes, I think the main thing to review is that the formatting style looks reasonable and that the CI check looks ok. Up to you if you want to look through all the files!!

Nov 6 2023, 5:58 PM · Laura
tlatham changed the visibility for D103: Create and apply clang-format style.
Nov 6 2023, 5:48 PM · Laura
tlatham added a revision to T111: Create clang-format style config file: D103: Create and apply clang-format style.
Nov 6 2023, 5:47 PM · Laura
tlatham requested review of D103: Create and apply clang-format style.
Nov 6 2023, 5:47 PM · Laura
tlatham committed rLAURA9dffea19ce7b: Improve use of ROOT dictionary generation macros (authored by tlatham).
Improve use of ROOT dictionary generation macros
Nov 6 2023, 5:33 PM
tlatham updated the diff for D101: Improve use of ROOT dictionary generation macros.

Remove unused member variable from LauKMatrixPropagator

Nov 6 2023, 5:30 PM · Laura
tlatham added inline comments to D101: Improve use of ROOT dictionary generation macros.
Nov 6 2023, 5:23 PM · Laura
tlatham added a comment to D101: Improve use of ROOT dictionary generation macros.

Many thanks for checking through this. I’ve reply to your K-matrix related question inline.

Nov 6 2023, 4:15 PM · Laura

Oct 31 2023

tlatham added a comment to T200: Remove broken and obsolete EvtGen models.

It looks like the VUB_AC model isn't registered in EvtModelReg - should it be removed?

Oct 31 2023, 4:40 PM · Restricted Project
tlatham added a comment to T178: Model KSTARSTARGAMMA does not work correctly.

Just looking at this model to decide whether or not to remove it, as per T200.

Oct 31 2023, 10:19 AM · Restricted Project

Oct 19 2023

tlatham added a comment to D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..

Thanks for the updates @jback. I think it would be good to understand what's going on with the phi Dalitz angles. It looks like the variables are a bit different between what we're plotting and what they showed in their talk. One of their variables runs from -pi to pi, and it called phi, so it seems to be more of an azimuthal type angle. We should ask them for the exact definitions of each of those angles. Otherwise I'm happy.

Oct 19 2023, 8:50 PM · Restricted Project

Oct 17 2023

tlatham added a comment to D101: Improve use of ROOT dictionary generation macros.

@jback - just to provide you with a bit more context. This is the first of three Differentials that I would like to get merged before releasing v3r6 from the master branch:

  • This one, which addresses T213, solving an issue with and generally improving the ROOT dictionary generation
  • One that will address T111 by creating a clang-format style file, applying it to the code, and adding a corresponding CI check
  • One that will address T227 by creating new functions in the fit models to access the amplitude and likelihood as a function of the DP position
Oct 17 2023, 2:55 PM · Laura

Oct 16 2023

tlatham closed D99: Add tests for PHOTOS (T229).
Oct 16 2023, 8:13 PM · Restricted Project
tlatham committed rEVTGEN12dfb11b0493: Add tests for PHOTOS (T229) (authored by abudinen).
Add tests for PHOTOS (T229)
Oct 16 2023, 8:13 PM
tlatham committed rEVTGEN5f84a6c2c28e: Modernise EvtIdSet and other improvements (authored by tlatham).
Modernise EvtIdSet and other improvements
Oct 16 2023, 7:59 PM
tlatham closed D98: Modernise EvtIdSet and other improvements.
Oct 16 2023, 7:59 PM · Restricted Project
tlatham accepted D99: Add tests for PHOTOS (T229).

Looks good now. I'll land D98 and then this one.

Oct 16 2023, 7:50 PM · Restricted Project
tlatham updated the diff for D101: Improve use of ROOT dictionary generation macros.

Fix typo in release notes

Oct 16 2023, 5:15 PM · Laura
tlatham changed the visibility for D101: Improve use of ROOT dictionary generation macros.
Oct 16 2023, 5:09 PM · Laura
tlatham requested review of D101: Improve use of ROOT dictionary generation macros.
Oct 16 2023, 5:09 PM · Laura

Oct 11 2023

tlatham added a comment to D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..

For the newly added code it would be good to have the member variables named with the m_ prefix.

Oct 11 2023, 6:12 PM · Restricted Project
tlatham added a revision to T230: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes: D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
Oct 11 2023, 10:13 AM · Restricted Project
tlatham updated the summary of D100: Add EvtBcVPPHad model and updated EvtPhiDalitz to use helicity amplitudes..
Oct 11 2023, 10:13 AM · Restricted Project

Oct 9 2023

tlatham added a comment to D99: Add tests for PHOTOS (T229).

Thanks for this @abudinen. Do we want to add some cases for hadronic final states?

Oct 9 2023, 11:57 AM · Restricted Project
tlatham added a comment to D98: Modernise EvtIdSet and other improvements.

Thanks @abudinen! @jback, @kreps, any comments? Or should I go ahead with this?

Oct 9 2023, 11:21 AM · Restricted Project

Sep 20 2023

tlatham committed rLAURAe54077b092c5: Fix tests following changes in 6bf46391 (authored by tlatham).
Fix tests following changes in 6bf46391
Sep 20 2023, 6:37 PM
tlatham closed D97: Solved initialisation and pole issue in VTOSLL model..
Sep 20 2023, 6:37 PM · Restricted Project
tlatham committed rEVTGEN846fe14b4c2d: Solved initialisation and pole issue in VTOSLL model. (authored by abudinen).
Solved initialisation and pole issue in VTOSLL model.
Sep 20 2023, 6:37 PM
tlatham closed T219: Fix coefficients for D⁰ → π⁺π⁻π⁰ (D_DALITZ) as Resolved by committing rEVTGEN9633c9c2382c: Fixed D0->pi+pi-pi0 amplitudes.
Sep 20 2023, 6:37 PM · Restricted Project
tlatham committed rEVTGEN382a642fc598: Add test for trailing whitespace in Markdown files to format check (authored by tlatham).
Add test for trailing whitespace in Markdown files to format check
Sep 20 2023, 6:37 PM
tlatham committed rEVTGEN9633c9c2382c: Fixed D0->pi+pi-pi0 amplitudes (authored by lmassa).
Fixed D0->pi+pi-pi0 amplitudes
Sep 20 2023, 6:37 PM
tlatham closed D94: Fixed D0->pi+pi-pi0 amplitudes.
Sep 20 2023, 6:37 PM · Restricted Project

Aug 31 2023

tlatham added inline comments to D97: Solved initialisation and pole issue in VTOSLL model..
Aug 31 2023, 3:19 PM · Restricted Project
tlatham published D98: Modernise EvtIdSet and other improvements for review.
Aug 31 2023, 2:48 PM · Restricted Project

Aug 30 2023

tlatham accepted D97: Solved initialisation and pole issue in VTOSLL model..

ok great, then this can go in, along with D94, I'll take care of landing them both tomorrow

Aug 30 2023, 4:19 PM · Restricted Project

Aug 29 2023

tlatham committed rEVTGEN63161ff2a5c0: Updates to install script (authored by tlatham).
Updates to install script
Aug 29 2023, 4:28 PM