User Details
- User Since
- Jul 3 2018, 2:12 PM (274 w, 1 d)
Wed, Sep 20
Aug 31 2023
Aug 30 2023
ok great, then this can go in, along with D94, I'll take care of landing them both tomorrow
Aug 29 2023
Great, many thanks!
Thanks for adding the comment @lmassa. However, it looks like some other things have changed as well. See:
https://phab.hepforge.org/D94?vs=402&id=412#toc
Are those additional changes intentional?
Aug 23 2023
Many thanks for this @abudinen. After the reviews by @jback and me on the CERN gitlab MR evtgen/evtgen!4, I think this is ready to go, unless @jback has any further comments, or @kreps would like to comment?
The plots look good, e.g. the m_ij^2 projections as per your slide 19:
Many thanks for this @lmassa and apologies for the delay in looking at it.
Aug 22 2023
Aug 21 2023
Comparisons look good I think.
You can find the plots here:
/home/epp/phsdba/Development/EvtGen/pythia8-build-problem/install/share/EvtGen/validation/gifFiles
if you want to take a quick look.
We should also decide how to release this once reviewed and approved. Obviously this can be merged into master but do we then release 02-03-00 from master (i.e. also rolling-up all other changes that have accumulated there) or do we cherry-pick this commit to a branch based on 02-02-00 and release 02-02-01 from that? I'm not sure that we want to release everything that's in master right now, i.e. before we finish fixing all the models that show problems in the tests. So I would tend towards releasing in a patch release.
Aug 11 2023
Aug 9 2023
Aug 8 2023
Jul 13 2023
Jun 28 2023
Jun 26 2023
Jun 22 2023
Jun 21 2023
Jun 16 2023
Jun 9 2023
Please also add an entry in the release notes, which should reference either this Differential revision or the corresponding Maniphest task
Just a few trivial tidy-ups
Jun 8 2023
Many thanks Mark, this looks great. Just a few small suggestions here and there.
Jun 6 2023
Jun 2 2023
May 19 2023
May 4 2023
Apr 24 2023
Apr 20 2023
Mar 13 2023
Mar 3 2023
Mar 2 2023
Thanks, please go ahead and land this
Mar 1 2023
Looks good, thanks @abudinen.
Can you please change the visibility and edit policies according to the instructions?