- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Nov 15 2023
Nov 12 2023
Nov 10 2023
Nov 9 2023
Nov 8 2023
Nov 7 2023
Clang formatting and CI check looks OK, so proceed with organising the appropriate branches.
It looks like it is going to be a nightmare to merge timedep-branch into master if we apply this formatting first (even after applying the same formatting there first).
So what I'd propose is to merge the last actual code changes into master - will create the differential for that shortly - then create a new v3-patches branch, to which this formatting can then be applied, and release v3r6 from that branch. This Differential can be updated to accomplish that part.
The formatting can then be applied to master after merging in timedep-branch - will require a separate Differential at a later date.
Does that sound reasonable?
Nov 6 2023
Thanks to D101, this is now in master but needs to also be propagated to the time-dependent branch, so not yet closing this.
Closed by rLAURA9dffea19ce7b
(not sure why this didn't happen automatically)
In parallel I need to check what happens if I apply the same formatting in the timedep branch and then try and merge the branches! If that doesn’t go so well we might have to postpone this change untill after merging timedep into master.
Since this is purely formatting changes, I think the main thing to review is that the formatting style looks reasonable and that the CI check looks ok. Up to you if you want to look through all the files!!
Remove unused member variable from LauKMatrixPropagator
Many thanks for checking through this. I’ve reply to your K-matrix related question inline.
All of the changes look OK. Just have a query about some K-matrix code that is commented out. Otherwise this can be merged.
Nov 2 2023
Oct 31 2023
It looks like the VUB_AC model isn't registered in EvtModelReg - should it be removed?
Just looking at this model to decide whether or not to remove it, as per T200.
Oct 26 2023
Oct 23 2023
Oct 22 2023
Oct 21 2023
Oct 20 2023
Oct 19 2023
Thanks for the updates @jback. I think it would be good to understand what's going on with the phi Dalitz angles. It looks like the variables are a bit different between what we're plotting and what they showed in their talk. One of their variables runs from -pi to pi, and it called phi, so it seems to be more of an azimuthal type angle. We should ask them for the exact definitions of each of those angles. Otherwise I'm happy.
Oct 18 2023
Oct 17 2023
@jback - just to provide you with a bit more context. This is the first of three Differentials that I would like to get merged before releasing v3r6 from the master branch:
- This one, which addresses T213, solving an issue with and generally improving the ROOT dictionary generation
- One that will address T111 by creating a clang-format style file, applying it to the code, and adding a corresponding CI check
- One that will address T227 by creating new functions in the fit models to access the amplitude and likelihood as a function of the DP position
Oct 16 2023
Looks good now. I'll land D98 and then this one.
Fix typo in release notes
Changes look OK.
Oct 13 2023
Oct 12 2023
Code updated to address the first set of review comments.
- Edits for 1st review round for D100
Oct 11 2023
For the newly added code it would be good to have the member variables named with the m_ prefix.
This looks good to me. I only have a few minor comments, which you find below.
Oct 10 2023
Here are the JSON test distributions for the EvtBcVPPHad and EvtPhiDalitz model updates, which includes some comparisons with tests done by the previous LHCb code review: