Updated History.md after landing of D107
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 19 2024
Rebase after landing of D100
Feb 12 2024
Feb 9 2024
Feb 5 2024
Changes look OK.
Rebased master with check fix.
Issues with PROPSLPOLE turn out to be more involved. The model appears to be doing things it shouldn't. The SLPOLE model should be used in preference. As such the decision is to remove PROPSLPOLE.
Feb 4 2024
Feb 3 2024
Changes look OK, although you will need to update the History file to include the latest changes made by D100.
These changes look OK, although I think you need to "undo" the fix for EvtBcVHad since this has been done in D100 that has been recently merged (which also makes significant changes to other parts of that class). So just update this class to the version in the current master, otherwise I think you will get a merge conflict (for those other parts that have changed).
- Merge branch 'master' of ssh://phab.hepforge.org/source/evtgen
Feb 2 2024
Feb 1 2024
Jan 25 2024
Jan 18 2024
Jan 17 2024
Jan 11 2024
The implementation in D101 has caused problems with being able to run the python example GenFit3pi.py because to be able to use our classes in python they need to have dictionaries generated.
As such, I'm going to revert the changes from landing D101 and make new commits that only apply the following parts of those changes:
- Removal of the deprecated ClassImp macro in all source files
- The improvements to the CMake modules to avoid using old-style CMake stuff like file-level include_directories, etc.
Jan 10 2024
Jan 9 2024
Jan 8 2024
Jan 6 2024
Jan 5 2024
Dec 20 2023
Thanks John, this looks great!
Once I'm back in the office in January I'll run it through the CI and then merge it if all is well.
I've attached a comparison of some of the angular distributions that was used for the Ds -> phi pi, phi -> pi pi pi0 decay (comparing this MR with those from the LHCb Sim meeting talk). It needs new decay angle calculations in the test program.
- Add cosThetaResNorm & cosBetaRes angles to testDecayModel. Used in added test file for Ds -> phi pi, phi -> pi pi pi0. Make EvtVector4R::cross() function constant.
Dec 19 2023
Dec 14 2023
Dec 13 2023
Dec 9 2023
Dec 8 2023
Dec 7 2023
The updated formatting looks good. This is ready to be merged for the new release.
Hi @jback, just a quick note to explain the new changes.
- Updates to clang-format style for clang 16
- Modify clang-format style to 4-space indentation
- Fix missing newline in README
- Scripts to fix indentation of Doxygen comment blocks
- Further improve formatting style
- Re-apply formatting to source files
Nov 27 2023
Nov 24 2023
Formatting and CI check look OK.
Nov 22 2023
Yes, this is OK.
Nov 21 2023
- Apply formatting in v3-patches branch
@jback, does this look ok? It's the same as the code we now have in #evtgen.
Nov 20 2023
- Add warning if requested C++ standard is too old
Nov 16 2023
Thanks John!
Update looks OK.
Nov 15 2023
Thanks. @abudinen, I've tried to improve the clarity of the description following our discussion.
The changes look good to me. Ok, understood that this is just avoiding to use an user defined CMAKE_CXX_STANDARD if it is lower than our standard.