For reference, old LHCb JIRA task for tau decays using TAUOLA (which could not add spin info): https://its.cern.ch/jira/browse/LHCBGAUSS-841.

Code changes look OK. Thanks for porting these over from the LHCb merge request, Michal.

Ok, don't see any showstoppers. Thanks for writing this model, Michal.

From further discussion elsewhere, it looks like the code needs further edits to allow channel-dependent L values (for a given total angular momentum J).

Algorithm looks OK overall, although it would be good if we could try to avoid using double pointers in various functions.

Need to apply an upper bound = 0 for s_0^scatt if this is allowed to float. Some parameters still need "names" added, as per Tom's suggestion.

Thanks @johndan, the changes you have made so far look good and makes the code more general. I have replied to your questions, and have also suggested that we calculate the barrier radii-squared terms at initialisation. Not sure what we can do for avoiding hard-coding the D* mass at initialisation (regarding access to LauResonanceMaker info).

Example environment setup script, using cvmfs packages:

I've had a first look at the code and have provided some suggestions for changes that I think are needed.

Code can be merged.

I'll try to compare the physics against the referenced paper next week, although I guess this was checked during the LHCb review?

• Update EvtEtaLLPiPi model according to D34 suggestions.

Code review: https://phab.hepforge.org/D34

! In T108#1685, @tlatham wrote:
Presumably then we would have json files that define the tests for each model and also have some other json file that maps the model to the source and header files that it depends on (or probably the other way around), then in the CI pipeline we would check what code has changed in the commit and decide which models need to be rerun based on the changes. Is that the idea?

The idea is to run a test doing:

• Need to decide if including the json header & source file is compatible with our license; I think it'll be OK since we include its own license fully.
• Also need to think about where we can store reference histograms for CI pipline. Can we use CERN EOS?
• Can ROOT be used in a CI pipeline? If not, we could create our own simple "histogram" class to store distributions so that they can be compared with references.

I think I've fixed all of the compilation errors and warnings, and have also added the cmake branch changes as well. To build this modernize branch using cmake, do:

I tried gcc 6.3.0 and the configure script has been modified to enable C++14, although the corresponding environment variable is still called CPP11.

LHCb repository uses report() for print statements while our version uses EvtGenReport(). Used the following sed-like commands to change these lines:

There are compilation problems, specifically private copy constructors in EvtItgPtrFunction and related classes, giving errors when auto and make_unique are used in EvtBtoXsgammaKagan, for example. Similar issues occur for
EvtRareLbToLll, EvtVubBLNP and EvtVubNLO. Could be compiler-version dependent?