Fix modernization compiler errors and warnings.
Audited603f6890de84
Actions

Description

Fix modernization compiler errors and warnings.

Auditors

Provenance

jback	Authored on Jan 30 2019, 2:34 PM
jback	Pushed on Jan 30 2019, 2:35 PM

Parents

Branches

Unknown

Tags

Unknown

Tasks

T13: Modernize EvtGen

Just a couple of minor queries. They are genuine questions but I do this largely to try out the code auditing procedures in Phabricator ;)

/src/EvtGenModels/EvtRareLbToLll.cpp
100	What was the compiler warning/error here? It isn't clear to me why we've had to move to a dynamic allocation. The original code does look a bit unusual, I would have expected: EvtDiracParticle parent{};
/src/EvtGenModels/EvtVubNLO.cpp
613–615	I assume that the problem was that the compiler could not deduce the template parameters? Given that, we can drop the use of auto, i.e. by doing: std::array<double,6> gammaCoeffs { ... };

This commit now has outstanding concerns.Jan 31 2019, 2:12 PM

jback marked 2 inline comments as done.Feb 1 2019, 12:38 PM

jback added inline comments.

/src/EvtGenModels/EvtRareLbToLll.cpp
100	The error was that the copy and assignment constructors for EvtDiracParticle are declared private, so the auto command didn't work. I will change this to use the object, as you suggest.
/src/EvtGenModels/EvtVubNLO.cpp
613–615	Yes, the compiler couldn't work out the template parameters. I will change this to as you suggest.