Page MenuHomeHEPForge

johndan (Daniel Johnson)
User

Projects

User Details

User Since
Jul 3 2018, 2:12 PM (171 w, 6 d)

Recent Activity

Apr 23 2021

johndan accepted D69: Fix doxygen problems.

Thank you for these improvements, Tom. I think this is uncontroversial.

Apr 23 2021, 3:52 PM · Laura

Mar 10 2021

johndan added a comment to D55: Updates to chi2 code.

That sounds great, thanks Tom. Let me know when you're ready for me to take a look (there is no urgency - the code above is working locally for me)

Mar 10 2021, 8:56 AM · Laura

Mar 5 2021

johndan added a comment to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.

Thanks for checking through this, @tlatham !

Mar 5 2021, 10:22 AM · Laura
johndan updated the diff for D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
  • Remove unnecessary error message
Mar 5 2021, 10:21 AM · Laura

Mar 2 2021

johndan updated the diff for D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
  • Add catch-all return and finish B-W updates
Mar 2 2021, 2:03 PM · Laura
johndan added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Mar 2 2021, 1:16 PM · Laura
johndan added a comment to D55: Updates to chi2 code.

There are quite a few things that are backward incompatible in this first iteration of the code (e.g. demanding experiment number or axis titles). I can improve that before landing.

Mar 2 2021, 12:37 PM · Laura
johndan created D55: Updates to chi2 code.
Mar 2 2021, 12:33 PM · Laura

Mar 1 2021

johndan added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Mar 1 2021, 2:23 PM · Laura

Feb 27 2021

johndan added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Feb 27 2021, 9:15 AM · Laura

Feb 19 2021

johndan added inline comments to D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Feb 19 2021, 6:52 PM · Laura
johndan created D52: Alterations to allow Blatt-Weisskopf factor for parent to be created in a model with only a K-matrix.
Feb 19 2021, 6:41 PM · Laura

Feb 15 2021

johndan added a comment to T137: Update documentation of K-matrix in paper to cover recent extensions.

I've just written this up in an LHCb ANA. Can I use this, and @jback's initial documentation (from Mattermost), to take a first-pass at this?

Feb 15 2021, 10:16 AM · Laura

Feb 12 2021

johndan added a comment to D41: Implementation of higher-spin K-matrix.

Just to say thanks very much to @jback and @tlatham for taking time to do a really thorough review. Much appreciated!

Feb 12 2021, 12:46 PM · Laura

Feb 9 2021

johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thanks, @jback, done!

Feb 9 2021, 5:04 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correct comment
Feb 9 2021, 5:03 PM · Laura
johndan added inline comments to D41: Implementation of higher-spin K-matrix.
Feb 9 2021, 3:51 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Compilation fixes
Feb 9 2021, 3:51 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Factorise retrieval of the phase-space density and use to obtain barrier-factor matrix for all channels
Feb 9 2021, 3:42 PM · Laura

Feb 8 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Reset haveCalled... variable in initialiseMatrices()
Feb 8 2021, 10:46 AM · Laura

Feb 5 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Return propagator pointer in LauIsobarDynamics::defineKMatrixPropagator
  • Change proposed by Tom to ensure that K-matrix is always treated as non-narrow for integration
  • Fix: set spin type correctly to Legendre for the K-matrix
Feb 5 2021, 1:36 PM · Laura

Feb 4 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Fix 5 compile-time syntax errors
Feb 4 2021, 11:03 AM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Remove noexcept
  • Merge release notes
  • Restore getFloatingParameters doxygen comment
  • Fix LauKMatrixProdSVP whitespace issues
  • Fix parameter naming in resAmp function declaration for ProdPole and SVP
  • Further whitespace fix to SVP
  • Uniform default variable
  • Add const variables
  • Make verbose flag static constexpr (nice, thanks Tom\!)
  • Add braces for Tom
  • Move setting of propagator denominator parameter to setParameters(...) routine
  • Correct a initialisation and move it to a local variable in storeParameters()
  • Update setParameters(...) text to describe new non-zero-spin-related input lines in configuration file for K-matrix
  • Simplify default assignation for L_ and radii_ vectors
  • Reinstate D39 name for pole mass sq param
  • Reinstate D39 name for scatt constant param
  • Reverse change to error message
  • Use atoi for angular momenta not atof
  • Add switch on phasespaceindex inside calcGamma(...) to catch undefined calls to that function
Feb 4 2021, 10:56 AM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Do you have an example of using this generalisation of the K-matrix that could go into the examples dir?

Not yet, but very happy to add one when this implementation has been tested a bit more in my fits. Can I do this later, or shall I pause D41 landing until I've gained a bit more experience with the K-matrix in D0 K+?

Feb 4 2021, 10:51 AM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Remove noexcept
  • Update release notes
  • Restore getFloatingParameters doxygen comment
  • Fix LauKMatrixProdSVP whitespace issues
  • Fix parameter naming in resAmp function declaration for ProdPole and SVP
  • Further whitespace fix to SVP
  • Uniform default variable
  • Add const variables
  • Make verbose flag static constexpr (nice, thanks Tom\!)
  • Add braces for Tom
  • Move setting of propagator denominator parameter to setParameters(...) routine
  • Correct a initialisation and move it to a local variable in storeParameters()
  • Update setParameters(...) text to describe new non-zero-spin-related input lines in configuration file for K-matrix
  • Simplify default assignation for L_ and radii_ vectors
  • Reinstate D39 name for pole mass sq param
  • Reinstate D39 name for scatt constant param
  • Reverse change to error message
  • Use atoi for angular momenta not atof
  • Add switch on phasespaceindex inside calcGamma(...) to catch undefined calls to that function
Feb 4 2021, 10:50 AM · Laura

Feb 2 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • minor change cherry-picking earlier BelleNR commit
Feb 2 2021, 5:06 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Typo in LauKMatrixPropagator.cc
  • Updates to K-matrix propagator to use refined barrier factor
  • Clean up indentation
  • Parallel updates to KMatrixPropagator.hh
  • Cleanup indentation
  • Revert "Allow slope of exponential non-resonant shape to vary positive (for low-stats fits)"
  • rebase conflict
  • rebase conflict
  • D*K system should be in P-wave\!
  • Changes after round of code-review with @jback
  • Remove whitespace
  • Remove whitespace
  • Remove extraneous comment
  • Fix compilation errors
  • rebase conflict
  • Simplify setting of denominator parameter in barrier factor
  • Cache the a/R^2 calculation
  • Neater access to D*0 mass information from LauResonanceMaker - thanks to Tom
  • Add definition of angular momentum term for spin-2 (max spin) to K-matrix
  • Remove done TODO comment and make const several function arguments
  • rebase conflict
  • Add barrier factors to numerator of K-matrix amplitude in ProdPole and ProdSVP, which need to know the spin of the K-matrix using the new getL() function
  • Fix typo in ProdPole.cc and ProdSVP.cc
  • - Changes to allow different orbital angular momenta for different channels inside the K-matrix
  • Correctly initialise a_ vector. Remove calculation of angular factor from K-matrix propagator. Remove any need to update the propagator with the LauKinematics object
  • Remove angular parts of K-matrix header, and add extra function to indicate the final-state channel of the various coupled channels
  • Update ProdPole and SVP to use resAmp (and leave amplitude to LauAbsResonance)
  • Update ProdPole and SVP headers
  • rebase conflict
  • Changes to LauResonanceMaker to allow retrieval of parent Blatt-Weisskopf factor without using resInfo that is not defined for K-matrix
  • Changes to LauBlattWeisskopfFactor to accommodate tangential use by K-matrix to get parent factor without access to a resInfo
  • Add K-matrix name to gCoupling parameters to avoid clashes in models with >1 K-matrix
  • Resolve merge conflict
  • Allow other parameters of the SVP part to be floated
  • Fix merge conflict
  • rebase conflict
  • Remove duplicate par_mSq0_
  • rebase conflict
  • Protect all parameters of calls to resAmp for prodpole / svp with const
  • resolve conflict
  • Missing ;
  • Movement of one comment and correct access to one floating parameter
  • Remove unnecessary whitespace
  • Allow floating of s0scatt and mSq0
  • Cherry pick commit from 19th Jan that moved enum class KMatrixChannels and resolve associated conflicts
  • Turn off auto-verbose-printout in propagator
  • Move a comment - trivial
  • Increase precision of verbose printout
  • Clean whitespace
Feb 2 2021, 4:57 PM · Laura

Jan 29 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Movement of one comment
  • Allow floating of s0scatt and mSq0
  • Cherry pick commit from 19th Jan that moved enum class KMatrixChannels and resolve associated conflicts
  • Turn off auto-verbose-printout in propagator
Jan 29 2021, 7:19 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Allow floating of s0scatt and mSq0
Jan 29 2021, 6:58 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Movement of one comment and correct access to one floating parameter
  • trivial reset of changes caught up in earlier commit
Jan 29 2021, 6:37 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Minor, aesthetic, improvements
Jan 29 2021, 2:06 PM · Laura

Jan 28 2021

johndan added a comment to D41: Implementation of higher-spin K-matrix.

The exact amplitude has been reproduced with another fitter. Anything left for me to do before we land?

Jan 28 2021, 8:30 PM · Laura
johndan added a comment to D39: Allow floating of parameters in the k-matrix.

Can we 'land' this so that we can start merging D41? Thanks!

Jan 28 2021, 8:28 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Protect all parameters of calls to resAmp for prodpole / svp with const
  • Clean up K-matrix propagator default values. Add lots of const protection to function calls. Noexcept throughout
Jan 28 2021, 8:27 PM · Laura

Jan 21 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Use default values at declaration in LauAbsResonance to significantly simplify the constructors
Jan 21 2021, 12:54 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Cleanup LauAbsResonance constructor which involved a lot of duplication for K-matrix
Jan 21 2021, 12:51 PM · Laura
johndan added inline comments to D41: Implementation of higher-spin K-matrix.
Jan 21 2021, 12:41 PM · Laura

Jan 15 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Remove duplicate par_mSq0_
Jan 15 2021, 3:04 PM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thanks, @jback. A few answers to your responses, with just one that doesn't (yet) make sense to me...

Jan 15 2021, 11:46 AM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Add K-matrix name to gCoupling parameters to avoid clashes in models with >1 K-matrix
  • Resolve merge conflict
  • Allow other parameters of the SVP part to be floated
  • Fix merge conflict
Jan 15 2021, 11:21 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Remove whitespace at end of file
  • Fix compilation errors
Jan 15 2021, 11:19 AM · Laura
johndan added a comment to D39: Allow floating of parameters in the k-matrix.

I think only 1 parameter needed a changed name - @jback let me know if I missed something here though.

Jan 15 2021, 11:03 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Allow other parameters of the SVP to be floated
Jan 15 2021, 11:02 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add K-matrix name to gCoupling parameters to avoid clashes in models with >1 K-matrix
Jan 15 2021, 10:52 AM · Laura

Jan 14 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correctly initialise a_ vector. Remove calculation of angular factor from K-matrix propagator. Remove any need to update the propagator with the LauKinematics object
  • Remove angular parts of K-matrix header, and add extra function to indicate the final-state channel of the various coupled channels
  • Update ProdPole and SVP to use resAmp (and leave amplitude to LauAbsResonance)
  • Update LauAbsResonance to apply spin to constructed objects that don't use the 'normal' constructor
  • Changes to LauResonanceMaker to allow retrieval of parent Blatt-Weisskopf factor without using resInfo that is not defined for K-matrix
  • Changes to LauBlattWeisskopfFactor to accommodate tangential use by K-matrix to get parent factor without access to a resInfo
Jan 14 2021, 8:05 PM · Laura

Jan 11 2021

johndan added a comment to D41: Implementation of higher-spin K-matrix.

I've included the changes to tell the K-matrix about the orbital angular momentum of each channel, as discussed on Mattermost. I've also made 3 comments in the code for you, @jback. Thanks!

Jan 11 2021, 8:24 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Changes to allow different orbital angular momenta for different channels inside the K-matrix
Jan 11 2021, 8:13 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Changes to allow different orbital angular momenta for different channels inside the K-matrix
Jan 11 2021, 8:13 PM · Laura

Jan 8 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Remove done TODO comment and make const several function arguments
  • Add function to LauKMatrixPropagator that returns K-matrix spin, and make various function arguments const
  • Add barrier factors to numerator of K-matrix amplitude in ProdPole and ProdSVP, which need to know the spin of the K-matrix using the new getL() function
  • Fix typo in ProdPole.cc and ProdSVP.cc
Jan 8 2021, 9:04 PM · Laura

Jan 7 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correct displaced doxygen comment
  • Simplify setting of denominator parameter in barrier factor from file
  • Cache the a/R^2 calculation - thanks John!
  • Neater access to D*0 mass information from LauResonanceMaker - thanks Tom!
  • Add definition of angular momentum term for spin-2 (max spin) to K-matrix
Jan 7 2021, 1:07 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correct displaced doxygen comment
  • Simplify setting of denominator parameter in barrier factor from file
  • Cache the a/R^2 calculation - thanks John!
  • Neater access to D*0 mass information from LauResonanceMaker - thanks Tom!
  • Add definition of angular momentum term for spin-2 (max spin) to K-matrix
Jan 7 2021, 1:07 PM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thanks @jback and @tlatham, I've handled all the remaining comments. There are some deeper issues to resolve (see the Laura++ mattermost channel) before we land this. D39 needs to come first, anyway, and that one is ready to go.

Jan 7 2021, 1:04 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Correct Doxygen comments
Jan 7 2021, 10:23 AM · Laura
johndan requested review of D39: Allow floating of parameters in the k-matrix.
Jan 7 2021, 10:20 AM · Laura

Jan 5 2021

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • D*K system should be in P-wave, not just D0K !
  • Changes after round of code-review with @jback
  • Remove whitespace and make minor bugfixes found during compilation tests
Jan 5 2021, 3:22 PM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thank you for the comments @jback . I've implemented them in most cases, or left a reply in the few where further input from you is needed.

Jan 5 2021, 3:21 PM · Laura

Dec 16 2020

johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add K-matrix name to parameter names, to allow multiple K-M's per model
Dec 16 2020, 4:23 PM · Laura
johndan added inline comments to D39: Allow floating of parameters in the k-matrix.
Dec 16 2020, 4:23 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add braces for Tom
  • Allow pole mass-squared to vary
Dec 16 2020, 3:37 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add doxygen lines for one function
Dec 16 2020, 2:42 PM · Laura

Dec 10 2020

johndan accepted D42: Fix LauFormulaPar to follow change in behaviour of TFormula.

I tested the patch and it does the job.

Dec 10 2020, 5:17 PM · Laura

Nov 30 2020

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correct name of s0prod LauParameter, thus distinguishing it from s0Scatt
  • Need to name scattering parameter for it to be floated
Nov 30 2020, 1:46 PM · Laura

Nov 27 2020

johndan updated the diff for D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
  • Update release notes
Nov 27 2020, 6:22 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Correct name of s0prod LauParameter, thus distinguishing it from s0Scatt
Nov 27 2020, 4:08 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Typo in LauKMatrixPropagator.cc
  • Updates to K-matrix propagator to use refined barrier factor
  • Clean up indentation
  • Parallel updates to KMatrixPropagator.hh
  • Cleanup indentation
  • Revert "Allow slope of exponential non-resonant shape to vary positive (for low-stats fits)"
Nov 27 2020, 2:07 PM · Laura

Nov 26 2020

johndan updated the diff for D41: Implementation of higher-spin K-matrix.

Fix typo in LauKMatrixPropagator.hh

Nov 26 2020, 4:58 PM · Laura
johndan updated the summary of D41: Implementation of higher-spin K-matrix.
Nov 26 2020, 4:21 PM · Laura
johndan retitled D41: Implementation of higher-spin K-matrix from Allow floating of parameters in the k-matrix to Implementation of higher-spin K-matrix.
Nov 26 2020, 4:19 PM · Laura
johndan created D41: Implementation of higher-spin K-matrix.
Nov 26 2020, 12:36 PM · Laura

Nov 18 2020

johndan changed the edit policy for D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
Nov 18 2020, 1:47 PM · Laura
johndan created D40: Allow slope of exponential non-resonant shape to vary positive (for low-stats fits).
Nov 18 2020, 1:46 PM · Laura
johndan added a comment to T59: Allow the s0_prod parameter of the K-matrix to float.

https://phab.hepforge.org/D39

Nov 18 2020, 10:25 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Remove more changes destined for later review
Nov 18 2020, 10:24 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Remove changes not intended for this review
Nov 18 2020, 10:23 AM · Laura
johndan created D39: Allow floating of parameters in the k-matrix.
Nov 18 2020, 10:14 AM · Laura

Nov 17 2020

johndan added a comment to T59: Allow the s0_prod parameter of the K-matrix to float.

https://phab.hepforge.org/rLAURA44c84d8721bb822b76abfd295086ac273606231e

Nov 17 2020, 3:22 PM · Laura
johndan committed rLAURA44c84d8721bb: Allow floating of parameters in the k-matrix (authored by johndan).
Allow floating of parameters in the k-matrix
Nov 17 2020, 3:14 PM
johndan committed rLAURAaef7d8cdca1f: Allow floating of parameters in the k-matrix (authored by johndan).
Allow floating of parameters in the k-matrix
Nov 17 2020, 2:10 PM
johndan committed rLAURAb6aeae5db905: Add new rescattering lineshape (authored by johndan).
Add new rescattering lineshape
Nov 17 2020, 2:10 PM
johndan committed rLAURA31fc3a6ee0a1: Fix resonance definitions (authored by johndan).
Fix resonance definitions
Nov 17 2020, 2:10 PM
johndan committed rLAURAc347f40e5bf6: Fix sampling bug (authored by johndan).
Fix sampling bug
Nov 17 2020, 2:10 PM
johndan committed rLAURA3fdf09b0fa14: Add code to handle Misha's rescattering lineshape (authored by johndan).
Add code to handle Misha's rescattering lineshape
Nov 17 2020, 2:10 PM
johndan committed rLAURAe3b7a8d0ff7b: Modify chi2 code to present data and toy info (authored by johndan).
Modify chi2 code to present data and toy info
Nov 17 2020, 2:10 PM
johndan committed rLAURA2591d1e74a83: Remove flooring of yields before passing as rate value to Poisson generator (authored by tlatham).
Remove flooring of yields before passing as rate value to Poisson generator
Nov 17 2020, 2:10 PM
johndan committed rLAURA50d041d944f5: Fix typo I introduced while adding LauPolNR changes (authored by johndan).
Fix typo I introduced while adding LauPolNR changes
Nov 17 2020, 2:10 PM
johndan committed rLAURA05df6aaac034: Resonances specific to analysis (authored by johndan).
Resonances specific to analysis
Nov 17 2020, 2:10 PM
johndan committed rLAURA3fde6d4bb6c6: LauPolNR shape was not working for ++ components. Hack to pull that off the… (authored by johndan).
LauPolNR shape was not working for ++ components. Hack to pull that off the…
Nov 17 2020, 2:10 PM
johndan committed rLAURAcbaceda4cf79: Allow slope of exponential non-resonant shape to vary positive (for low-stats… (authored by johndan).
Allow slope of exponential non-resonant shape to vary positive (for low-stats…
Nov 17 2020, 2:10 PM
johndan committed rLAURAe3488ca7450c: Add particle mass definitions to match LHCb-versions for ongoing analysis (authored by johndan).
Add particle mass definitions to match LHCb-versions for ongoing analysis
Nov 17 2020, 2:10 PM
johndan added a comment to T59: Allow the s0_prod parameter of the K-matrix to float.

Also extending to encompass floating of the pole-channel coupling parameters and the scattering parameters of the slowly-varying part

Nov 17 2020, 1:25 PM · Laura
johndan claimed T59: Allow the s0_prod parameter of the K-matrix to float.
Nov 17 2020, 1:24 PM · Laura

Dec 12 2019

johndan committed rLAURA3c330af6ac44: Fix typo in generated event yield (authored by johndan).
Fix typo in generated event yield
Dec 12 2019, 11:01 AM