Page MenuHomeHEPForge

Add EvtEtaLLPiPi model.
Needs ReviewPublic

Authored by jback on Aug 21 2020, 7:48 PM.

Details

Summary

Add EvtEtaLLPiPi model for eta' -> l l pi pi decays (l = e or mu), for https://phab.hepforge.org/T109.

Test Plan

Model has been tested using testDecayModel (in the jsonTest branch).

Diff Detail

Repository
rEVTGEN evtgen
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 87
Build 87: arc lint + arc unit

Event Timeline

jback created this revision.Aug 21 2020, 7:48 PM
jback changed the edit policy from "All Users" to "Restricted Project (Project)".Aug 21 2020, 7:49 PM
jback added a project: Restricted Project.
jback requested review of this revision.Aug 21 2020, 7:51 PM
jback edited the summary of this revision. (Show Details)Aug 21 2020, 8:05 PM
jback changed the visibility from "All Users" to "Public (No Login Required)".Sep 1 2020, 3:17 PM
tlatham requested changes to this revision.Fri, Oct 2, 10:22 PM

Hi @jback, sorry it's taken me so long to review this.
You can find here some technical points.
I'll try to compare the physics against the referenced paper next week, although I guess this was checked during the LHCb review?
You mention also testing it using testDecayModel but I can't find the json file(s) for this model. Could you include them in the next revision?

EvtGenModels/EvtEtaLLPiPi.hh
31

Can you please run clang-format (preferably version 10.0.0) on these few files when submitting the next version?
Will add mention of this in the CONTRIBUTING docs.

History.txt
19

Thanks for remembering to update this file! I shall also mention this in the CONTRIBUTING docs.
Would be good to reference here the Maniphest tasks and/or the Differential revisions associated with each change.
I think there's also been one other bug fix (T103) that we should probably include here.

src/EvtGenModels/EvtEtaLLPiPi.cpp
56

Would be better to give these values in the header.
Then this constructor can be removed from here and just be '=default' in the header.

This revision now requires changes to proceed.Fri, Oct 2, 10:22 PM
jback updated this revision to Diff 135.Sat, Oct 3, 2:49 PM
  • Update EvtEtaLLPiPi model according to D34 suggestions.
jback marked 3 inline comments as done.Sat, Oct 3, 3:08 PM

I'll try to compare the physics against the referenced paper next week, although I guess this was checked during the LHCb review?

Yes, Aleksei checked that the code changes produced distributions that matched the plots shown at the Gauss simulation meeting:

https://indico.cern.ch/event/876000

Relevant comment in code review:

https://gitlab.cern.ch/lhcb/Gauss/-/merge_requests/626#note_3723807

The plots looked OK for my tests as well.

You mention also testing it using testDecayModel but I can't find the json file(s) for this model. Could you include them in the next revision?

I've added the json files to the jsonTest branch: test/jsonFiles/EtaEEPiPi.json and EtaMuMuPiPi.json. This revision does not include the json testing code.

History.txt
19

Have added maniphest and differential links for code review in the history file, since version 2.0.0.

jback added a comment.Sat, Oct 3, 3:12 PM
This comment was removed by jback.