Fantastic, many thanks @abudinen!

Closed by D86

Closed by D109

Not sure why this wasn't automatically closed when bd48b7fe5585 was committed, so closing it manually

• Fixup changes from comments

• Update History.md

Tests are all good, so I'll go ahead and land this.

• Comments from John

Many thanks @jback - see replies inline.
Will push the small changes here in a second.
I'm re-running the tests just to make sure nothing changes - if all is ok I'll land this tomorrow.

Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.

@kreps, @jback, @averbyts please let me know if you have any comments

I have run all the tests on master and on the branch with these changes on top.

• Comments from Fernando

Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.

Rebase on master branch:

• Rename member variables to avoid leading underscores
• Enable shadowing and overloaded-virtual compiler warnings
• Doxygen fixes
• Add check of member variable names in CI

Thanks @abudinen, looks good to me

Many thanks @abudinen, looks great, please go ahead.

Great, thanks for checking it over @jback!

Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.

Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.

Rebase on master

Thanks @abudinen, I've added the lists you requested to the History file.

• Add lists of removed models and EvtGenBase classes

Looks good, many thanks!

• Update History.md

Updated History.md after landing of D107

Rebase after landing of D100

Issues with PROPSLPOLE turn out to be more involved. The model appears to be doing things it shouldn't. The SLPOLE model should be used in preference. As such the decision is to remove PROPSLPOLE.

The implementation in D101 has caused problems with being able to run the python example GenFit3pi.py because to be able to use our classes in python they need to have dictionaries generated.
As such, I'm going to revert the changes from landing D101 and make new commits that only apply the following parts of those changes:

• Removal of the deprecated ClassImp macro in all source files
• The improvements to the CMake modules to avoid using old-style CMake stuff like file-level include_directories, etc.

Thanks John, this looks great!
Once I'm back in the office in January I'll run it through the CI and then merge it if all is well.

Hi @jback, just a quick note to explain the new changes.

• Updates to clang-format style for clang 16
• Modify clang-format style to 4-space indentation
• Fix missing newline in README
• Scripts to fix indentation of Doxygen comment blocks
• Further improve formatting style
• Re-apply formatting to source files

• Apply formatting in v3-patches branch

@jback, does this look ok? It's the same as the code we now have in #evtgen.

• Add warning if requested C++ standard is too old

Thanks John!

Thanks. @abudinen, I've tried to improve the clarity of the description following our discussion.

It looks like it is going to be a nightmare to merge timedep-branch into master if we apply this formatting first (even after applying the same formatting there first).
So what I'd propose is to merge the last actual code changes into master - will create the differential for that shortly - then create a new v3-patches branch, to which this formatting can then be applied, and release v3r6 from that branch. This Differential can be updated to accomplish that part.
The formatting can then be applied to master after merging in timedep-branch - will require a separate Differential at a later date.
Does that sound reasonable?

Thanks to D101, this is now in master but needs to also be propagated to the time-dependent branch, so not yet closing this.