Thanks very much for this @johndan. It looks good.
I think it would just be good to take the opportunity while we're at it to allow any of the parameters to float.
We should also include the name of the propagator in the name of the parameters so that if we have more than one K-matrix in a given fit we don't get identically named parameters appearing - this will cause problems with the sim-fit for example.
See the inline comments for details.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 16 2020
Dec 10 2020
I tested the patch and it does the job.
Dec 3 2020
- Update release notes
Looks good to me
Dec 2 2020
OK, good to go now, I'll take care of landing it later on.
- Reference Maniphest task in release notes
Nov 30 2020
- Correct name of s0prod LauParameter, thus distinguishing it from s0Scatt
- Need to name scattering parameter for it to be floated
Nov 27 2020
- Update release notes
- Correct name of s0prod LauParameter, thus distinguishing it from s0Scatt
- Typo in LauKMatrixPropagator.cc
- Updates to K-matrix propagator to use refined barrier factor
- Clean up indentation
- Parallel updates to KMatrixPropagator.hh
- Cleanup indentation
- Revert "Allow slope of exponential non-resonant shape to vary positive (for low-stats fits)"
Nov 26 2020
Fix typo in LauKMatrixPropagator.hh
Nov 23 2020
Hi Dan,
Nov 18 2020
Nov 17 2020
Also extending to encompass floating of the pole-channel coupling parameters and the scattering parameters of the slowly-varying part
Sep 29 2020
Sep 17 2020
Sep 16 2020
Have switched to coordinator/task as seen in review D35
Sep 9 2020
I suppose at least 'worker' should imply someone being paid for their services.
I suppose at least 'worker' should imply someone being paid for their services. Maybe 'fitter' could also be an option in this case.
I think the first 3 you list don't really work very well in this context (as you say). However, 'coordinator/worker' describes rather well the relationship of the objects here.
A few alternatives to replace 'master' along the same lines could be 'manager', 'director', or 'controller'.
But I'm struggling to come up with other good alternatives to 'worker', which could maybe still be taken to be a bit pejorative? Maybe 'runner'? Any other ideas?
There are a few choices of replacements in the literature, some of which are listed here: https://en.wikipedia.org/wiki/Master/slave_(technology):
List of files containing slave and/or master:
Aug 19 2020
Jul 27 2020
Jul 20 2020
Apr 16 2020
Apr 2 2020
Nov 21 2019
Changes merged into master branch
Nov 19 2019
Thanks for the checks @dpohanlon. I've committed the required changes to the script to make it OK for python 3 in rLAURA5cbd960c5bb7.
Will wait to see if anyone else finds any problems, otherwise I'll merge this into master tomorrow.
Works fine with the LCG_96python3 environment (CMake 3.14.3) on CentOS 7 with GCC 8.3.0, and the Python GenFit3pi.py also works fine (after some '2to3').
I believe that this task is now completed.
@jback, @mwhitehe, @dpohanlon could one or more of you please test this and report back on this task?
The README has been updated with new instructions, so please clone the package, switch to the cmake branch and then try to follow those to build the library, examples and documentation. Try running some of the examples (including the python one) from the install location.
Nov 13 2019
Everything seems to build OK on gcc8, gcc9 and clang8 on CentOS 7 as well as clang10 on MacOS 10.14
Nov 4 2019
The git repository for the code is now public and has been announced on the mailing list.
The repository for the documentation will remain visible only to Laura members.