Page MenuHomeHEPForge
Create Task
Maniphest T33

Adopt CMake build system
Closed, ResolvedPublic
Actions

Description

The current hand-written Makefiles are not sufficiently flexible.
Laura++ will adopt the CMake build system, which is becoming standard across HEP.
This can be done capitalising on the recent experience of migrating the EvtGen package: T12

Revisions and Commits

rLAURA laura
rLAURAb80360bc3c5a Use CMake variable for project URL in Doxygen main page
rLAURA98757438eb22 Include installation of python version of GenFit3pi
rLAURA6398c616b591 Document building against this project
rLAURAfd7dad36e9b6 Add installation of rootmap and pcm files
rLAURA6fcbbf8dab62 Fixes and improvements to README
rLAURA9e906f5dfb16 Automate building of the Doxygen documentation
rLAURAcd65b0a4227d First draft of CMake build system

Related Objects

Event Timeline

tlatham triaged this task as Normal priority.May 29 2019, 10:16 AM
tlatham created this task.
tlatham created this object with edit policy "Laura (Project)".
tlatham changed the visibility from "All Users" to "Public (No Login Required)".Nov 4 2019, 11:39 AM
tlatham added a commit: rLAURAcd65b0a4227d: First draft of CMake build system.Nov 6 2019, 6:40 PM
tlatham added a commit: rLAURA9e906f5dfb16: Automate building of the Doxygen documentation.Nov 9 2019, 9:04 AM
tlatham added a comment.Nov 13 2019, 5:29 PM

Everything seems to build OK on gcc8, gcc9 and clang8 on CentOS 7 as well as clang10 on MacOS 10.14

We need to install the libLaura++_rdict.pcm and libLaura++.rootmap files into the library install location.

Still need to test trying to use find_package to build against an installation.

tlatham added commits: rLAURA6fcbbf8dab62: Fixes and improvements to README, rLAURAfd7dad36e9b6: Add installation of rootmap and pcm files, rLAURA6398c616b591: Document building against this project.Nov 18 2019, 1:48 PM
tlatham added a commit: rLAURA98757438eb22: Include installation of python version of GenFit3pi.Nov 19 2019, 11:42 AM
tlatham added subscribers: dpohanlon, jback, mwhitehe.Nov 19 2019, 12:06 PM

I believe that this task is now completed.
@jback, @mwhitehe, @dpohanlon could one or more of you please test this and report back on this task?
The README has been updated with new instructions, so please clone the package, switch to the cmake branch and then try to follow those to build the library, examples and documentation. Try running some of the examples (including the python one) from the install location.

dpohanlon added a comment.EditedNov 19 2019, 1:52 PM

Works fine with the LCG_96python3 environment (CMake 3.14.3) on CentOS 7 with GCC 8.3.0, and the Python GenFit3pi.py also works fine (after some '2to3').

Also works fine on OS 10.14.6 with Apple Clang 9.0.0 and ROOT from conda-forge (https://anaconda.org/conda-forge/root).

tlatham added a comment.Nov 19 2019, 2:43 PM

Thanks for the checks @dpohanlon. I've committed the required changes to the script to make it OK for python 3 in rLAURA5cbd960c5bb7.
Will wait to see if anyone else finds any problems, otherwise I'll merge this into master tomorrow.

tlatham added a commit: rLAURAb80360bc3c5a: Use CMake variable for project URL in Doxygen main page.Nov 20 2019, 9:37 AM
tlatham closed this task as Resolved.Nov 21 2019, 3:24 PM

Changes merged into master branch