Page MenuHomeHEPForge
Feed Advanced Search

Tue, May 21

tlatham accepted D118: Remove obsolete ISR flag..
Tue, May 21, 10:17 PM · Restricted Project
tlatham changed the visibility for D118: Remove obsolete ISR flag..
Tue, May 21, 10:16 PM · Restricted Project
tlatham accepted D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.

Fantastic, many thanks @abudinen!

Tue, May 21, 8:22 AM · Restricted Project

Wed, May 15

tlatham closed T29: Define code formatting style and contributing policies for EvtGen as Resolved.

Closed by D86

Wed, May 15, 2:58 PM · Restricted Project
tlatham closed T178: Model KSTARSTARGAMMA does not work correctly as Resolved.

Closed by D109

Wed, May 15, 2:53 PM · Restricted Project

Wed, May 8

tlatham closed D58: Rename member variables to follow convention of m_ prefix.

Not sure why this wasn't automatically closed when bd48b7fe5585 was committed, so closing it manually

Wed, May 8, 12:36 PM · Restricted Project
tlatham committed rEVTGENbd48b7fe5585: Rename member variables to follow convention of m_ prefix (authored by tlatham).
Rename member variables to follow convention of m_ prefix
Wed, May 8, 12:05 PM
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Fixup changes from comments
Wed, May 8, 12:05 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Update History.md
Wed, May 8, 11:59 AM · Restricted Project
tlatham updated the summary of D58: Rename member variables to follow convention of m_ prefix.
Wed, May 8, 11:58 AM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Tests are all good, so I'll go ahead and land this.

Wed, May 8, 11:51 AM · Restricted Project

Tue, May 7

tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Comments from John
Tue, May 7, 10:29 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Many thanks @jback - see replies inline.
Will push the small changes here in a second.
I'm re-running the tests just to make sure nothing changes - if all is ok I'll land this tomorrow.

Tue, May 7, 10:29 PM · Restricted Project

May 1 2024

tlatham accepted D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.

Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.

May 1 2024, 4:18 PM · Restricted Project

Apr 29 2024

tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

@kreps, @jback, @averbyts please let me know if you have any comments

Apr 29 2024, 4:55 PM · Restricted Project
tlatham created T253: Review and standardise use of integer types.
Apr 29 2024, 2:42 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

I have run all the tests on master and on the branch with these changes on top.

Apr 29 2024, 2:36 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Comments from Fernando
Apr 29 2024, 2:33 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.

Apr 29 2024, 2:33 PM · Restricted Project

Apr 26 2024

tlatham updated the summary of D58: Rename member variables to follow convention of m_ prefix.
Apr 26 2024, 4:42 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.

Rebase on master branch:

  • Rename member variables to avoid leading underscores
  • Enable shadowing and overloaded-virtual compiler warnings
  • Doxygen fixes
  • Add check of member variable names in CI
Apr 26 2024, 4:40 PM · Restricted Project