Page MenuHomeHEPForge
Feed Advanced Search

Apr 29 2022

tlatham moved T183: Introduce clang-tidy checks and fix existing code from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 29 2022, 2:36 PM · Restricted Project
tlatham moved T182: Compile priority ordered list of clang-tidy checks from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 29 2022, 2:36 PM · Restricted Project
tlatham moved T181: Use clang-tidy static analysis checks from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Apr 29 2022, 2:36 PM · Restricted Project
tlatham triaged T184: Introduce automated clang-tidy checks in CI as Low priority.
Apr 29 2022, 2:28 PM · Restricted Project
tlatham triaged T183: Introduce clang-tidy checks and fix existing code as Low priority.
Apr 29 2022, 2:26 PM · Restricted Project
tlatham triaged T182: Compile priority ordered list of clang-tidy checks as Low priority.
Apr 29 2022, 2:25 PM · Restricted Project
tlatham renamed T181: Use clang-tidy static analysis checks from Use `clang-tidy` static analysis checks to Use clang-tidy static analysis checks.
Apr 29 2022, 2:22 PM · Restricted Project
tlatham triaged T181: Use clang-tidy static analysis checks as Low priority.
Apr 29 2022, 2:22 PM · Restricted Project
tlatham added a comment to D80: Add CMake options for enabling clang-tidy static analysis checks during build.

Thanks Michal.
The config file is mostly just the default values with the only customisation coming in the first 5 lines:

  • line 1 to run only the modernize-use-nullptr check
  • line 3 to ensure that it warns about things in our header files
  • line 5 so that it uses our .clang-format file for reformatting after any auto-applied changes

I have no doubt that the existing code will need cleaning up as we enable more checks. This is why I say "eventually" about having this run automatically, otherwise we'll just be swamped with warnings. A point for subsequent discussion will be what checks we want to use and in what order to start to gradually enable them and fix stuff as we go. I'll create a task where we can have such a discussion.

Apr 29 2022, 2:00 PM · Restricted Project
tlatham committed rLAURA192f18fda4f2: Fix for LauFlavTag Doxygen (authored by tlatham).
Fix for LauFlavTag Doxygen
Apr 29 2022, 11:40 AM
tlatham committed rLAURA953fe9ee47ba: Fix JSON serialisation of enums in Lau1DCubicSpline plus Doxygen fixes (authored by tlatham).
Fix JSON serialisation of enums in Lau1DCubicSpline plus Doxygen fixes
Apr 29 2022, 11:40 AM

Apr 26 2022

tlatham committed rLAURA4a2c64eaf903: Update required versions of external deps (authored by tlatham).
Update required versions of external deps
Apr 26 2022, 3:29 PM
tlatham committed rLAURA3de95d99e742: Have readFromJson return a unique_ptr to make failures obvious (authored by tlatham).
Have readFromJson return a unique_ptr to make failures obvious
Apr 26 2022, 3:29 PM
tlatham committed rLAURA89bbf59939df: Improve reading/writing Lau1DCubicSpline in JSON format (authored by tlatham).
Improve reading/writing Lau1DCubicSpline in JSON format
Apr 26 2022, 3:29 PM
tlatham committed rLAURAbe3d2fb9b885: Skeleton for reading/writing Lau1DCubicSpline in JSON format (authored by tlatham).
Skeleton for reading/writing Lau1DCubicSpline in JSON format
Apr 26 2022, 3:29 PM

Apr 14 2022

tlatham accepted D82: EvtDecayProb minor fixes.

Thanks John!

Apr 14 2022, 2:45 PM · Restricted Project

Apr 7 2022

tlatham published D80: Add CMake options for enabling clang-tidy static analysis checks during build for review.
Apr 7 2022, 3:03 PM · Restricted Project

Mar 22 2022

tlatham changed the visibility for T175: EvtSLBaryonAmp sets spin-density matrix of parent internally.
Mar 22 2022, 10:28 AM · Restricted Project

Feb 9 2022

tlatham committed rLAURA2ec93e39af92: Update pulls on floating FT calib parameters (authored by tlatham).
Update pulls on floating FT calib parameters
Feb 9 2022, 4:21 PM
tlatham committed rLAURAa30697c8cef4: Fix background normalisations - plus comments from Mark on MR (authored by tlatham).
Fix background normalisations - plus comments from Mark on MR
Feb 9 2022, 4:21 PM
tlatham committed rLAURAc5a9ec5ad767: Fix bug in initialisation of combinatorial tagging efficiecy parameters (authored by tlatham).
Fix bug in initialisation of combinatorial tagging efficiecy parameters
Feb 9 2022, 4:21 PM
tlatham committed rLAURA5204e52b30c2: Allow tageff to depend on decay flavour for Combinatorial background (authored by tlatham).
Allow tageff to depend on decay flavour for Combinatorial background
Feb 9 2022, 4:21 PM

Dec 6 2021

tlatham moved T136: Create an example for non S-wave K-matrix from New features / enhancements to Documentation on the Laura board.
Dec 6 2021, 1:07 PM · Laura

Nov 30 2021

tlatham committed rLAURA823d76ff708a: Update CI to disallow dev build failure in scheduled pipelines (authored by tlatham).
Update CI to disallow dev build failure in scheduled pipelines
Nov 30 2021, 2:03 PM
tlatham committed rLAURA9e6486d05021: Update CI to simplify changing compiler version (authored by tlatham).
Update CI to simplify changing compiler version
Nov 30 2021, 2:03 PM
tlatham committed rLAURAcbb9eea3e7e7: Unify citations of arXiv:1407.0748 plus Doxygen fixes (authored by tlatham).
Unify citations of arXiv:1407.0748 plus Doxygen fixes
Nov 30 2021, 12:14 PM
tlatham committed rLAURA20d26e16f77b: Some modernisation of spline-related classes (authored by tlatham).
Some modernisation of spline-related classes
Nov 30 2021, 12:14 PM
tlatham committed rLAURAda156790730f: Unify control of printout level when performing auxilliary fits (authored by tlatham).
Unify control of printout level when performing auxilliary fits
Nov 30 2021, 12:14 PM
tlatham committed rLAURAead0aae49d5a: Some Doxygen improvements (authored by tlatham).
Some Doxygen improvements
Nov 30 2021, 12:14 PM
tlatham committed rLAURAe45cb5bff140: Fix some missing includes (authored by tlatham).
Fix some missing includes
Nov 30 2021, 12:14 PM
tlatham committed rLAURA22a95211f13f: Modernise LauComplex (authored by tlatham).
Modernise LauComplex
Nov 30 2021, 12:14 PM
tlatham committed rLAURA141ca40a345e: Mention Poisson smearing status in createFitToyMC info message (authored by tlatham).
Mention Poisson smearing status in createFitToyMC info message
Nov 30 2021, 12:14 PM
tlatham committed rLAURA28d6b8f47f51: Spline efficiency model can fit to TH1 (authored by tlatham).
Spline efficiency model can fit to TH1
Nov 30 2021, 12:14 PM
tlatham committed rLAURA8c2d99bb46f5: Update Test_Dpipi to use 6th order splines (authored by tlatham).
Update Test_Dpipi to use 6th order splines
Nov 30 2021, 12:14 PM
tlatham committed rLAURA35a981a6211b: Revamp how parameters are passed to the fit model (authored by tlatham).
Revamp how parameters are passed to the fit model
Nov 30 2021, 12:14 PM
tlatham committed rLAURA0105b12b2f2e: Fix bug in LauDecayTimePdf for Hist case (authored by tlatham).
Fix bug in LauDecayTimePdf for Hist case
Nov 30 2021, 12:14 PM
tlatham committed rLAURAd168cb0f072b: Implement the 6th order spline (authored by tlatham).
Implement the 6th order spline
Nov 30 2021, 12:14 PM
tlatham committed rLAURAd9d3bc09a5c7: Handle clones properly in LauParameter destructor (authored by tlatham).
Handle clones properly in LauParameter destructor
Nov 30 2021, 12:14 PM
tlatham committed rLAURAabfd1e1da507: Refactor LauDecayTimePdf into several new classes (authored by tlatham).
Refactor LauDecayTimePdf into several new classes
Nov 30 2021, 12:13 PM

Nov 23 2021

tlatham triaged T169: Provide Doxygen for LauRescattering2Res as Normal priority.
Nov 23 2021, 6:26 PM · Laura

Nov 9 2021

tlatham committed rLAURA3a8e8fecea73: Suppress repetitions of some warning messages in LauFlavTag (authored by tlatham).
Suppress repetitions of some warning messages in LauFlavTag
Nov 9 2021, 3:20 PM

Nov 5 2021

tlatham committed rLAURA488ef5ac0df2: Fix problem accidentally introduced trying to fix the previous problem (authored by tlatham).
Fix problem accidentally introduced trying to fix the previous problem
Nov 5 2021, 12:59 PM

Nov 3 2021

tlatham committed rLAURA0f74563debc8: Default to zero prod asym for backgrounds if not specified (authored by tlatham).
Default to zero prod asym for backgrounds if not specified
Nov 3 2021, 5:10 PM
tlatham committed rLAURAceeb2b9eb9eb: Some fixes to generation and fitting of backgrounds (authored by tlatham).
Some fixes to generation and fitting of backgrounds
Nov 3 2021, 3:37 PM
tlatham committed rLAURAc69506336b64: Implement toy generation of decay time for Exp case (authored by tlatham).
Implement toy generation of decay time for Exp case
Nov 3 2021, 3:37 PM
tlatham committed rLAURAaa0f6918dbb3: Allow access to the background DP maximum (authored by tlatham).
Allow access to the background DP maximum
Nov 3 2021, 3:37 PM

Oct 29 2021

tlatham added a revision to T168: Swift-HEP EvtGen thread safety developments: Unknown Object (Differential Revision).
Oct 29 2021, 9:05 PM · Restricted Project
tlatham changed the visibility for T168: Swift-HEP EvtGen thread safety developments.
Oct 29 2021, 9:05 PM · Restricted Project
tlatham moved T168: Swift-HEP EvtGen thread safety developments from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Oct 29 2021, 9:04 PM · Restricted Project

Oct 27 2021

tlatham committed rLAURAb45473d049fe: Fix to background flavour tag generation (authored by tlatham).
Fix to background flavour tag generation
Oct 27 2021, 1:34 PM
tlatham committed rLAURA507f530e6246: Allow generation of flavour-specific backgrounds (authored by tlatham).
Allow generation of flavour-specific backgrounds
Oct 27 2021, 1:12 PM

Oct 5 2021

tlatham committed rEVTGENaa79902f549a: Build HME-patched version of pythia8 in CI (authored by tlatham).
Build HME-patched version of pythia8 in CI
Oct 5 2021, 1:17 PM

Oct 1 2021

tlatham triaged T165: Misleading error message in EvtVVSPwave as Low priority.
Oct 1 2021, 10:25 AM · Restricted Project
tlatham claimed T165: Misleading error message in EvtVVSPwave.
Oct 1 2021, 10:22 AM · Restricted Project

Sep 12 2021

tlatham committed rEVTGENb1563f19b8a4: Make sure version numbers match everywhere (authored by tlatham).
Make sure version numbers match everywhere
Sep 12 2021, 9:13 PM

Sep 8 2021

tlatham committed rLAURA054c1d538abf: Update CI to test future ROOT versions in dev LCG builds (authored by tlatham).
Update CI to test future ROOT versions in dev LCG builds
Sep 8 2021, 12:58 PM

Sep 7 2021

tlatham committed rLAURAc51aaf588216: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Sep 7 2021, 4:57 PM
tlatham committed rLAURAf29d4c7dfa3b: Small changes to gitlab CI script (authored by tlatham).
Small changes to gitlab CI script
Sep 7 2021, 4:57 PM

Jul 1 2021

tlatham committed rLAURA1805f4bcf8d0: Add version of QuasiFlatSqDalitz where particle masses can be supplied on… (authored by tlatham).
Add version of QuasiFlatSqDalitz where particle masses can be supplied on…
Jul 1 2021, 1:46 PM

Jun 28 2021

tlatham committed rLAURAdbdb38d03e8b: Fix for compilation with ROOT 6.24 (authored by tlatham).
Fix for compilation with ROOT 6.24
Jun 28 2021, 5:05 PM

Jun 24 2021

tlatham added a comment to T48: Read currently hard-coded values from data files.

Another option for the data format and parser would be JSON and nlohmann_json as the parser.
While I slightly prefer the look of YAML files, the nlohmann_json parser looks to be more fully featured that either json-cpp or yaml-cpp.
Will look at the various use-cases and see which would work better.

Jun 24 2021, 1:39 PM · Laura

Jun 10 2021

tlatham changed the visibility for D71: Fix B+ --> eta' l nu BF..
Jun 10 2021, 12:20 PM · Restricted Project
tlatham added a comment to D71: Fix B+ --> eta' l nu BF..

For some reason this didn't get automatically closed when you landed the changes. I tried adding the commit to the list of related commits but that didn't do anything either. Is it possible to close it manually?

Jun 10 2021, 12:19 PM · Restricted Project

Jun 9 2021

tlatham added a comment to T141: Review all models to check which could be unified.

As part of this review, should check whether there are adequate protections against invalid settings being passed to these models, e.g. not specifying model number 6 for Bs -> phi mu mu decay modelled with BTOSLLBALL, and implement them if missing.

Jun 9 2021, 5:54 PM · Restricted Project

Jun 8 2021

tlatham accepted D71: Fix B+ --> eta' l nu BF..

Thanks @kreps - the solution for what to do with the excess BF sounds sensible and the actual changes to the numbers all appear to be correctly done.

Jun 8 2021, 12:00 PM · Restricted Project

May 19 2021

tlatham committed rLAURAafb684243f58: Fix couple of issues with background yields and normalisation (authored by tlatham).
Fix couple of issues with background yields and normalisation
May 19 2021, 5:28 PM
tlatham added a comment to T48: Read currently hard-coded values from data files.

Should also take the opportunity to sort out the naming conventions, particularly for the resonances.

May 19 2021, 10:38 AM · Laura

May 18 2021

tlatham changed the visibility for D70: Add new MIPW example (requires a couple of new resonances in LauResonanceMaker).
May 18 2021, 10:26 PM · Laura
tlatham changed the visibility for T147: Add MIPW example based on D-pi+pi+ analysis.
May 18 2021, 10:25 PM · Laura
tlatham closed T147: Add MIPW example based on D-pi+pi+ analysis as Resolved.
May 18 2021, 10:21 PM · Laura
tlatham committed rLAURA6419fcf69b99: Add new MIPW example (requires a couple of new resonances in LauResonanceMaker) (authored by mwhitehe).
Add new MIPW example (requires a couple of new resonances in LauResonanceMaker)
May 18 2021, 10:19 PM
tlatham closed D70: Add new MIPW example (requires a couple of new resonances in LauResonanceMaker).
May 18 2021, 10:19 PM · Laura
tlatham accepted D70: Add new MIPW example (requires a couple of new resonances in LauResonanceMaker).

Thanks Mark, looks good, I'll merge it.

May 18 2021, 10:15 PM · Laura
tlatham requested changes to D70: Add new MIPW example (requires a couple of new resonances in LauResonanceMaker).

Many thanks for putting this together Mark, it's great to have an example that uses the MIPW.
I haven't yet tried running it but will try and do so later on, so these are just from a read through and all quite minor stuff.
(For one I've tried out the new "Suggest edit" feature, so hopefully it will be clear what I mean!)

May 18 2021, 3:25 PM · Laura

May 4 2021

tlatham committed rEVTGENec08fcebd85b: Fix bug in CMake configuration of installation locations (authored by tlatham).
Fix bug in CMake configuration of installation locations
May 4 2021, 4:18 PM
tlatham committed rEVTGEN32010ad19e99: Allow suppression of warnings from external dependencies (authored by tlatham).
Allow suppression of warnings from external dependencies
May 4 2021, 4:05 PM
tlatham updated the test plan for D58: Rename member variables to follow convention of m_ prefix.
May 4 2021, 11:46 AM · Restricted Project

Apr 26 2021

tlatham closed D69: Fix doxygen problems.
Apr 26 2021, 5:45 PM · Laura
tlatham committed rLAURA8e843afe46d7: Fix doxygen problems (authored by tlatham).
Fix doxygen problems
Apr 26 2021, 5:45 PM

Apr 21 2021

tlatham published D69: Fix doxygen problems for review.

This is mainly a fix of Doxygen warnings but I have taken the opportunity to streamline very slightly the arguments to LauKMatrixPropagator::calcGamma, hence the request for review.

Apr 21 2021, 10:34 AM · Laura
tlatham committed rLAURAe0cce8950506: Draft GitLab CI for master branch (authored by tlatham).
Draft GitLab CI for master branch
Apr 21 2021, 10:27 AM
tlatham committed rLAURAa177334bce6e: Small tidy-ups in LauDecayTimePdf (authored by tlatham).
Small tidy-ups in LauDecayTimePdf
Apr 21 2021, 9:24 AM
tlatham committed rLAURA853e7a387fbf: Sort out caching for per-event decay time error (authored by tlatham).
Sort out caching for per-event decay time error
Apr 21 2021, 9:23 AM
tlatham committed rLAURAf582b092ff30: Ensure all knots are passed to Minuit (whether fixed or floated) if any are… (authored by tlatham).
Ensure all knots are passed to Minuit (whether fixed or floated) if any are…
Apr 21 2021, 9:23 AM
tlatham committed rLAURAcce3cae53a69: Fix typo spotted by Mark (authored by tlatham).
Fix typo spotted by Mark
Apr 21 2021, 9:23 AM
tlatham committed rLAURA72c4b374b53a: Large refactoring to avoid lots of duplication (authored by tlatham).
Large refactoring to avoid lots of duplication
Apr 21 2021, 9:23 AM
tlatham committed rLAURA898147ca4681: Get rid of a couple more unnecessary divisions (authored by tlatham).
Get rid of a couple more unnecessary divisions
Apr 21 2021, 9:23 AM
tlatham committed rLAURA66281ca68aa7: Improve the caching - working except for per-event DTR (authored by tlatham).
Improve the caching - working except for per-event DTR
Apr 21 2021, 9:23 AM

Apr 20 2021

tlatham closed T144: EvtGen does not build with Pythia 8.304 as Resolved.
Apr 20 2021, 2:37 PM · Restricted Project
tlatham committed rEVTGENf676c2338a31: Fix compilation with Pythia 8.304 (authored by tlatham).
Fix compilation with Pythia 8.304
Apr 20 2021, 2:36 PM
tlatham added a revision to T144: EvtGen does not build with Pythia 8.304: Unknown Object (Differential Revision).
Apr 20 2021, 2:23 PM · Restricted Project
tlatham triaged T144: EvtGen does not build with Pythia 8.304 as Normal priority.
Apr 20 2021, 2:07 PM · Restricted Project

Apr 16 2021

tlatham committed rLAURA18bc17ba56b6: Fix some warnings from clang10 build (authored by tlatham).
Fix some warnings from clang10 build
Apr 16 2021, 3:14 PM
tlatham committed rLAURA5e5fd78f4946: Fix generation bug for CP-eigenstate case (authored by tlatham).
Fix generation bug for CP-eigenstate case
Apr 16 2021, 3:14 PM

Mar 30 2021

tlatham committed rLAURA6c4fe49ba0d9: Merge branch 'master' into timedep-branch (authored by tlatham).
Merge branch 'master' into timedep-branch
Mar 30 2021, 5:06 PM

Mar 26 2021

tlatham committed rLAURA4684b784bdbd: Fix toggling linear interpolation in Lau1DHistPdf (authored by tlatham).
Fix toggling linear interpolation in Lau1DHistPdf
Mar 26 2021, 3:47 PM
tlatham closed T142: Linear interpolation always enabled for 1D histogram PDFs as Resolved by committing rLAURA4684b784bdbd: Fix toggling linear interpolation in Lau1DHistPdf.
Mar 26 2021, 3:47 PM · Laura
tlatham triaged T142: Linear interpolation always enabled for 1D histogram PDFs as Normal priority.
Mar 26 2021, 3:42 PM · Laura
tlatham claimed T142: Linear interpolation always enabled for 1D histogram PDFs.
Mar 26 2021, 3:39 PM · Laura

Mar 18 2021

tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.
In D58#1640, @kreps wrote:

I think I have it now all, but I ran to another issue with arcanist, which refused to upload diff on a large file without marking it binary. The file is src/EvtGenModels/EvtVubAC.cpp and we might need to change it back from binary when we finish this.

Mar 18 2021, 10:12 AM · Restricted Project