Add EvtD0ToKspipi DP model.
ClosedPublic
Actions

Authored by jback on Jun 3 2024, 2:31 PM.

Details

Reviewers

abudinen
kreps
tlatham

Commits

rEVTGEN4df81c6b805b: Add EvtD0ToKspipi DP model.

Summary

Add EvtD0ToKspipi DP model, courtesy of Camille Normand (LHCb).

Test Plan

Decay model reviewed by LHCb in https://gitlab.cern.ch/lhcb/Gauss/-/merge_requests/1051

Diff Detail

Repository

rEVTGEN evtgen

Branch

R02-02-00-patches

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 313
Build 313: arc lint + arc unit

Event Timeline

jback requested review of this revision.Jun 3 2024, 2:31 PM

jback created this revision.

Harbormaster completed remote builds in B312: Diff 499.Jun 3 2024, 2:31 PM

jback changed the visibility from "All Users" to "Public (No Login Required)".Jun 3 2024, 2:38 PM

jback changed the edit policy from "All Users" to "Restricted Project (Project)".

jback added a project: Restricted Project.

In the context of the thread-safety work, Fernando has been able to make EvtDalitzReso::evaluate a const function. If we were to cherry-pick those changes here we could avoid the copy of each of the EvtDalitzReso instances in EvtD0ToKspipi::calcTotAmp. What do you think?

tlatham added inline comments.Jun 17 2024, 1:44 PM

src/EvtGenModels/EvtD0ToKspipi.cpp
155–161	This makes it a bit more readable I think. If we do include the changes to `EvtDalitzReso` to make the `evaluate` function `const`, the `auto` can become `auto&` to avoid the copy.

Yes, adding the const functions would be good, then we can simplify retrieving the resonances for the total amplitude as suggested. What is the specific git commit I should use?

In D119#3244, @jback wrote:

Yes, adding the const functions would be good, then we can simplify retrieving the resonances for the total amplitude as suggested. What is the specific git commit I should use?

I separated all the Dalitz const related changes in this commit.

https://gitlab.cern.ch/evtgen/evtgen/-/merge_requests/22/diffs?commit_id=c51a5f79ee0e64f0ad65f4020f2f8e62a16c7c1c