Details

Reviewers

kreps
tlatham
jback

Commits

rEVTGEN3827abd45550: Added first working version of interface to Vincia QED for final-state…

Summary

Modified EvtExternalGenList to support new EvtGen-Vincia interface.

Add support for VinciaQED in testing module.

Added EVTGEN_VINCIA flag to switch on only for relevant Pythia versions.

Specify Vincia support for Pythia release 8.313 onwards. Added EvtNoRadCorr to case when Vincia is called but not supported.

This is related with !8 and T250.

Test Plan

FSR tests should produce histograms with FSR photons when using the VinciaQED option.

Diff Detail

Repository

rEVTGEN evtgen

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

abudinen requested review of this revision.Tue, May 6, 4:33 PM

abudinen created this revision.

Harbormaster completed remote builds in B363: Diff 582.Tue, May 6, 4:33 PM

abudinen retitled this revision from Added first working version of interface to Vincia QED for final-state-radiation simulation. to Added first working version of interface to Vincia QED for final-state-radiation simulation.Tue, May 6, 4:34 PM

abudinen changed the visibility from "All Users" to "Public (No Login Required)".

abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".

abudinen added a project: Restricted Project.

abudinen mentioned this in T250: Add new plug-ins for Final-State-Radiation.

Updated History.md

Harbormaster completed remote builds in B364: Diff 583.Tue, May 6, 4:45 PM

Updated History.md

Harbormaster completed remote builds in B365: Diff 584.Tue, May 6, 4:59 PM

A few comments on things I missed when reviewing the gitlab MR. Mostly minor except one bug fix in the CMake.

src/CMakeLists.txt
108	The indentation looks a bit strange here - maybe a tab instead of spaces?
236–238
src/EvtGenExternal/EvtVinciaQED.cpp
110–111	When using smart pointers, you don't need to call `.get()` because they overload the `->` operator. Comment applies in a few other places in this file, e.g. on line 115.
202–211	The indentation is a bit funny in this comment block. I suspect that there are tabs used. Please replace with spaces. This comment applies to a number of places in this file, please check the whole file for tabs and replace accordingly. The clang-format check does not modify comment blocks unfortunately - I'll see if there's something else we can do for the long term.

Should be done now committing.

Fixed bug using wrong compilation flag and fixed indentation.

Harbormaster completed remote builds in B366: Diff 585.Thu, May 22, 6:22 PM

Many thanks @abudinen, looks good to go as far as I'm concerned

This revision is now accepted and ready to land.Thu, May 22, 11:02 PM

Fixed to use member object for Pythia generators.

Harbormaster completed remote builds in B367: Diff 586.Fri, May 23, 7:51 AM

Fixed to use member object for Pythia generators.

Harbormaster completed remote builds in B368: Diff 587.Fri, May 23, 8:14 AM

Closed by commit rEVTGEN3827abd45550: Added first working version of interface to Vincia QED for final-state… (authored by abudinen). · Explain WhyWed, May 28, 5:01 PM

This revision was automatically updated to reflect the committed changes.

abudinen added a commit: rEVTGEN3827abd45550: Added first working version of interface to Vincia QED for final-state….

Added first working version of interface to Vincia QED for final-state-radiation simulation
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 588

EvtGenExternal/EvtExternalGenList.hh

EvtGenExternal/EvtVinciaQED.hh

History.md

src/CMakeLists.txt

src/EvtGenExternal/EvtExternalGenList.cpp

src/EvtGenExternal/EvtVinciaQED.cpp

test/testDecayModel.hh

test/testDecayModel.cc

Added first working version of interface to Vincia QED for final-state-radiation simulationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 588

EvtGenExternal/EvtExternalGenList.hh

EvtGenExternal/EvtVinciaQED.hh

History.md

src/CMakeLists.txt

src/EvtGenExternal/EvtExternalGenList.cpp

src/EvtGenExternal/EvtVinciaQED.cpp

test/testDecayModel.hh

test/testDecayModel.cc

Added first working version of interface to Vincia QED for final-state-radiation simulation
ClosedPublic
Actions

Revision Contents
Changeset List