Page MenuHomeHEPForge

Open Tasks
View All

Needs Triage (7)

Normal (8)

Active Repositories
View All

Recent Activity
View All

Today

tlatham accepted D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.

Looks good to me, many thanks @abudinen! But let's give the others some time to check through again just to be sure.

Wed, May 1, 4:18 PM · Restricted Project
abudinen updated the diff for D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.
  • Moved internal Sherpa configurations for RNG interface into a dedicated cpp file.
Wed, May 1, 4:12 PM · Restricted Project

Yesterday

jr_reuter committed rWHIZARDSVN8922: acc42f8f3 Merge branch 'ufo_mpi_fixes' into 'master'.
acc42f8f3 Merge branch 'ufo_mpi_fixes' into 'master'
Tue, Apr 30, 11:11 PM
abudinen added inline comments to D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.
Tue, Apr 30, 6:16 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Tue, Apr 30, 4:56 PM · Restricted Project

Mon, Apr 29

jr_reuter committed rWHIZARDSVN8921: 3e59e92fe Merge branch 'fix_model_entry_extended_type' into 'master'.
3e59e92fe Merge branch 'fix_model_entry_extended_type' into 'master'
Mon, Apr 29, 8:55 PM
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

@kreps, @jback, @averbyts please let me know if you have any comments

Mon, Apr 29, 4:55 PM · Restricted Project
abudinen accepted D58: Rename member variables to follow convention of m_ prefix.

Thanks for the replies tlatham. I am happy with the implementations of them. Since the results of the tests look, as expected, numerically identical, except for the few cases where the changes are understood (and where the models need anyway fixing), I think that this differential is ready to be landed.

Mon, Apr 29, 3:52 PM · Restricted Project
tlatham created T253: Review and standardise use of integer types.
Mon, Apr 29, 2:42 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

I have run all the tests on master and on the branch with these changes on top.

Mon, Apr 29, 2:36 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.
  • Comments from Fernando
Mon, Apr 29, 2:33 PM · Restricted Project
tlatham added a comment to D58: Rename member variables to follow convention of m_ prefix.

Thanks for the check through @abudinen - I've replied to your comments inline, and will shortly push up the corresponding changes.

Mon, Apr 29, 2:33 PM · Restricted Project

Fri, Apr 26

abudinen added a comment to D58: Rename member variables to follow convention of m_ prefix.

I spotted a few places where we could get rid of commented code and I also have a few questions out of curiosity. Presumably, the output of the tests will be identical with the master branch. In which case, I think that this differential is ready to be landed.

Fri, Apr 26, 6:29 PM · Restricted Project
tlatham updated the summary of D58: Rename member variables to follow convention of m_ prefix.
Fri, Apr 26, 4:42 PM · Restricted Project
tlatham updated the diff for D58: Rename member variables to follow convention of m_ prefix.

Rebase on master branch:

  • Rename member variables to avoid leading underscores
  • Enable shadowing and overloaded-virtual compiler warnings
  • Doxygen fixes
  • Add check of member variable names in CI
Fri, Apr 26, 4:40 PM · Restricted Project

Thu, Apr 25

jr_reuter committed rWHIZARDSVN8920: 07424efda Merge branch 'tho/exotic-color-flows-and-coupling-orders' into….
07424efda Merge branch 'tho/exotic-color-flows-and-coupling-orders' into…
Thu, Apr 25, 2:48 PM

Wed, Apr 24

tlatham closed D117: Drop redundant EVTGEN_CPP11 preprocessor switch.
Wed, Apr 24, 3:56 PM · Restricted Project
tlatham committed rEVTGEN71451a4ee2bd: Drop redundant EVTGEN_CPP11 preprocessor switch (authored by tlatham).
Drop redundant EVTGEN_CPP11 preprocessor switch
Wed, Apr 24, 3:56 PM
abudinen accepted D117: Drop redundant EVTGEN_CPP11 preprocessor switch.

As discussed in !16, this switch was now used only in examples and hence it is fine to remove it.

Wed, Apr 24, 2:52 PM · Restricted Project
abudinen updated the summary of D117: Drop redundant EVTGEN_CPP11 preprocessor switch.
Wed, Apr 24, 2:50 PM · Restricted Project
tlatham added reviewers for D117: Drop redundant EVTGEN_CPP11 preprocessor switch: jback, kreps, abudinen.
Wed, Apr 24, 2:17 PM · Restricted Project
tlatham requested review of D117: Drop redundant EVTGEN_CPP11 preprocessor switch.
Wed, Apr 24, 2:15 PM · Restricted Project

Tue, Apr 23

abudinen closed D116: Replaced PHOTOS with FSR flags in examples and tests..

Closing this revision after the changes have been landed in the commit 71807eba8af5.

Tue, Apr 23, 7:51 PM · Restricted Project
sutt committed rAPPLGRIDSVN2010: circumvent iterator issue.
circumvent iterator issue
Tue, Apr 23, 3:36 PM
sutt committed rAPPLGRIDSVN2009: circumvent iterator issue.
circumvent iterator issue
Tue, Apr 23, 3:35 PM
abudinen committed rEVTGEN71807eba8af5: Replaced PHOTOS with FSR flags in examples and tests. (authored by abudinen).
Replaced PHOTOS with FSR flags in examples and tests.
Tue, Apr 23, 12:31 PM
tlatham accepted D116: Replaced PHOTOS with FSR flags in examples and tests..

Thanks @abudinen, looks good to me

Tue, Apr 23, 11:15 AM · Restricted Project

Mon, Apr 22

abudinen updated the diff for D116: Replaced PHOTOS with FSR flags in examples and tests..
  • Updated History.md
Mon, Apr 22, 5:42 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Mon, Apr 22, 5:38 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Mon, Apr 22, 5:38 PM · Restricted Project
abudinen updated the summary of D116: Replaced PHOTOS with FSR flags in examples and tests..
Mon, Apr 22, 5:38 PM · Restricted Project
abudinen requested review of D116: Replaced PHOTOS with FSR flags in examples and tests..
Mon, Apr 22, 5:36 PM · Restricted Project
abudinen committed rEVTGEN593f5090a830: Simplified pre-processor behaviour for PHOTOS. (authored by abudinen).
Simplified pre-processor behaviour for PHOTOS.
Mon, Apr 22, 5:05 PM
abudinen closed D114: Simplified pre-processor behaviour for PHOTOS..
Mon, Apr 22, 5:05 PM · Restricted Project
tlatham accepted D114: Simplified pre-processor behaviour for PHOTOS..

Many thanks @abudinen, looks great, please go ahead.

Mon, Apr 22, 4:57 PM · Restricted Project
abudinen updated the diff for D114: Simplified pre-processor behaviour for PHOTOS..
  • Removed training space in History.md
Mon, Apr 22, 4:55 PM · Restricted Project

Fri, Apr 19

abudinen added a comment to D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.

I added a few points to consult with Sherpa experts as we discussed.

Fri, Apr 19, 7:48 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Fri, Apr 19, 7:43 PM · Restricted Project
abudinen retitled D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation from Fixed conflict in CMakeLists.txt to Implement Sherpa's PHOTONS++ as alternative for final-state radiation .
Fri, Apr 19, 7:42 PM · Restricted Project
abudinen requested review of D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation.
Fri, Apr 19, 7:40 PM · Restricted Project