Page MenuHomeHEPForge

Open Tasks
View All

Needs Triage (6)

Normal (9)

Active Repositories
View All

Recent Activity
View All

Yesterday

abudinen added a comment to D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation .

I added a few points to consult with Sherpa experts as we discussed.

Fri, Apr 19, 7:48 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Fri, Apr 19, 7:43 PM · Restricted Project
abudinen retitled D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation from Fixed conflict in CMakeLists.txt to Implement Sherpa's PHOTONS++ as alternative for final-state radiation .
Fri, Apr 19, 7:42 PM · Restricted Project
abudinen requested review of D115: Implement Sherpa's PHOTONS++ as alternative for final-state radiation .
Fri, Apr 19, 7:40 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Fri, Apr 19, 12:14 AM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Fri, Apr 19, 12:14 AM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Fri, Apr 19, 12:10 AM · Restricted Project

Wed, Apr 17

abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Wed, Apr 17, 4:42 PM · Restricted Project
abudinen updated the summary of D114: Simplified pre-processor behaviour for PHOTOS..
Wed, Apr 17, 4:41 PM · Restricted Project
abudinen requested review of D114: Simplified pre-processor behaviour for PHOTOS..
Wed, Apr 17, 4:38 PM · Restricted Project

Tue, Apr 16

abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Tue, Apr 16, 7:36 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Tue, Apr 16, 7:36 PM · Restricted Project
abudinen closed D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..
Tue, Apr 16, 3:40 PM · Restricted Project
abudinen committed rEVTGEN4120f59025a0: Use FSR name instead of PHOTOS and deprecate PHOTOS flag. (authored by abudinen).
Use FSR name instead of PHOTOS and deprecate PHOTOS flag.
Tue, Apr 16, 3:40 PM
abudinen added a comment to D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..

Thanks for checking! Ok, will land this differential.

Tue, Apr 16, 3:17 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Tue, Apr 16, 3:07 PM · Restricted Project
tlatham accepted D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..

Great, thanks for checking it over @jback!

Tue, Apr 16, 2:25 PM · Restricted Project
jback accepted D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..

I agree that these changes look OK.

Tue, Apr 16, 2:24 PM · Restricted Project

Mon, Apr 15

abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Mon, Apr 15, 8:13 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Mon, Apr 15, 8:13 PM · Restricted Project
abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Mon, Apr 15, 5:23 PM · Restricted Project
tlatham added a comment to D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..

Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag

Mon, Apr 15, 9:51 AM · Restricted Project

Fri, Apr 12

abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Fri, Apr 12, 4:52 PM · Restricted Project
abudinen updated the summary of D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..
Fri, Apr 12, 4:49 PM · Restricted Project
abudinen requested review of D113: Use FSR name instead of PHOTOS and deprecate PHOTOS flag..
Fri, Apr 12, 4:47 PM · Restricted Project
abudinen committed rEVTGENc048794cbcbd: Merged EvtPhotosEngine into EvtPHOTOS. (authored by abudinen).
Merged EvtPhotosEngine into EvtPHOTOS.
Fri, Apr 12, 3:46 PM
abudinen closed D112: Merged EvtPhotosEngine into EvtPHOTOS..
Fri, Apr 12, 3:46 PM · Restricted Project
tlatham accepted D112: Merged EvtPhotosEngine into EvtPHOTOS..

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.

Fri, Apr 12, 3:22 PM · Restricted Project
abudinen updated the summary of D112: Merged EvtPhotosEngine into EvtPHOTOS..
Fri, Apr 12, 3:08 PM · Restricted Project
abudinen updated the summary of D112: Merged EvtPhotosEngine into EvtPHOTOS..
Fri, Apr 12, 3:08 PM · Restricted Project
abudinen updated the task description for T229: Add json tests for Final-State-Radiators.
Fri, Apr 12, 1:34 PM · Restricted Project
abudinen updated the task description for T229: Add json tests for Final-State-Radiators.
Fri, Apr 12, 1:33 PM · Restricted Project
abudinen updated the task description for T205: Add extra EvtGen decay model tests.
Fri, Apr 12, 1:29 PM · Restricted Project
abudinen updated the summary of D112: Merged EvtPhotosEngine into EvtPHOTOS..
Fri, Apr 12, 1:25 PM · Restricted Project
abudinen updated the diff for D112: Merged EvtPhotosEngine into EvtPHOTOS..
  • Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.
Fri, Apr 12, 1:24 PM · Restricted Project

Thu, Apr 11

abudinen updated the task description for T250: Add new plug-ins for Final-State-Radiation.
Thu, Apr 11, 8:28 PM · Restricted Project
abudinen requested review of D112: Merged EvtPhotosEngine into EvtPHOTOS..
Thu, Apr 11, 8:21 PM · Restricted Project
abudinen triaged T250: Add new plug-ins for Final-State-Radiation as Normal priority.
Thu, Apr 11, 8:19 PM · Restricted Project
abudinen renamed T229: Add json tests for Final-State-Radiators from Add json tests for PHOTOS to Add json tests for Final-State-Radiators.
Thu, Apr 11, 8:10 PM · Restricted Project
abudinen closed T232: Implement const correctness and protection against wrong indices for polarisation vectors as Resolved.

This was solved in D107 and D108.

Thu, Apr 11, 8:06 PM · Restricted Project