Page MenuHomeHEPForge

LauraProject
ActivePublic

Details

Description

Fitting package for performing Dalitz-plot analysis.

Recent Activity

Yesterday

tlatham triaged T256: Investigate use of cppyy for generating python bindings as Low priority.
Thu, Jun 13, 11:02 AM · Laura

Jan 11 2024

tlatham updated subscribers of T213: Refine use of ROOT dictionary generation macros.

The implementation in D101 has caused problems with being able to run the python example GenFit3pi.py because to be able to use our classes in python they need to have dictionaries generated.
As such, I'm going to revert the changes from landing D101 and make new commits that only apply the following parts of those changes:

  • Removal of the deprecated ClassImp macro in all source files
  • The improvements to the CMake modules to avoid using old-style CMake stuff like file-level include_directories, etc.
Jan 11 2024, 12:04 PM · Laura

Dec 7 2023

jback accepted D103: Create and apply clang-format style.

The updated formatting looks good. This is ready to be merged for the new release.

Dec 7 2023, 2:43 PM · Laura
tlatham added a comment to D103: Create and apply clang-format style.

Hi @jback, just a quick note to explain the new changes.

Dec 7 2023, 11:41 AM · Laura
tlatham updated the diff for D103: Create and apply clang-format style.
  • Updates to clang-format style for clang 16
  • Modify clang-format style to 4-space indentation
  • Fix missing newline in README
  • Scripts to fix indentation of Doxygen comment blocks
  • Further improve formatting style
  • Re-apply formatting to source files
Dec 7 2023, 11:29 AM · Laura

Nov 24 2023

jback accepted D103: Create and apply clang-format style.

Formatting and CI check look OK.

Nov 24 2023, 4:32 PM · Laura

Nov 22 2023

tlatham closed D105: Allow increase of C++ standard via environment variable.
Nov 22 2023, 1:43 PM · Laura
jback accepted D105: Allow increase of C++ standard via environment variable.

Yes, this is OK.

Nov 22 2023, 12:46 PM · Laura

Nov 21 2023

tlatham updated the diff for D103: Create and apply clang-format style.
  • Apply formatting in v3-patches branch
Nov 21 2023, 10:47 PM · Laura
tlatham added a comment to D105: Allow increase of C++ standard via environment variable.

@jback, does this look ok? It's the same as the code we now have in #evtgen.

Nov 21 2023, 10:46 PM · Laura

Nov 20 2023

tlatham updated the diff for D105: Allow increase of C++ standard via environment variable.
  • Add warning if requested C++ standard is too old
Nov 20 2023, 4:58 PM · Laura

Nov 16 2023

tlatham closed T227: Provide simple interface to 2D DP likelihood in fit models as Resolved by committing rLAURA67c88df3b45a: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:45 PM · Laura
tlatham closed D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:45 PM · Laura
tlatham changed the visibility for D105: Allow increase of C++ standard via environment variable.
Nov 16 2023, 5:40 PM · Laura
tlatham added a comment to D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.

Thanks John!

Nov 16 2023, 5:39 PM · Laura
tlatham changed the visibility for D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 16 2023, 5:37 PM · Laura

Nov 15 2023

tlatham added a revision to T227: Provide simple interface to 2D DP likelihood in fit models: D104: Add functions to fit models to return DP likelihood(s) and signal DP amplitudes.
Nov 15 2023, 12:46 PM · Laura

Nov 7 2023

jback added a comment to D103: Create and apply clang-format style.

Clang formatting and CI check looks OK, so proceed with organising the appropriate branches.

Nov 7 2023, 6:27 PM · Laura
tlatham added a comment to D103: Create and apply clang-format style.

It looks like it is going to be a nightmare to merge timedep-branch into master if we apply this formatting first (even after applying the same formatting there first).
So what I'd propose is to merge the last actual code changes into master - will create the differential for that shortly - then create a new v3-patches branch, to which this formatting can then be applied, and release v3r6 from that branch. This Differential can be updated to accomplish that part.
The formatting can then be applied to master after merging in timedep-branch - will require a separate Differential at a later date.
Does that sound reasonable?

Nov 7 2023, 3:33 PM · Laura

Nov 6 2023

tlatham added a comment to T213: Refine use of ROOT dictionary generation macros.

Thanks to D101, this is now in master but needs to also be propagated to the time-dependent branch, so not yet closing this.

Nov 6 2023, 6:13 PM · Laura
tlatham closed D101: Improve use of ROOT dictionary generation macros.

Closed by rLAURA9dffea19ce7b
(not sure why this didn't happen automatically)

Nov 6 2023, 6:12 PM · Laura
tlatham added a comment to D103: Create and apply clang-format style.

In parallel I need to check what happens if I apply the same formatting in the timedep branch and then try and merge the branches! If that doesn’t go so well we might have to postpone this change untill after merging timedep into master.

Nov 6 2023, 6:03 PM · Laura
tlatham added a comment to D103: Create and apply clang-format style.

Since this is purely formatting changes, I think the main thing to review is that the formatting style looks reasonable and that the CI check looks ok. Up to you if you want to look through all the files!!

Nov 6 2023, 5:58 PM · Laura
tlatham changed the visibility for D103: Create and apply clang-format style.
Nov 6 2023, 5:48 PM · Laura
tlatham added a revision to T111: Create clang-format style config file: D103: Create and apply clang-format style.
Nov 6 2023, 5:47 PM · Laura
tlatham updated the diff for D101: Improve use of ROOT dictionary generation macros.

Remove unused member variable from LauKMatrixPropagator

Nov 6 2023, 5:30 PM · Laura
tlatham added inline comments to D101: Improve use of ROOT dictionary generation macros.
Nov 6 2023, 5:23 PM · Laura
jback added inline comments to D101: Improve use of ROOT dictionary generation macros.
Nov 6 2023, 4:51 PM · Laura
tlatham added a comment to D101: Improve use of ROOT dictionary generation macros.

Many thanks for checking through this. I’ve reply to your K-matrix related question inline.

Nov 6 2023, 4:15 PM · Laura
jback accepted D101: Improve use of ROOT dictionary generation macros.

All of the changes look OK. Just have a query about some K-matrix code that is commented out. Otherwise this can be merged.

Nov 6 2023, 3:46 PM · Laura

Oct 17 2023

tlatham added a comment to D101: Improve use of ROOT dictionary generation macros.

@jback - just to provide you with a bit more context. This is the first of three Differentials that I would like to get merged before releasing v3r6 from the master branch:

  • This one, which addresses T213, solving an issue with and generally improving the ROOT dictionary generation
  • One that will address T111 by creating a clang-format style file, applying it to the code, and adding a corresponding CI check
  • One that will address T227 by creating new functions in the fit models to access the amplitude and likelihood as a function of the DP position
Oct 17 2023, 2:55 PM · Laura

Oct 16 2023

tlatham updated the diff for D101: Improve use of ROOT dictionary generation macros.

Fix typo in release notes

Oct 16 2023, 5:15 PM · Laura
tlatham changed the visibility for D101: Improve use of ROOT dictionary generation macros.
Oct 16 2023, 5:09 PM · Laura

Aug 11 2023

tlatham triaged T227: Provide simple interface to 2D DP likelihood in fit models as High priority.
Aug 11 2023, 10:04 AM · Laura

Jun 28 2023

tlatham closed T45: Toy generation with constraints should follow guidelines in arXiv:1210.7141 as Resolved by committing rLAURA6bf46391f311: Fix behaviour when fitting toy experiments with a model containing constraints.
Jun 28 2023, 5:39 PM · Laura

Jun 26 2023

tlatham added a revision to T45: Toy generation with constraints should follow guidelines in arXiv:1210.7141: Restricted Differential Revision.
Jun 26 2023, 5:09 PM · Laura
mwhitehe triaged T220: Track number of WARNINGs as Wishlist priority.
Jun 26 2023, 10:38 AM · Laura

Jun 21 2023

tlatham updated the task description for T45: Toy generation with constraints should follow guidelines in arXiv:1210.7141.
Jun 21 2023, 2:30 PM · Laura

Jun 9 2023

tlatham closed T214: Multi-dimensional Gaussian constraints as Resolved by committing rLAURAcf97b1614ff9: Implementation of n-dimensional Gaussian constraints.
Jun 9 2023, 5:48 PM · Laura
tlatham closed D93: Implementation of n-dimensional Gaussian constraints.
Jun 9 2023, 5:48 PM · Laura
tlatham accepted D93: Implementation of n-dimensional Gaussian constraints.
Jun 9 2023, 5:39 PM · Laura
tlatham retitled D93: Implementation of n-dimensional Gaussian constraints from First draft of n-dimensional Gaussian constraints to Implementation of n-dimensional Gaussian constraints.
Jun 9 2023, 5:38 PM · Laura
mwhitehe updated the diff for D93: Implementation of n-dimensional Gaussian constraints.
  • Further tweaks and added release notes, example usage removed from GenFitDpipi
Jun 9 2023, 5:32 PM · Laura
tlatham added a comment to D93: Implementation of n-dimensional Gaussian constraints.

Please also add an entry in the release notes, which should reference either this Differential revision or the corresponding Maniphest task

Jun 9 2023, 12:00 PM · Laura
tlatham added a comment to D93: Implementation of n-dimensional Gaussian constraints.

Just a few trivial tidy-ups

Jun 9 2023, 11:12 AM · Laura

Jun 8 2023

mwhitehe updated the diff for D93: Implementation of n-dimensional Gaussian constraints.
  • Missed one issue
Jun 8 2023, 3:29 PM · Laura
mwhitehe updated the diff for D93: Implementation of n-dimensional Gaussian constraints.
  • Address review comments
Jun 8 2023, 3:20 PM · Laura
tlatham requested changes to D93: Implementation of n-dimensional Gaussian constraints.

Many thanks Mark, this looks great. Just a few small suggestions here and there.

Jun 8 2023, 1:37 PM · Laura
mwhitehe updated the diff for D93: Implementation of n-dimensional Gaussian constraints.
  • Add documentation and fix a bug from loop updates
Jun 8 2023, 12:29 PM · Laura
mwhitehe updated the diff for D93: Implementation of n-dimensional Gaussian constraints.
  • Updates to move some functionality to LauFitObject
  • Update code after move to LauFitObject and extend to LauSimFitCoordinator
Jun 8 2023, 12:20 PM · Laura