Page MenuHomeHEPForge

LauraProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

Fitting package for performing Dalitz-plot analysis.

Recent Activity

Yesterday

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Use default values at declaration in LauAbsResonance to significantly simplify the constructors
Thu, Jan 21, 12:54 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Cleanup LauAbsResonance constructor which involved a lot of duplication for K-matrix
Thu, Jan 21, 12:51 PM · Laura
johndan added inline comments to D41: Implementation of higher-spin K-matrix.
Thu, Jan 21, 12:41 PM · Laura

Fri, Jan 15

jback added inline comments to D39: Allow floating of parameters in the k-matrix.
Fri, Jan 15, 6:10 PM · Laura
jback added inline comments to D41: Implementation of higher-spin K-matrix.
Fri, Jan 15, 6:00 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Remove duplicate par_mSq0_
Fri, Jan 15, 3:04 PM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thanks, @jback. A few answers to your responses, with just one that doesn't (yet) make sense to me...

Fri, Jan 15, 11:46 AM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Add K-matrix name to gCoupling parameters to avoid clashes in models with >1 K-matrix
  • Resolve merge conflict
  • Allow other parameters of the SVP part to be floated
  • Fix merge conflict
Fri, Jan 15, 11:21 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Remove whitespace at end of file
  • Fix compilation errors
Fri, Jan 15, 11:19 AM · Laura
johndan added a comment to D39: Allow floating of parameters in the k-matrix.

I think only 1 parameter needed a changed name - @jback let me know if I missed something here though.

Fri, Jan 15, 11:03 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Allow other parameters of the SVP part to be floated
Fri, Jan 15, 11:02 AM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add K-matrix name to gCoupling parameters to avoid clashes in models with >1 K-matrix
Fri, Jan 15, 10:52 AM · Laura

Thu, Jan 14

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correctly initialise a_ vector. Remove calculation of angular factor from K-matrix propagator. Remove any need to update the propagator with the LauKinematics object
  • Remove angular parts of K-matrix header, and add extra function to indicate the final-state channel of the various coupled channels
  • Update ProdPole and SVP to use resAmp (and leave amplitude to LauAbsResonance)
  • Update LauAbsResonance to apply spin to constructed objects that don't use the 'normal' constructor
  • Changes to LauResonanceMaker to allow retrieval of parent Blatt-Weisskopf factor without using resInfo that is not defined for K-matrix
  • Changes to LauBlattWeisskopfFactor to accommodate tangential use by K-matrix to get parent factor without access to a resInfo
Thu, Jan 14, 8:05 PM · Laura

Tue, Jan 12

jback added inline comments to D41: Implementation of higher-spin K-matrix.
Tue, Jan 12, 5:40 PM · Laura

Mon, Jan 11

johndan added a comment to D41: Implementation of higher-spin K-matrix.

I've included the changes to tell the K-matrix about the orbital angular momentum of each channel, as discussed on Mattermost. I've also made 3 comments in the code for you, @jback. Thanks!

Mon, Jan 11, 8:24 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Changes to allow different orbital angular momenta for different channels inside the K-matrix
Mon, Jan 11, 8:13 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Changes to allow different orbital angular momenta for different channels inside the K-matrix
Mon, Jan 11, 8:13 PM · Laura
jback requested changes to D41: Implementation of higher-spin K-matrix.

From further discussion elsewhere, it looks like the code needs further edits to allow channel-dependent L values (for a given total angular momentum J).

Mon, Jan 11, 6:55 PM · Laura
jback requested changes to D39: Allow floating of parameters in the k-matrix.

Need to apply an upper bound = 0 for s_0^scatt if this is allowed to float. Some parameters still need "names" added, as per Tom's suggestion.

Mon, Jan 11, 2:59 PM · Laura
jback accepted D41: Implementation of higher-spin K-matrix.
Mon, Jan 11, 2:22 PM · Laura

Fri, Jan 8

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Remove done TODO comment and make const several function arguments
  • Add function to LauKMatrixPropagator that returns K-matrix spin, and make various function arguments const
  • Add barrier factors to numerator of K-matrix amplitude in ProdPole and ProdSVP, which need to know the spin of the K-matrix using the new getL() function
  • Fix typo in ProdPole.cc and ProdSVP.cc
Fri, Jan 8, 9:04 PM · Laura

Thu, Jan 7

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correct displaced doxygen comment
  • Simplify setting of denominator parameter in barrier factor from file
  • Cache the a/R^2 calculation - thanks John!
  • Neater access to D*0 mass information from LauResonanceMaker - thanks Tom!
  • Add definition of angular momentum term for spin-2 (max spin) to K-matrix
Thu, Jan 7, 1:07 PM · Laura
johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • Correct displaced doxygen comment
  • Simplify setting of denominator parameter in barrier factor from file
  • Cache the a/R^2 calculation - thanks John!
  • Neater access to D*0 mass information from LauResonanceMaker - thanks Tom!
  • Add definition of angular momentum term for spin-2 (max spin) to K-matrix
Thu, Jan 7, 1:07 PM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thanks @jback and @tlatham, I've handled all the remaining comments. There are some deeper issues to resolve (see the Laura++ mattermost channel) before we land this. D39 needs to come first, anyway, and that one is ready to go.

Thu, Jan 7, 1:04 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Correct Doxygen comments
Thu, Jan 7, 10:23 AM · Laura
johndan requested review of D39: Allow floating of parameters in the k-matrix.
Thu, Jan 7, 10:20 AM · Laura

Wed, Jan 6

tlatham added inline comments to D41: Implementation of higher-spin K-matrix.
Wed, Jan 6, 4:55 PM · Laura
tlatham added a comment to D41: Implementation of higher-spin K-matrix.
In D41#1074, @johndan wrote:

General question, @tlatham : should I cherry-pick commits to bring this differential in line with the master (e.g. c38fa2a34f4a772754d1e8f610def10747d95104 - LauFormulaPar fix)?

Wed, Jan 6, 4:43 PM · Laura
jback requested changes to D41: Implementation of higher-spin K-matrix.

Thanks @johndan, the changes you have made so far look good and makes the code more general. I have replied to your questions, and have also suggested that we calculate the barrier radii-squared terms at initialisation. Not sure what we can do for avoiding hard-coding the D* mass at initialisation (regarding access to LauResonanceMaker info).

Wed, Jan 6, 4:09 PM · Laura

Tue, Jan 5

johndan updated the diff for D41: Implementation of higher-spin K-matrix.
  • D*K system should be in P-wave, not just D0K !
  • Changes after round of code-review with @jback
  • Remove whitespace and make minor bugfixes found during compilation tests
Tue, Jan 5, 3:22 PM · Laura
johndan added a comment to D41: Implementation of higher-spin K-matrix.

Thank you for the comments @jback . I've implemented them in most cases, or left a reply in the few where further input from you is needed.

Tue, Jan 5, 3:21 PM · Laura

Dec 18 2020

jback added inline comments to D41: Implementation of higher-spin K-matrix.
Dec 18 2020, 1:56 AM · Laura

Dec 17 2020

jback requested changes to D41: Implementation of higher-spin K-matrix.

I've had a first look at the code and have provided some suggestions for changes that I think are needed.

Dec 17 2020, 10:42 PM · Laura
jback requested changes to D39: Allow floating of parameters in the k-matrix.
Dec 17 2020, 8:36 PM · Laura

Dec 16 2020

johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add K-matrix name to parameter names, to allow multiple K-M's per model
Dec 16 2020, 4:23 PM · Laura
johndan added inline comments to D39: Allow floating of parameters in the k-matrix.
Dec 16 2020, 4:23 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add braces for Tom
  • Allow pole mass-squared to vary
Dec 16 2020, 3:37 PM · Laura
johndan updated the diff for D39: Allow floating of parameters in the k-matrix.
  • Add doxygen lines for one function
Dec 16 2020, 2:42 PM · Laura
tlatham added a commit to T122: Use boost::program_options for executables: rLAURA321ca8e0fe0f: Start to Use Boost ProgramOptions for examples.
Dec 16 2020, 2:36 PM · Laura
tlatham changed the visibility for T122: Use boost::program_options for executables.
Dec 16 2020, 2:35 PM · Laura

Dec 10 2020

tlatham closed T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1 as Resolved.
Dec 10 2020, 5:34 PM · Laura
tlatham closed D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 10 2020, 5:32 PM · Laura
tlatham requested changes to D39: Allow floating of parameters in the k-matrix.

Thanks very much for this @johndan. It looks good.
I think it would just be good to take the opportunity while we're at it to allow any of the parameters to float.
We should also include the name of the propagator in the name of the parameters so that if we have more than one K-matrix in a given fit we don't get identically named parameters appearing - this will cause problems with the sim-fit for example.
See the inline comments for details.

Dec 10 2020, 5:30 PM · Laura
johndan accepted D42: Fix LauFormulaPar to follow change in behaviour of TFormula.

I tested the patch and it does the job.

Dec 10 2020, 5:17 PM · Laura

Dec 3 2020

tlatham updated the diff for D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
  • Update release notes
Dec 3 2020, 10:39 AM · Laura
mwhitehe accepted D42: Fix LauFormulaPar to follow change in behaviour of TFormula.

Looks good to me

Dec 3 2020, 9:40 AM · Laura

Dec 2 2020

tlatham changed the visibility for D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 2 2020, 5:38 PM · Laura
tlatham added a revision to T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1: D42: Fix LauFormulaPar to follow change in behaviour of TFormula.
Dec 2 2020, 5:36 PM · Laura
tlatham triaged T129: LauFormulaPar gives spurious error about dimension being 0 rather than 1 as Normal priority.
Dec 2 2020, 5:30 PM · Laura
tlatham closed T128: Issue with fit range of slope of exponential NR model as Resolved.
Dec 2 2020, 1:42 PM · Laura