Many thanks! Good to go as far as I'm concerned.

Thanks for checking. I updated/added copyright. Description in argparser was leftover from copy&paste, I updated it to correct description. D80 is in history.

• Update year in copyright

• Update copyright in the scripts together with some small cleanup.

If you could also add to the History.md an entry for D80 that would be great, I completely forgot to do that before landing it just now!

Thanks for the clarification about the BF values chosen, Michal. I agree that all of the changes are OK. I will accept this revision after we finalise any required copyright/documentation changes to the scripts according to Tom's suggestions.

I'm not an expert on cmake but all of the changes look OK and we can add more checks/features as time goes on. Let us go ahead and add this to the repository.

Hi @jback, many thanks for checking this.
Certainly we should make sure that this is correct in the paper draft.
Once the paper is out we can take down the old guide and replace it with a copy of the paper or a link to the paper on arXiv.
But in the meantime, I think it is probably best also to correct the latex for the guide and perhaps put a new pdf on the webpage.

Thanks for these changes @kreps.
I have checked the consistency of the changes between B0 and B0bar and between the DEC and XML files and that all looks fine.
I also gave the two new scripts a quick try and they seem to work as advertised.
They are, however, missing the copyright section at the top. Ideally that section should also be updated to 2022 in the convertDecayFile.py script, then it can be copied into the two new files.
What does "Guide mark calculation" mean in ArgumentParser description in the two new scripts? Could these be made a bit more descriptive?

Rebased on master

John, thanks for looking to this. The psi(2S) and eta_c modes are upped little bit (by about 1 sigma) in order to balance things up so that sum of all BFs is 1. From the same reason some of the pythia modes are increased.

Thanks for these changes, Michal. Just to double-check, the PDG webpage has the following BFs for the psi(2S) and eta_c modes: 5.8e-4 and 8.0e-4. Do we need to use different values (6.2e-4 and 9.0e-4) to balance things owing to the pythia hadronisation modes? The pythia modes also have slightly larger BFs than before.

Yes, the default lambda1 parameter quoted in the documentation should be -0.3, as given by Eq 39 (not Eq 24) on page 24 of https://arxiv.org/pdf/hep-ph/9805303.pdf . The BTOXSGAMMA model description in the guide has various other grammar problems that also need correcting. We could update the latex for the guide in the repository, or put the correct info in the paper draft (or do both).

Thanks Michal.
The config file is mostly just the default values with the only customisation coming in the first 5 lines:

• line 1 to run only the modernize-use-nullptr check
• line 3 to ensure that it warns about things in our header files
• line 5 so that it uses our .clang-format file for reformatting after any auto-applied changes

I have no doubt that the existing code will need cleaning up as we enable more checks. This is why I say "eventually" about having this run automatically, otherwise we'll just be swamped with warnings. A point for subsequent discussion will be what checks we want to use and in what order to start to gradually enable them and fix stuff as we go. I'll create a task where we can have such a discussion.

Looks good to me, but of coarse I did not check full details of clang-tidy configuration file. I suspect we might need to cleanup existing code as well as we turn on more checks.