In D131#3578, @jback wrote:

Yes, this ready to be merged, assuming that a check has been made to make sure that all of the histogram tests produce something sensible, i.e. they produce non-zero histograms and all of the entries are inside the bin ranges etc.

@tlatham, @jback, @kreps can we land this?

• Updated History.md

As shown in !32, I checked myself that these changes fix the bug. So therefore I am approving.

• Updated History.md

These changes were developed together with @kreps and @tlatham. So we leave to @jback to do the review.

• Updated History.

Closing by hand as it did not happen automatically after landing .

Ok, waiting for @jback or @kreps approval.

• Applied wording comments for History.

• Resolved conflicts in History.

• Removed trailing space.

• Updated History.

• Updated History.

• Updated History

In D119#3244, @jback wrote:

Yes, adding the const functions would be good, then we can simplify retrieving the resonances for the total amplitude as suggested. What is the specific git commit I should use?

• Reverted obsolete testing .json file sufixes.
• Added entries into history and readme files.
• Updated reference web sited for Photos and Tauola in readme file.

• Find Sherpa version and use it to control use of DECLARE_GETTER macro
• Implemented support for fsrGenerator as argument for testing file. Implemented modification of output and ref files if FSR is on.
• Implemented Tom's comments

• Fix problem with GCC13 compilation of EvtSherpaRandom

• Add option for saving GCC temporary files (commented out for now)
• Fix problem with GCC13 compilation of EvtSherpaRandom

• Moved internal Sherpa configurations for RNG interface into a dedicated cpp file.
• Adapt setupEvtGen.sh to new Photos and Tauola URLs
• Update CI and Doxygen configs to include Sherpa
• Disable Sherpa in HepMC2 build
• Implemented comments by John.

• Moved internal Sherpa configurations for RNG interface into a dedicated cpp file.

Thanks for the replies tlatham. I am happy with the implementations of them. Since the results of the tests look, as expected, numerically identical, except for the few cases where the changes are understood (and where the models need anyway fixing), I think that this differential is ready to be landed.

I spotted a few places where we could get rid of commented code and I also have a few questions out of curiosity. Presumably, the output of the tests will be identical with the master branch. In which case, I think that this differential is ready to be landed.

As discussed in !16, this old switch was currently still used only in examples and hence it is fine to remove it.

Closing this revision after the changes have been landed in the commit 71807eba8af5.

• Updated History.md

• Removed training space in History.md

I added a few points to consult with Sherpa experts as we discussed.