As discussed in !16, this switch was now used only in examples and hence it is fine to remove it.

Closing this revision after the changes have been landed in the commit 71807eba8af5.

• Updated History.md

• Removed training space in History.md

I added a few points to consult with Sherpa experts as we discussed.

Thanks for checking! Ok, will land this differential.

• Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.

This was solved in D107 and D108.

The changes look good to me.

I have search for each removed model and class via grep in the MR branch and found entries only in the history and release-note files. Therefore, I think that an explicit mention of the removed models and classes in the history file might be useful. I also checked whether the deleted models are used at Belle II or LHCb and it seems they are not using them. I remember that @kreps mentioned that PROPSLPOLE is used at LHCb, but I did not find any decay file in the DecFiles project.

Rebased master with check fix.

The changes look good to me. Ok, understood that this is just avoiding to use an user defined CMAKE_CXX_STANDARD if it is lower than our standard.

This looks good to me. I only have a few minor comments, which you find below.

In D99#2612, @tlatham wrote:

Thanks for this @abudinen. Do we want to add some cases for hadronic final states?

• Updated FSR testing scripts: removed empty histograms, improved binning.

All changes look plausible to me.

• Avoid printout at every step in the scan to find probmax. Print info only at the end of the scan.

• Changed names of some variables to make it consistent with model name.

I also checked that the numbers are consistent with the ones from the presentation. It might be a good idea to add a comment in the code that the amplitude magnitudes are obtained from the mentioned BaBar paper but corrected for normalisation.

• Updated History file.

I checked the test plots together with Tom. They look fine. There are slight differences before/after the changes in some plots for inclusive B decays, which I presume might be due to changes in Pythia itself. However, the results before/after are statistically compatible. As for exclusive decays, the comparison before/after the changes shows no differences at all.

Bugfix landed on master branch.
https://phab.hepforge.org/rEVTGENd2fecc75bda853f5d03cc3eb5acbadc02cafee0f

Added previous commits.

• Added entry in History.md

In D92#2359, @tlatham wrote:

Looks good, thanks @abudinen.

Have you checked the histograms for the 3 test cases for this model? Everything is unchanged (apart from the prob, presumably)?

Could you also add an entry to the History.md file? It should reference this Differential revision.

Just to link here the GitLab issue for EvtSSD_DirectCP