All looks good, I'll get this landed ASAP
Serialisation to JSON of LauParameter and LauFormulaPar
Small fix to documentation of LauAbsCoeffSet
Read/write LauVetoes from/to JSON
Modify some examples to read/write models from/to JSON
Add a utility method to load all coefficients at once
Fix issue in coeffset cloning
Add method to fit model classes to retrieve coefficients
Make LauAbsCoeffSet::writeToJson more general wrt the input collection
Add file missing from previous commit
Implement writing of DP model to JSON file
Fix bug in deserialisation of LauNSCCartesianCPCoeffSet from JSON
Two files don't seem to be modified that I believe should be:
Reimplement the D* vetoes
Suppress spurious errors from LauResonanceMaker
Add LauIsobarDynamics::constructModelFromJson function to load model from JSON…
Workaround for JSON oddity
Rename and update TD Dpipi example to include recent changes
Update coeffset classes to use new JSON tools
Factorise out common JSON operations into new namespace
Use constrained yields in Run 1 KK by default
Update Lau1DCubicSpline to use new JSON tools
Tidy-ups and improve comments
Improve reading of coeff sets from JSON
Improve serialisation to JSON
Use unique_ptr for handling of coeff sets
Handle cloned coefficient sets in JSON serialisation
Implement preliminary json serialisation of CoeffSet classes
Provide option to allow fixed yields to be sent to fitter
Fix bug in previous commit
Minor change to likelihood debug printout
allow the toggling of Run 1 KK yields to be with/without the negative components
Clean-up histo smoothing, check for krb ticket, and temporarily disable test…
Update Test_Dpipi to load all histograms and data file from EOS, and update DP…
Introduce option (for systematics) to add yields of neglected components to the…
LauGounarisSakuraiRes: add option to disable BW scaling of Gamma(m)
Making json file, fix first knot in signalMC ratios
Improve likelihood etc. printouts for bad events
Add Covariant_P option to spin formalisms
Implement diagnostic printout of likelihood values in LauTimeDepFitModel
Allow knots to be fixed when fitting splines to TH1s
Make optional the termination of event loop on finding an event with bad…
Add framework for printing per-event likelihood info for funny events
allow Run 1 and Run 2 as options
Small fix to blinding of mixing phase
add flavour-split flavour-specific backgrounds, don't let unblinded fits happen
Setup blinding for mixing phase parameters
Add cmd-line arg to specify backgrounds to use in Test_Dpipi
Fix combinatorial normalisation for CP-eigenstate modes
Improve fit result ntuple naming
Apply yield naming convention to other fit models
Add option to gen mB distributions and float yields
Fix for allowing yields of 0 without crashing
Allow easier generation of sig-only toys
Update to 3 simfit tasks and fix DP parameters
Add per-event timing info for generating each category
New branch to run first full toy tests
Somehow I screwed up landing this and it hasn't automatically closed this revision. The changes are in , however, so this can be closed manually.
Applied clang-tidy modernize-use-nullptr
Many thanks John, this looks good.
Tests look good. Once those three extra changes are done it can be merged.
Print out number of test to run.
Modify VSS_BMIX test to use 2 children
Fix access to optional JSON fields
Improve json checker wrt TAUOLA and VSS_BMIX quirks
Fix another shadowing issue in TestDecayModel
Fix shadowing issue in TestDecayModel
Implement checks of code formatting and json test files
Added more tests for TAUOLA (external).
Provide CONTRIBUTING documention
Just 3 cases missed due to an .
Otherwise I think it's looking good.
I'll try and run all the tests on it in the next few days to make completely certain, then this can be landed.
Many thanks, this looks good. The only thing is that the source files in haven't been modified. Can you build with ?
Update documentation of arc land
Use Minuit to automatically determine ASq max for signal in LauIsobarDynamics
Thanks for checking it through John.
tlatham retitled
D58: Rename member variables to follow convention of m_ prefix from
Rename member variables to follow convention of `m_` prefix to
Rename member variables to follow convention of m_ prefix.
tlatham retitled
D58: Rename member variables to follow convention of m_ prefix from
Started to rename member variables to avoid leading underscores to
Rename member variables to follow convention of `m_` prefix.