Page MenuHomeHEPForge
Differential D112

Merged EvtPhotosEngine into EvtPHOTOS.
ClosedPublic
Actions

Authored by abudinen on Apr 11 2024, 8:21 PM.

Details

Reviewers
jback
tlatham
kreps
Commits
rEVTGENc048794cbcbd: Merged EvtPhotosEngine into EvtPHOTOS.
Summary

Removes the EvtPhotosEngine and moves its functionality to the EvtPHOTOS class.

It closes !10 and #10,
and is part of T250.

Added knobs for infrared cutoff and interference weight of PHOTOS. Explicitly switch off pair emission inside PHOTOS.

Added EVTGEN_PHOTOS_NEWLIBS flag to src/CMakeLists.txt to identify PHOTOS version needed to switch off pair emission.

Moved initialisation of _fsrEngine to setRadCorrEngine.

Mutexed PHOTOS as introduced by Heather Ratcliffe.

Test Plan

Run tests for FSR in this branch and compare with master.

Diff Detail

Repository
rEVTGEN evtgen
Branch
10-merge-photos-engine
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 292
Build 292: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Apr 11 2024, 8:21 PM
abudinen created this revision.
Harbormaster completed remote builds in B291: Diff 468.Apr 11 2024, 8:21 PM
abudinen mentioned this in T250: Add new plug-ins for Final-State-Radiation.Apr 11 2024, 8:28 PM
abudinen updated this revision to Diff 469.Apr 12 2024, 1:24 PM
  • Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.
Harbormaster completed remote builds in B292: Diff 469.Apr 12 2024, 1:24 PM
abudinen edited the summary of this revision. (Show Details)Apr 12 2024, 1:25 PM
abudinen edited the summary of this revision. (Show Details)Apr 12 2024, 3:08 PM
abudinen edited the summary of this revision. (Show Details)
abudinen changed the visibility from "All Users" to "Public (No Login Required)".
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.
tlatham accepted this revision.Apr 12 2024, 3:22 PM

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.

This revision is now accepted and ready to land.Apr 12 2024, 3:22 PM
Closed by commit rEVTGENc048794cbcbd: Merged EvtPhotosEngine into EvtPHOTOS. (authored by abudinen). · Explain WhyApr 12 2024, 3:46 PM
This revision was automatically updated to reflect the committed changes.
abudinen added a commit: rEVTGENc048794cbcbd: Merged EvtPhotosEngine into EvtPHOTOS..
abudinen mentioned this in D58: Rename member variables to follow convention of m_ prefix.May 2 2024, 8:29 PM

Revision Contents
Changeset List

PathSize
EvtGenBase/
1 line
EvtGenExternal/
3 lines
6 lines
51 lines
EvtGenModels/
2 lines
4 lines
src/
7 lines
EvtGenBase/
4 lines
EvtGenExternal/
23 lines
14 lines
307 lines

Diff 469

View Options

EvtGenBase/EvtAbsRadCorr.hh

Loading...
View Options

EvtGenExternal/EvtExternalGenFactory.hh

Loading...
View Options

EvtGenExternal/EvtExternalGenList.hh

Loading...
View Options

EvtGenExternal/EvtPHOTOS.hh

Loading...
View Options

EvtGenExternal/EvtPhotosEngine.hh

Loading...
View Options

EvtGenModels/EvtNoRadCorr.hh

Loading...
View Options

History.md

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/EvtGenBase/EvtRadCorr.cpp

Loading...
View Options

src/EvtGenExternal/EvtExternalGenFactory.cpp

Loading...
View Options

src/EvtGenExternal/EvtExternalGenList.cpp

Loading...
View Options

src/EvtGenExternal/EvtPHOTOS.cpp

Loading...
View Options

src/EvtGenExternal/EvtPhotosEngine.cpp

Loading...