Page MenuHomeHEPForge

Merged EvtPhotosEngine into EvtPHOTOS.
ClosedPublic

Authored by abudinen on Apr 11 2024, 8:21 PM.

Details

Summary

Removes the EvtPhotosEngine and moves its functionality to the EvtPHOTOS class.

It closes !10 and #10,
and is part of T250.

Added knobs for infrared cutoff and interference weight of PHOTOS. Explicitly switch off pair emission inside PHOTOS.

Added EVTGEN_PHOTOS_NEWLIBS flag to src/CMakeLists.txt to identify PHOTOS version needed to switch off pair emission.

Moved initialisation of _fsrEngine to setRadCorrEngine.

Mutexed PHOTOS as introduced by Heather Ratcliffe.

Test Plan

Run tests for FSR in this branch and compare with master.

Diff Detail

Repository
rEVTGEN evtgen
Branch
10-merge-photos-engine
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 291
Build 291: arc lint + arc unit

Event Timeline

abudinen created this revision.
  • Reverted doRadCorr function to not be const for semantic correctness in Vincia and Sherpa interfaces.
abudinen edited the summary of this revision. (Show Details)
abudinen changed the visibility from "All Users" to "Public (No Login Required)".
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.

Great, many thanks @abudinen! I have no further comments following the thorough review already conducted in EvtGen!10. Please go ahead and land this.

This revision is now accepted and ready to land.Apr 12 2024, 3:22 PM
This revision was automatically updated to reflect the committed changes.