Page MenuHomeHEPForge

Remove broken or obsolete models
ClosedPublic

Authored by tlatham on Mar 4 2024, 5:59 PM.

Diff Detail

Repository
rEVTGEN evtgen
Branch
tlatham_T200
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 285
Build 285: arc lint + arc unit

Event Timeline

tlatham changed the visibility from "All Users" to "Public (No Login Required)".
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham added a project: Restricted Project.
tlatham added a subscriber: Restricted Project.

I have search for each removed model and class via grep in the MR branch and found entries only in the history and release-note files. Therefore, I think that an explicit mention of the removed models and classes in the history file might be useful. I also checked whether the deleted models are used at Belle II or LHCb and it seems they are not using them. I remember that @kreps mentioned that PROPSLPOLE is used at LHCb, but I did not find any decay file in the DecFiles project.

History.md
15 ↗(On Diff #451)

Wouldn't it be useful to add here the list of the models and classes removed?

  • Add lists of removed models and EvtGenBase classes

Thanks @abudinen, I've added the lists you requested to the History file.

Any further comments from anyone?

The changes look good to me.

This revision is now accepted and ready to land.Apr 11 2024, 11:40 AM

This is ready to be merged.

Rebase on master

  • Remove EvtBHadronic model
  • Remove EvtMultibody model
  • Remove EvtLb2Lll model
  • Remove EvtVPHOtoV and EvtVPHOtoVISR models
  • Remove EvtLambdaB2LambdaV models
  • Remove EvtKstarstargamma model
  • Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models
  • Remove EvtVubAC model
  • Remove EvtPropSLPole model
  • Drop unused classes from EvtGenBase
  • Tidy up test-all triggers in test script
  • Update History.md

Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.