Details
- Reviewers
jback abudinen kreps - Maniphest Tasks
- T200: Remove broken and obsolete EvtGen models
- Commits
- rEVTGEN4bd744be5869: Remove EvtVubAC model
rEVTGENf284d605d04c: Remove broken or obsolete models
rEVTGEN28ffcae2f012: Update History.md
rEVTGEN69e5191c1fbc: Tidy up test-all triggers in test script
rEVTGENc9121c28effa: Remove EvtPropSLPole model
rEVTGEN7b30d586a333: Drop unused classes from EvtGenBase
rEVTGEN064d00d9e74c: Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models
rEVTGEN037c21f5caf9: Remove EvtKstarstargamma model
rEVTGEN43a17d316d6d: Remove EvtLambdaB2LambdaV models
rEVTGEN587fa32b1e42: Remove EvtVPHOtoV and EvtVPHOtoVISR models
rEVTGENcca3c9099bf9: Remove EvtLb2Lll model
rEVTGEN98d0f2afffbd: Remove EvtMultibody model
rEVTGENfae5d017d5b5: Remove EvtBHadronic model
Already tested in CI
Diff Detail
- Repository
- rEVTGEN evtgen
- Branch
- tlatham_T200
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 285 Build 285: arc lint + arc unit
Event Timeline
I have search for each removed model and class via grep in the MR branch and found entries only in the history and release-note files. Therefore, I think that an explicit mention of the removed models and classes in the history file might be useful. I also checked whether the deleted models are used at Belle II or LHCb and it seems they are not using them. I remember that @kreps mentioned that PROPSLPOLE is used at LHCb, but I did not find any decay file in the DecFiles project.
| History.md | ||
|---|---|---|
| 15 ↗ | (On Diff #451) | Wouldn't it be useful to add here the list of the models and classes removed? |
Thanks @abudinen, I've added the lists you requested to the History file.
Any further comments from anyone?
Rebase on master
- Remove EvtBHadronic model
- Remove EvtMultibody model
- Remove EvtLb2Lll model
- Remove EvtVPHOtoV and EvtVPHOtoVISR models
- Remove EvtLambdaB2LambdaV models
- Remove EvtKstarstargamma model
- Remove EvtbsToLLLL and EvtbsToLLLLHyperCP models
- Remove EvtVubAC model
- Remove EvtPropSLPole model
- Drop unused classes from EvtGenBase
- Tidy up test-all triggers in test script
- Update History.md
Thanks both, I'll go ahead and land this. Unusually I'm going to use the "merge" strategy in this case rather than the usual "squash" strategy, since I think having the intermediate commits in the history will make it simpler to restore any individual models in the future if we need to do so.