Page MenuHomeHEPForge

Add tests for PHOTOS (T229)
ClosedPublic

Authored by abudinen on Oct 4 2023, 6:15 PM.

Details

Summary

getAttribute function made const by using EvtAttIntMap::const_iterator.

Added variables for testing of FSR.

AddedExamples for FSR tests.

Added dedicated tests for FSR with Photos.

Turned off Photos for all tests except for dedicated ones that test Photos output.

Added yesPhotos end of file name to checker.

Bug fixed missing quotation marks.

This is related with T229 and

https://gitlab.cern.ch/evtgen/evtgen/-/commits/VinciaDevelopement

Test Plan

Run all json tests again.

Diff Detail

Repository
rEVTGEN evtgen
Branch
VinciaDevelopement
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 263
Build 263: arc lint + arc unit

Event Timeline

abudinen created this revision.
abudinen changed the visibility from "All Users" to "Public (No Login Required)".
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.
abudinen added a subscriber: Restricted Project.

Thanks for this @abudinen. Do we want to add some cases for hadronic final states?

test/jsonFiles/VLL__Jpsi_ee.json
10

For this integer variable, it would make more sense to have nbins == (xmax - xmin), i.e. 10. Same comment applies to the other newly added json files.

12–13

These histograms seem to be empty even in the yesPhotos cases, so I'd drop them. Same comment applies to the other newly added json files.

  • Updated FSR testing scripts: removed empty histograms, improved binning.
In D99#2612, @tlatham wrote:

Thanks for this @abudinen. Do we want to add some cases for hadronic final states?

Hi Tom, I prefer to defer adding more tests for future differentials as we are currently focusing on interfacing with VinciaFSR and we will develop later more test based on our studies. I just implemented your comments: deleted empty histograms and modified the binning for discrete variables.

This revision is now accepted and ready to land.Oct 16 2023, 4:48 PM

Looks good now. I'll land D98 and then this one.

This revision was automatically updated to reflect the committed changes.