Differential D99 Authored by abudinen on Oct 4 2023, 6:15 PM.
Details
Summary getAttribute function made const by using EvtAttIntMap::const_iterator. Added variables for testing of FSR. AddedExamples for FSR tests. Added dedicated tests for FSR with Photos. Turned off Photos for all tests except for dedicated ones that test Photos output. Added yesPhotos end of file name to checker. Bug fixed missing quotation marks. This is related with T229 and https://gitlab.cern.ch/evtgen/evtgen/-/commits/VinciaDevelopement Test Plan Run all json tests again.
Diff Detail
Event Timelineabudinen created this revision. Harbormaster completed remote builds in B263: Diff 418.Oct 4 2023, 6:15 PM2023-10-04 18:15:26 (UTC+1) abudinen edited the summary of this revision. (Show Details)Oct 4 2023, 6:21 PM2023-10-04 18:21:26 (UTC+1) abudinen changed the visibility from "All Users" to "Public (No Login Required)". abudinen changed the edit policy from "All Users" to "Restricted Project (Project)". Comment Actions Thanks for this @abudinen. Do we want to add some cases for hadronic final states?
Harbormaster completed remote builds in B264: Diff 419.Oct 9 2023, 2:57 PM2023-10-09 14:57:36 (UTC+1) Comment Actions
Hi Tom, I prefer to defer adding more tests for future differentials as we are currently focusing on interfacing with VinciaFSR and we will develop later more test based on our studies. I just implemented your comments: deleted empty histograms and modified the binning for discrete variables. This revision is now accepted and ready to land.Oct 16 2023, 4:48 PM2023-10-16 16:48:48 (UTC+1) Closed by commit rEVTGEN12dfb11b0493: Add tests for PHOTOS (T229) (authored by abudinen, committed by tlatham). · Explain WhyOct 16 2023, 8:13 PM2023-10-16 20:13:39 (UTC+1) This revision was automatically updated to reflect the committed changes.
Revision Contents
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||