Page MenuHomeHEPForge

clang FIX-IT applied
ClosedPublic

Authored by sibid on Dec 12 2022, 8:42 PM.

Details

Summary

clang FIX-IT applied

Test Plan

clang FIX-IT applied

Diff Detail

Repository
rEVTGEN evtgen
Branch
clang_check
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 235
Build 235: arc lint + arc unit

Event Timeline

sibid requested review of this revision.Dec 12 2022, 8:42 PM
sibid created this revision.

This diff is after automatic clang fix of a nullptr usage.

tlatham changed the visibility from "All Users" to "Public (No Login Required)".Dec 13 2022, 11:45 AM
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham added a project: Restricted Project.
tlatham added a subscriber: Restricted Project.

Many thanks, this looks good. The only thing is that the source files in src/EvtGenExternal haven't been modified. Can you build with -DEVTGEN_PYTHIA=ON -DEVTGEN_PHOTOS=ON -DEVTGEN_TAUOLA=ON?

  • clang FIX-IT applied for externals

Just 3 cases missed due to an #ifdef.
Otherwise I think it's looking good.
I'll try and run all the tests on it in the next few days to make completely certain, then this can be landed.

validation/testCPVDecays.cc
262
275
296

Tests look good. Once those three extra changes are done it can be merged.

  • add explicit nullptr in places which was shielded by a macro condition
This revision is now accepted and ready to land.Dec 16 2022, 5:47 PM

Somehow I screwed up landing this and it hasn't automatically closed this revision. The changes are in master, however, so this can be closed manually.

This revision was automatically updated to reflect the committed changes.