Page MenuHomeHEPForge

Use FSR name instead of PHOTOS and deprecate PHOTOS flag.
ClosedPublic

Authored by abudinen on Apr 12 2024, 4:47 PM.

Details

Summary

Introduces FSR flag and deprecates PHOTOS flag.

It closes !9 and #9,
and is part of T250.

Updated internal function names to be getFSR()/setFSR().

Adapted new files for FSR to use new syntax.

Implemented use of neverRadCorr as originally intended.

Test Plan

Run FSR tests and compare with master.

Diff Detail

Repository
rEVTGEN evtgen
Branch
9-replace-photos-flag
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 293
Build 293: arc lint + arc unit

Event Timeline

abudinen created this revision.
abudinen changed the visibility from "All Users" to "Public (No Login Required)".
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.

Looks good to me. However, I think it would be good to have @jback check the changes introduced since his review on EvtGen!9 last Monday, in particular the neverRadCorr fix. The changes introduced in the last week can be seen here:
https://gitlab.cern.ch/evtgen/evtgen/-/compare/7e56b47604d68f89d00842409aeab2f9f1414b04...9-replace-photos-flag

I agree that these changes look OK.

This revision is now accepted and ready to land.Apr 16 2024, 2:24 PM

Great, thanks for checking it over @jback!

Thanks for checking! Ok, will land this differential.