I've attached a comparison of some of the angular distributions that was used for the Ds -> phi pi, phi -> pi pi pi0 decay (comparing this MR with those from the LHCb Sim meeting talk). It needs new decay angle calculations in the test program.

• Add cosThetaResNorm & cosBetaRes angles to testDecayModel. Used in added test file for Ds -> phi pi, phi -> pi pi pi0. Make EvtVector4R::cross() function constant.

The updated formatting looks good. This is ready to be merged for the new release.

Hi @jback, just a quick note to explain the new changes.

• Updates to clang-format style for clang 16
• Modify clang-format style to 4-space indentation
• Fix missing newline in README
• Scripts to fix indentation of Doxygen comment blocks
• Further improve formatting style
• Re-apply formatting to source files

Formatting and CI check look OK.

Yes, this is OK.

• Apply formatting in v3-patches branch

@jback, does this look ok? It's the same as the code we now have in #evtgen.

• Add warning if requested C++ standard is too old

Thanks John!

Update looks OK.

Thanks. @abudinen, I've tried to improve the clarity of the description following our discussion.

The changes look good to me. Ok, understood that this is just avoiding to use an user defined CMAKE_CXX_STANDARD if it is lower than our standard.

Clang formatting and CI check looks OK, so proceed with organising the appropriate branches.

It looks like it is going to be a nightmare to merge timedep-branch into master if we apply this formatting first (even after applying the same formatting there first).
So what I'd propose is to merge the last actual code changes into master - will create the differential for that shortly - then create a new v3-patches branch, to which this formatting can then be applied, and release v3r6 from that branch. This Differential can be updated to accomplish that part.
The formatting can then be applied to master after merging in timedep-branch - will require a separate Differential at a later date.
Does that sound reasonable?

Thanks to D101, this is now in master but needs to also be propagated to the time-dependent branch, so not yet closing this.

Closed by rLAURA9dffea19ce7b
(not sure why this didn't happen automatically)

In parallel I need to check what happens if I apply the same formatting in the timedep branch and then try and merge the branches! If that doesn’t go so well we might have to postpone this change untill after merging timedep into master.

Since this is purely formatting changes, I think the main thing to review is that the formatting style looks reasonable and that the CI check looks ok. Up to you if you want to look through all the files!!

Remove unused member variable from LauKMatrixPropagator

Many thanks for checking through this. I’ve reply to your K-matrix related question inline.

All of the changes look OK. Just have a query about some K-matrix code that is commented out. Otherwise this can be merged.