I have added some example tests for this, and have also created a task where we could add more tests for other models in the future: https://phab.hepforge.org/T205

• Add tests for Bc -> J/psi pi pi0 & psi(2S) pi BC_VHAD modes.

Somehow I screwed up landing this and it hasn't automatically closed this revision. The changes are in master, however, so this can be closed manually.

• add explicit nullptr in places which was shielded by a macro condition

Many thanks John, this looks good.

Tests look good. Once those three extra changes are done it can be merged.

• Update History file to mention D89.

Just 3 cases missed due to an #ifdef.
Otherwise I think it's looking good.
I'll try and run all the tests on it in the next few days to make completely certain, then this can be landed.

• clang FIX-IT applied for externals

Many thanks, this looks good. The only thing is that the source files in src/EvtGenExternal haven't been modified. Can you build with -DEVTGEN_PYTHIA=ON -DEVTGEN_PHOTOS=ON -DEVTGEN_TAUOLA=ON?

This diff is after automatic clang fix of a nullptr usage.

Looks like the documents contain all of the relevant information.

Update documentation of arc land

The new updates using the mass ranges look OK.

Update revision following review discussion

Hi John,

1. Yes, increasing the safety factor to 10% is sensible.

Thanks for checking it through John.

This clever solution for finding ASqMax looks OK overall, so I am approving these changes.

Hi John,