Differential D92

Bugfix probmax issue for TENSOR daughter in EvtSSD_DirectCP model.
ClosedPublic
Actions

Authored by abudinen on Mar 1 2023, 2:57 PM.

Details

Reviewers

tlatham

Commits

rEVTGENd2fecc75bda8: Bugfix probmax issue for TENSOR daughter in EvtSSD_DirectCP model.

Summary

This revision solves the task T208 (related also to T207).

Fixed initialization bug in EvtSSD_DirectCP model.

Calculation of amplitude moved to dedicated calcAmp function. Got rid of a few static variables along the way.

Changed reference PDL ids to static const to avoid recreation.

Use declare variables inside loops as const.

Modified calcAmp to be void const. Removed unneeded indentation if level in calcAmp. Implement updating of theta_max at initialisation.

Added comment for Tensor case in calcAmp.

Test Plan

Check output of relevant tests. Histograms should not vary (except for Tensor case).

Diff Detail

Repository

rEVTGEN evtgen

Branch

4-fix-probmax-issue-for-ssd_directcp-model

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 242
Build 242: arc lint + arc unit

Event Timeline

abudinen created this revision.Mar 1 2023, 2:57 PM

Harbormaster completed remote builds in B242: Diff 390.Mar 1 2023, 2:58 PM

abudinen requested review of this revision.Mar 1 2023, 2:58 PM

abudinen retitled this revision from This revision solves the task T208 (related also to T207): bugfix probmax issue for TENSOR daughter in EvtSSD_DirectCP model. Calculation of amplitude moved to dedicated calcAmp function. Got rid of a few static variables along the way. to Bugfix probmax issue for TENSOR daughter in EvtSSD_DirectCP model..Mar 1 2023, 3:02 PM

abudinen edited the summary of this revision. (Show Details)

abudinen added a reviewer: tlatham.

abudinen changed the visibility from "All Users" to "Public (No Login Required)".

abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".

abudinen added a project: Restricted Project.

abudinen added subscribers: tlatham, kreps, jback.

Looks good, thanks @abudinen.

Have you checked the histograms for the 3 test cases for this model? Everything is unchanged (apart from the prob, presumably)?

Could you also add an entry to the History.md file? It should reference this Differential revision.

In D92#2359, @tlatham wrote:

Looks good, thanks @abudinen.

Have you checked the histograms for the 3 test cases for this model? Everything is unchanged (apart from the prob, presumably)?

Could you also add an entry to the History.md file? It should reference this Differential revision.

Yes, I checked the histograms for the three cases. For scalar scalar, there is no change at all. For scalar vectors, there is only a tiny numerical difference in the prob due to the safety factor. In the tensor scalar case there are a few small differences, but this is expected as the prob was always over the probmax in that case.