Page MenuHomeHEPForge
Differential D46

Small cmake improvements for the RHEL8
ClosedPublic
Actions

Authored by averbyts on Jan 6 2021, 10:36 AM.

Details

Reviewers
jback
tlatham
kreps
Commits
rEVTGEN5948de8d429c: Small cmake improvements for the RHEL8
Summary

Small cmake improvements to reduce cmake warnings, improve Pythia8 module

Test Plan

Compile

Diff Detail

Repository
rEVTGEN evtgen
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

averbyts created this revision.Jan 6 2021, 10:36 AM
Harbormaster completed remote builds in B116: Diff 170.Jan 6 2021, 10:36 AM
averbyts added a comment.Jan 6 2021, 10:45 AM

The explicit list of languages is needed to prevent warnings in the GNUInstallDirs
" Unable to determine default CMAKE_INSTALL_LIBDIR directory because no

target architecture is known.  Please enable at least one language before
including GNUInstallDirs."

The improvement in the Pythia8 is trivial: some systems use lib64 instead of lib.

tlatham accepted this revision.Jan 6 2021, 12:17 PM
tlatham changed the visibility from "All Users" to "Public (No Login Required)".
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham added a project: Restricted Project.

Thanks for these improvements. They look fine to me.

This revision is now accepted and ready to land.Jan 6 2021, 12:18 PM
Closed by commit rEVTGEN5948de8d429c: Small cmake improvements for the RHEL8 (authored by Andrii Verbytskyi <averbyts@cern.ch>, committed by tlatham). · Explain WhyJan 6 2021, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
cmake/
Modules/
2 lines

Diff 171

View Options

CMakeLists.txt

Loading...
View Options

cmake/Modules/FindPythia8.cmake

Loading...