Paths

Table of Contentst

Differential D122

Fix compilation warnings under gcc13 and clang16
ClosedPublic
Actions

Authored by tlatham on Jun 20 2024, 5:57 PM.

Tags

Subscribers

Restricted Project

Details

Reviewers

jback
abudinen
kreps

Commits

rEVTGEN66449a7b6e0c: Fix compilation warnings under gcc13 and clang16

Summary

Fix compilation warnings under gcc13 and clang16

Additionally fix FSR options in one test JSON file

Test Plan

All tests give identical results

Diff Detail

Repository

Branch

fix_warnings

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 318
Build 318: arc lint + arc unit

Event Timeline

tlatham requested review of this revision.Jun 20 2024, 5:57 PM

tlatham created this revision.

Harbormaster completed remote builds in B318: Diff 508.Jun 20 2024, 5:57 PM

tlatham added reviewers: jback, abudinen, kreps.Jun 20 2024, 6:00 PM

tlatham changed the visibility from "All Users" to "Public (No Login Required)".

tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".

tlatham added a project: Restricted Project.

tlatham added a subscriber: Restricted Project.

Update History.md

Harbormaster completed remote builds in B319: Diff 509.Jun 20 2024, 6:00 PM

abudinen added inline comments.Jun 20 2024, 6:09 PM

src/EvtGenModels/EvtbTosllAmp.cpp
653–654	I presume this is related to an "unused" warning, as the code compiles without it.
test/jsonFiles/SVS=PHI_DALITZ__Ds_phipi_pipipi0.json
7	I think that the `dm_incohMix_B_s0` is not relevant in this case, but it does not damage to have it.

tlatham marked an inline comment as done.Jun 20 2024, 6:21 PM

tlatham added inline comments.

src/EvtGenModels/EvtbTosllAmp.cpp
653–654	Yes, that's right. It is "set but unused".
test/jsonFiles/SVS=PHI_DALITZ__Ds_phipi_pipipi0.json
7	Yes, good point. I will drop it to avoid confusion.

Minor fix to JSON

Harbormaster completed remote builds in B323: Diff 513.Jun 20 2024, 6:55 PM

tlatham marked an inline comment as done.Jun 20 2024, 6:55 PM

abudinen accepted this revision.Jun 20 2024, 6:58 PM

This revision is now accepted and ready to land.Jun 20 2024, 6:58 PM

Closed by commit rEVTGEN66449a7b6e0c: Fix compilation warnings under gcc13 and clang16 (authored by tlatham). · Explain WhyJun 20 2024, 7:00 PM

This revision was automatically updated to reflect the committed changes.

tlatham added a commit: rEVTGEN66449a7b6e0c: Fix compilation warnings under gcc13 and clang16.

Revision Contents
Changeset List

Path

Size

EvtGenBase/

EvtVectorParticle.hh

4 lines

src/

EvtGenBase/

EvtDecayBase.cpp

6 lines

EvtTensorParticle.cpp

4 lines

EvtGenModels/

5 lines

EvtSSD_DirectCP.cpp

16 lines

EvtVPHOtoVISRHi.cpp

14 lines

EvtXPsiGamma.cpp

22 lines

EvtbTosllAmp.cpp

4 lines

test/

evtgenlhc_test1.cc

8 lines

jsonFiles/

SVS=PHI_DALITZ__Ds_phipi_pipipi0.json

1 line

testDecayModel.cc

42 lines

Diff 508

EvtGenBase/EvtVectorParticle.hh

Loading...

src/EvtGenBase/EvtDecayBase.cpp

Loading...

src/EvtGenBase/EvtTensorParticle.cpp

Loading...

src/EvtGenModels/EvtBtoXsll.cpp

Loading...

src/EvtGenModels/EvtSSD_DirectCP.cpp

Loading...

src/EvtGenModels/EvtVPHOtoVISRHi.cpp

Loading...

src/EvtGenModels/EvtXPsiGamma.cpp

Loading...

src/EvtGenModels/EvtbTosllAmp.cpp

Loading...

test/evtgenlhc_test1.cc

Loading...

test/jsonFiles/SVS=PHI_DALITZ__Ds_phipi_pipipi0.json

Loading...

test/testDecayModel.cc

Loading...