HomeHEPForge
Diffusion laura 79017c77f404

Take average mistag directly from the provided user histogram

Authored by mwhitehe on Aug 26 2020, 11:06 AM.

Description

Take average mistag directly from the provided user histogram

Details

Auditors
tlatham
Committed
mwhiteheAug 26 2020, 11:06 AM
Pushed
mwhiteheAug 26 2020, 1:15 PM
Parents
rLAURAc5c3deef08af: Merge branch 'master' into timedep-branch
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Peter Whitehead <mark.peter.whitehead@cern.ch> committed rLAURA79017c77f404: Take average mistag directly from the provided user histogram (authored by Mark Peter Whitehead <mark.peter.whitehead@cern.ch>).Aug 26 2020, 11:06 AM
tlatham raised a concern with this commit.Sep 2 2020, 1:55 PM
tlatham added a subscriber: tlatham.
tlatham added inline comments.
/inc/Lau1DHistPdf.hh
44

With the added include, this can be dropped.

/src/LauFlavTag.cc
104

This is rather dangerous.
We should think if it is feasible to add the getMean member function to all PDFs, which would avoid the need for this cast.
Otherwise you should do a dynamic_cast and check the resulting pointer - if it is nullptr then push some default value (and maybe issue a warning), otherwise you can then use it to call getMean.

This commit now has outstanding concerns.Sep 2 2020, 1:55 PM
tlatham accepted this commit.Sep 3 2020, 5:42 PM

OK great, yes confirm the changes in rLAURA696d6d44a70e fix these concerns.

All concerns with this commit have now been addressed.Sep 3 2020, 5:42 PM