Page MenuHomeHEPForge
Differential D136

Fixed bug with 5th input parameters of BTOXSLL model
ClosedPublic
Actions

Authored by abudinen on Thu, Jan 23, 2:21 PM.

Details

Reviewers
kreps
tlatham
jback
Commits
rEVTGEN74adf5738c73: Fixed bug with 5th input parameters of BTOXSLL model
Summary

Fix bug whereby specifying 5th parameter of BTOXSLL model would cause first 4 to be ignored.

Added tests for the bug - required small modifications to json file checker.

This is associated with !44 and T274.

Test Plan

New tests for Belle (4 arguments) and Belle II (5 arguments) give identical results.

Diff Detail

Repository
rEVTGEN evtgen
Branch
T254-BTOXSLL-bugfix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 361
Build 361: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Thu, Jan 23, 2:21 PM
abudinen created this revision.
Harbormaster completed remote builds in B360: Diff 577.Thu, Jan 23, 2:21 PM
abudinen updated this revision to Diff 578.Thu, Jan 23, 2:24 PM
  • Updated history.
Harbormaster completed remote builds in B361: Diff 578.Thu, Jan 23, 2:24 PM
abudinen mentioned this in T274: Parameter argument Bug in BTOXSLL .Thu, Jan 23, 2:27 PM
tlatham accepted this revision.Thu, Jan 23, 6:03 PM
tlatham edited the summary of this revision. (Show Details)
tlatham changed the visibility from "All Users" to "Public (No Login Required)".
tlatham changed the edit policy from "All Users" to "Restricted Project (Project)".
tlatham added a project: Restricted Project.
tlatham added a subscriber: Restricted Project.

Looks good to me, many thanks.

This revision is now accepted and ready to land.Thu, Jan 23, 6:05 PM
Closed by commit rEVTGEN74adf5738c73: Fixed bug with 5th input parameters of BTOXSLL model (authored by abudinen). · Explain WhyThu, Jan 23, 6:19 PM
This revision was automatically updated to reflect the committed changes.
abudinen added a commit: rEVTGEN74adf5738c73: Fixed bug with 5th input parameters of BTOXSLL model.

Revision Contents
Changeset List

PathSize
3 lines
src/
EvtGenModels/
10 lines
test/
2 lines
jsonFiles/
2 lines
BTOXSLL__Bu_Xsumumu_Belle.json
BTOXSLL__Bu_Xsumumu.json
4 lines
BTOXSLL__Bu_Xsumumu_Belle2.json
BTOXSLL__Bu_Xsumumu.json
4 lines

Diff 578

View Options

History.md

Loading...
View Options

src/EvtGenModels/EvtBtoXsll.cpp

Loading...
View Options

test/checkJsonFiles.py

Loading...
View Options

test/jsonFiles/BTOXSLL__Bu_Xsumumu.json

Loading...
View Options

test/jsonFiles/BTOXSLL__Bu_Xsumumu_Belle.json

Loading...
View Options

test/jsonFiles/BTOXSLL__Bu_Xsumumu_Belle2.json

Loading...