Page MenuHomeHEPForge
Differential D134

Add support for Sherpa 3
ClosedPublic
Actions

Authored by abudinen on Mon, Dec 2, 10:17 PM.

Details

Reviewers
tlatham
kreps
jback
Commits
rEVTGENa833523b5d10: Add support for Sherpa 3
Summary

Adapted Sherpa interface to support releases 2 and 3

Update CMake modules for Sherpa 3

Move CI to LCG_106a to pick up Sherpa 3.0.0

Modify CI to use Sherpa 2 for legacy builds

Implemented modification to use PHOTONS::AddRadiation function directly.

Removed unnecessary setting of blob status

Introduced finalise function inside EvtSherpaPhotons class to control the order of static destruction.

Updated setupEvtGen script for Sherpa 3

This is related with !39 and T250.

Test Plan

Run all FSR tests for the three supported Sherpa options and check that the results are the same as with the master branch irrespective of Sherpa version.

Diff Detail

Repository
rEVTGEN evtgen
Branch
sherpa_3
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 351
Build 351: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Mon, Dec 2, 10:17 PM
abudinen created this revision.
Harbormaster completed remote builds in B350: Diff 565.Mon, Dec 2, 10:17 PM
abudinen updated this revision to Diff 566.Mon, Dec 2, 10:26 PM
  • Updated History.
Harbormaster completed remote builds in B351: Diff 566.Mon, Dec 2, 10:26 PM
abudinen edited the summary of this revision. (Show Details)Mon, Dec 2, 10:28 PM
abudinen changed the visibility from "All Users" to "Public (No Login Required)".
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.
abudinen mentioned this in T250: Add new plug-ins for Final-State-Radiation.
abudinen updated this revision to Diff 567.Tue, Dec 3, 2:51 PM
  • Removed unneeded includes, applied some reordering and comments by Tom.
Harbormaster completed remote builds in B352: Diff 567.Tue, Dec 3, 2:51 PM
abudinen updated this revision to Diff 568.Tue, Dec 3, 3:58 PM
  • Restored include needed for Sherpa 2
Harbormaster completed remote builds in B353: Diff 568.Tue, Dec 3, 3:58 PM
abudinen updated this revision to Diff 569.Tue, Dec 3, 4:56 PM
  • Added explicit include of Sherpa Blob in header.
Harbormaster completed remote builds in B354: Diff 569.Tue, Dec 3, 4:56 PM
abudinen updated this revision to Diff 570.Fri, Dec 6, 6:14 PM
  • Use unique ptr insead of new for translated particles.
Harbormaster completed remote builds in B355: Diff 570.Fri, Dec 6, 6:14 PM
abudinen updated this revision to Diff 571.Sat, Dec 7, 9:30 AM
  • Implemented comment by Tom on release of unique ptr.
Harbormaster completed remote builds in B356: Diff 571.Sat, Dec 7, 9:30 AM
jback accepted this revision.Sun, Dec 8, 9:44 PM

Following the review of this on GitLab, this is ready to be merged as well.

This revision is now accepted and ready to land.Sun, Dec 8, 9:44 PM
Closed by commit rEVTGENa833523b5d10: Add support for Sherpa 3 (authored by abudinen). · Explain WhySun, Dec 8, 11:10 PM
This revision was automatically updated to reflect the committed changes.
abudinen added a commit: rEVTGENa833523b5d10: Add support for Sherpa 3.

Revision Contents
Changeset List

PathSize
2 lines
8 lines
7 lines
EvtGenExternal/
12 lines
7 lines
cmake/
Modules/
21 lines
68 lines
src/
35 lines
EvtGenExternal/
102 lines
test/
12 lines

Diff 566

View Options

.clang-format

Loading...
View Options

.gitlab-ci.yml

Loading...
View Options

CMakeLists.txt

Loading...
View Options

EvtGenExternal/EvtSherpaPhotons.hh

Loading...
View Options

History.md

Loading...
View Options

cmake/Modules/EvtGenExternalDependencies.cmake

Loading...
View Options

setupEvtGen.sh

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/EvtGenExternal/EvtSherpaPhotons.cpp

Loading...
View Options

test/testDecayModel.cc

Loading...