Page MenuHomeHEPForge
Differential D127

Use std::lock_guard instead of mutex lock for FSR generators
ClosedPublic
Actions

Authored by abudinen on Jul 21 2024, 11:11 PM.

Details

Reviewers
kreps
tlatham
jback
Commits
rEVTGENd2f7c7812d66: Use std::lock_guard instead of mutex lock for FSR generators
Summary

Use std::lock_guard instead of mutex lock for FSR generators.

This is related with !30 and T168.

Test Plan

Tests give identical results with respect to master. CPU time remains the same.

Diff Detail

Repository
rEVTGEN evtgen
Branch
thread_safety_FSR
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 333
Build 333: arc lint + arc unit

Event Timeline

abudinen requested review of this revision.Jul 21 2024, 11:11 PM
abudinen created this revision.
Harbormaster completed remote builds in B333: Diff 528.Jul 21 2024, 11:11 PM
abudinen changed the visibility from "All Users" to "Public (No Login Required)".Jul 21 2024, 11:12 PM
abudinen changed the edit policy from "All Users" to "Restricted Project (Project)".
abudinen added a project: Restricted Project.
tlatham accepted this revision.Aug 5 2024, 3:23 PM

Thanks, this improves exception safety and makes it less likely to introduce accidental deadlocks with future changes that make early returns etc.

This revision is now accepted and ready to land.Aug 5 2024, 3:23 PM
abudinen mentioned this in T250: Add new plug-ins for Final-State-Radiation.Aug 9 2024, 10:30 AM
Closed by commit rEVTGENd2f7c7812d66: Use std::lock_guard instead of mutex lock for FSR generators (authored by abudinen). · Explain WhyAug 9 2024, 12:10 PM
This revision was automatically updated to reflect the committed changes.
abudinen added a commit: rEVTGENd2f7c7812d66: Use std::lock_guard instead of mutex lock for FSR generators.

Revision Contents
Changeset List

PathSize
3 lines
src/
EvtGenExternal/
22 lines
25 lines

Diff 528

View Options

History.md

Loading...
View Options

src/EvtGenExternal/EvtPHOTOS.cpp

Loading...
View Options

src/EvtGenExternal/EvtSherpaPhotons.cpp

Loading...